Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Song Liu <songliubraving@fb.com>
To:     Thomas Gleixner <tglx@linutronix.de>
CC:     Dave Hansen <dave.hansen@intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>, Joerg Roedel <jroedel@suse.de>,
        "Andy Lutomirski" <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        "Rik van Riel" <riel@surriel.com>
Subject: Re: [patch 1/2] x86/mm/pti: Handle unaligned address gracefully in
 pti_clone_pagetable()
Thread-Topic: [patch 1/2] x86/mm/pti: Handle unaligned address gracefully in
 pti_clone_pagetable()
Thread-Index: AQHVXa1SnM+Gh7oAvk+r6MnSURCjbqcQtC2AgAABSwCAACOGgIAAI5IAgAAHnYA=
Date:   Wed, 28 Aug 2019 20:32:54 +0000
Message-ID: <9B34E971-20ED-4A58-B086-AB94990B5A26@fb.com>
References: <20190828142445.454151604@linutronix.de>
 <20190828143123.971884723@linutronix.de>
 <55bb026c-5d54-6ebf-608f-3f376fbec4e5@intel.com>
 <alpine.DEB.2.21.1908281750410.1938@nanos.tec.linutronix.de>
 <309E5006-E869-4761-ADE2-ADB7A1A63FF1@fb.com>
 <alpine.DEB.2.21.1908282029550.1938@nanos.tec.linutronix.de>
In-Reply-To: <alpine.DEB.2.21.1908282029550.1938@nanos.tec.linutronix.de>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <BFDEBCF37323BA46B5E8877AE7E95798@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: f8d2d0e8-2346-4010-d979-08d72bf6e77f
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Aug 2019 20:32:54.0859
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XgIDyfthePOkY1IvmW0utijjtHa7JFe2HNfl6B0HwhGXMqtfTDh737sgHsT90NFeqZhVvzOnXkfatY+F6PjPTw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1680
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8
 definitions=2019-08-28_10:2019-08-28,2019-08-28 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 clxscore=1015
 priorityscore=1501 mlxscore=0 phishscore=0 mlxlogscore=999 impostorscore=0
 adultscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 bulkscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-1906280000 definitions=main-1908280202
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Aug 28, 2019, at 1:05 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
>=20
> On Wed, 28 Aug 2019, Song Liu wrote:
>>> On Aug 28, 2019, at 8:51 AM, Thomas Gleixner <tglx@linutronix.de> wrote=
:
>>>=20
>>> On Wed, 28 Aug 2019, Dave Hansen wrote:
>>>> On 8/28/19 7:24 AM, Thomas Gleixner wrote:
>>>>> From: Song Liu <songliubraving@fb.com>
>>>>>=20
>>>>> pti_clone_pmds() assumes that the supplied address is either:
>>>>>=20
>>>>> - properly PUD/PMD aligned
>>>>> or
>>>>> - the address is actually mapped which means that independent
>>>>>  of the mapping level (PUD/PMD/PTE) the next higher mapping
>>>>>  exist.
>>>>>=20
>>>>> If that's not the case the unaligned address can be incremented by PU=
D or
>>>>> PMD size wrongly. All callers supply mapped and/or aligned addresses,=
 but
>>>>> for robustness sake, it's better to handle that case proper and to em=
it a
>>>>> warning.
>>>>=20
>>>> Reviewed-by: Dave Hansen <dave.hansen@linux.intel.com>
>>>>=20
>>>> Song, did you ever root-cause the performance regression?  I thought
>>>> there were still some mysteries there.
>>>=20
>>> See Peter's series to rework the ftrace code patching ...
>>=20
>> Thanks Thomas.=20
>>=20
>> Yes, in summary, enabling ftrace or kprobe-on-ftrace causes the kernel
>> to split PMDs in kernel text mapping.=20
>>=20
>> Related question: while Peter's patches fix it for 5.3 kernel, they don'=
t=20
>> apply cleanly over 5.2 kernel (which we are using). So I wonder what is
>> the best solution for 5.2 kernel. May patch also fixes the issue:
>>=20
>> https://lore.kernel.org/lkml/20190823052335.572133-1-songliubraving@fb.c=
om/
>>=20
>> How about we apply this patch to upstream 5.2 kernel?
>=20
> That's not how it works. We fix stuff upstream and it gets backported to
> all affected kernels not just to the one you care about.

Agreed. I am trying to back port Peter's patch set to 5.2 kernel. There=20
are 9 dependencies and some manual changes.=20

>=20
> Aside of that I really disagree with that hack. You completely fail to
> explain why that commit in question broke it and instead of fixing the
> underlying issue you create a horrible workaround.
>=20
> It took me ~10 minutes to analyze the root cause and I'm just booting the
> test box with a proper fix which can be actually tagged for stable and ca=
n
> be removed from upstream again once ftrace got moved over to text poke.
>=20
> I'll post it once it's confirmed to work and I wrote a comprehensible
> changelog.

This sounds great. Thanks!

Song