Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190828064749.GA165571@LGEARND20B15> <20190828151411.GC1037350@magnolia>
In-Reply-To: <20190828151411.GC1037350@magnolia>
From:   Austin Kim <austindh.kim@gmail.com>
Date:   Thu, 29 Aug 2019 06:30:43 +0900
Message-ID: <CADLLry50iDrEfDrL3kZP_gku6jnO23qi5VVyuFY3g2BubWg0ww@mail.gmail.com>
Subject: Re: [PATCH] xfs: Use WARN_ON rather than BUG() for bailout mount-operation
To:     "Darrick J. Wong" <darrick.wong@oracle.com>
Cc:     linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Dear Mr. Darrick J. Wong

Thanks for reviewing patch. BTW, I have a question for you.

Do I have to update the patch again with 'a space before the brace'?
Or could I just wait for the patch to be imported?

It would be thankful if you give me a feedback.

BR,
Guillermo Austin Kim

2019=EB=85=84 8=EC=9B=94 29=EC=9D=BC (=EB=AA=A9) =EC=98=A4=EC=A0=84 12:14, =
Darrick J. Wong <darrick.wong@oracle.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=
=B1:
>
> On Wed, Aug 28, 2019 at 03:47:49PM +0900, Austin Kim wrote:
> > If the CONFIG_BUG is enabled, BUG() is executed and then system is cras=
hed.
> > However, the bailout for mount is no longer proceeding.
> >
> > For this reason, using WARN_ON rather than BUG() could prevent this sit=
uation.
> > ---
> >  fs/xfs/xfs_mount.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c
> > index 322da69..10fe000 100644
> > --- a/fs/xfs/xfs_mount.c
> > +++ b/fs/xfs/xfs_mount.c
> > @@ -213,8 +213,7 @@ xfs_initialize_perag(
> >                       goto out_hash_destroy;
> >
> >               spin_lock(&mp->m_perag_lock);
> > -             if (radix_tree_insert(&mp->m_perag_tree, index, pag)) {
> > -                     BUG();
> > +             if (WARN_ON(radix_tree_insert(&mp->m_perag_tree, index, p=
ag))){
>
> Need a space before the brace.
>
> Will fix on import,
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> --D
>
> >                       spin_unlock(&mp->m_perag_lock);
> >                       radix_tree_preload_end();
> >                       error =3D -EEXIST;
> > --
> > 2.6.2
> >