Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1427932ybl; Wed, 28 Aug 2019 14:41:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqyiCWGMNvBKylONvJ3I4ajtr9GPcHElHJOSDZ19IUPaC09e+5iACLeTub5XJsnWi+KEzB4w X-Received: by 2002:a17:902:e613:: with SMTP id cm19mr6016303plb.299.1567028505021; Wed, 28 Aug 2019 14:41:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567028505; cv=none; d=google.com; s=arc-20160816; b=kCHvS6GToTFBJd0FBNNIWxDitTXN+hiiwGoJbYvCKpmJBRFY8i9WSo/63zE3vo5dm5 fXDWyaM820Z8B5ONX54yfWPOWLoU3r4/7pBjSZOlCWokLn1OQ32n9PVPJg2tjpa3x41Y 22B11YSY7x3dAhqa5Wj8Y5aShoGCokGuWn3z7slwqdNJCGb6WAP0Q+XIfM78fYC3G88m Zt/BZqpFj95iWvOsKV0RzXtAxLpCZQuQtV8nuLov5jP5Hn7xkjS38pOPig4jSUtEVnwb dSasFR3+6/fxCfZCmqxMN+Z7579G2kUUsy4Kv4tjI6PuKskCZKfzHEAQijMbNO4XaO+3 HGDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=Fl6SJhDThIzLVktnxnUQoR6p6jMmSRZeGxNzVfHmfGc=; b=Sr1jweicSyK9IuH3wljqEzvKBrqbVUQ3mDUd+1kxrs1rjiDD6M8DipSfYRT++sy355 FRbgpdizQcKgyIsnAi9a+pxOO/kRNh97GcsxQNaU0aI4GUeTnJURhcwmxO3IkmC7xW6l ZFFgHreeh6Xha7RVwdlbqHff7NXzY67JELOUqZRueInnUl28UlSIFauXXMdzetuhViYJ OI3ZXskrLluXwQwNYNsSBVMVdw4Uv+z6w4moMG8hPZB45qMB9TgnZ9gju62mtlp3MDL5 8Cfz6WKDX+fYfsk6Z99zc6bFMoUEyEvEIapvO03CCTH5kfyLUPVrx3on70lsZwYArqGq R+5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=hP0eYnVn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t145si384549pfc.161.2019.08.28.14.41.29; Wed, 28 Aug 2019 14:41:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=hP0eYnVn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726965AbfH1Vki (ORCPT + 99 others); Wed, 28 Aug 2019 17:40:38 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:52191 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726787AbfH1Vki (ORCPT ); Wed, 28 Aug 2019 17:40:38 -0400 Received: by mail-wm1-f68.google.com with SMTP id k1so1564156wmi.1; Wed, 28 Aug 2019 14:40:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Fl6SJhDThIzLVktnxnUQoR6p6jMmSRZeGxNzVfHmfGc=; b=hP0eYnVngg0lq1hP3JK2h2x4x8ZP/LkgNSObaO5dsLMMR2EJ6hZWoQU0HSs2LYhSsb jZvfF3tenLWEI+TfyOXld/nC78gwghtTXq74BisZRBq370GK9BohnQcL+QB/VOVBzyRN sHUYswv7Krf01vNRoTte5Qv63es97SoJOsPRRwu8NnmyqYX+eL8ro9JYWEOuONfzdNxp QKIKfpzf935Zo9T1KzQ35aqV+s9JSs1l9PnjjYCoAWY3soLZBXfPod0i/RQpPZVAIXjn 8cFh1mpvHFd7YJpzBB7JyY2kJ8UTY+oxj5b63/JZLCRI08fYwRk3aBygjrSbuM3d0PUe pxqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Fl6SJhDThIzLVktnxnUQoR6p6jMmSRZeGxNzVfHmfGc=; b=YNXpt4eB6VwcugyOGFb7TBGkTRpMiV6Eij6/QBPawPfbSMWm8Ylf/iHoqbjsQHtLx+ s6Pm6xdzw1HsLzPt+e7Y8aAOMB/B/oI2utPUEMe5b7U2gaX+wCXlOZMVM8Ap6oc7MQ5/ FyN9KzlU3cohWgH35gxL9Wu7JMi03DoloQSJDUXwFhbtbLFSRGxqbKXudmnnV2EAgBbC +DSH4aSY2wjSxQgjn/E/U/os5UvykxxlWWQ8EYywMHRJNxf4tGK+WFylb2W8Ycvl6i32 t9XlAH0Wk89AesBjHtjcUFeG2Jz4mWYtVKM6V/m21j+nEhDqWPkknfGmmYUVHHvA1jDr 1pRQ== X-Gm-Message-State: APjAAAVJfKpy4x9H1738j3Ed277aysixvBMMmuYZL84pr1PnpDnm2np4 bqITU1mP4l/115T9di2E4jynp3yWTukebMXfK34= X-Received: by 2002:a7b:c3d4:: with SMTP id t20mr7052016wmj.71.1567028435172; Wed, 28 Aug 2019 14:40:35 -0700 (PDT) MIME-Version: 1.0 References: <20190822205533.4877-1-david.abdurachmanov@sifive.com> <201908251446.04BCB8C@keescook> In-Reply-To: <201908251446.04BCB8C@keescook> From: David Abdurachmanov Date: Wed, 28 Aug 2019 14:39:59 -0700 Message-ID: Subject: Re: [PATCH v2] riscv: add support for SECCOMP and SECCOMP_FILTER To: Kees Cook Cc: Paul Walmsley , Tycho Andersen , Palmer Dabbelt , Albert Ou , Oleg Nesterov , Andy Lutomirski , Will Drewry , Shuah Khan , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , David Abdurachmanov , Thomas Gleixner , Allison Randal , Alexios Zavras , Anup Patel , Vincent Chen , Alan Kao , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, me@carlosedp.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 28, 2019 at 10:36 AM Kees Cook wrote: > > On Fri, Aug 23, 2019 at 05:30:53PM -0700, Paul Walmsley wrote: > > On Thu, 22 Aug 2019, David Abdurachmanov wrote: > > > > > There is one failing kernel selftest: global.user_notification_signal > > > > Is this the only failing test? Or are the rest of the selftests skipped > > when this test fails, and no further tests are run, as seems to be shown > > here: > > > > https://lore.kernel.org/linux-riscv/CADnnUqcmDMRe1f+3jG8SPR6jRrnBsY8VVD70VbKEm0NqYeoicA@mail.gmail.com/ > > > > For example, looking at the source, I'd naively expect to see the > > user_notification_closed_listener test result -- which follows right > > after the failing test in the selftest source. But there aren't any > > results? > > > > Also - could you follow up with the author of this failing test to see if > > we can get some more clarity about what might be going wrong here? It > > appears that the failing test was added in commit 6a21cc50f0c7f ("seccomp: > > add a return code to trap to userspace") by Tycho Andersen > > . > > So, the original email says the riscv series is tested on top of 5.2-rc7, > but just for fun, can you confirm that you're building a tree that includes > 9dd3fcb0ab73 ("selftests/seccomp: Handle namespace failures gracefully")? I > assume it does, but I suspect something similar is happening, where the > environment is slightly different than expected and the test stalls. > > Does it behave the same way under emulation (i.e. can I hope to > reproduce this myself?) This was tested in 5.2-rc7 and later in 5.3-rc with the same behavior. Also VM or physical HW doesn't matter, same result. > > -- > Kees Cook