Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <5d6700b4.1c69fb81.24793.0bff@mx.google.com>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20190826164625.6744-1-jorge.ramirez-ortiz@linaro.org>
References: <20190826164625.6744-1-jorge.ramirez-ortiz@linaro.org>
Cc:     niklas.cassel@linaro.org, bjorn.andersson@linaro.org,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mbox: qcom: add APCS child device for QCS404
To:     agross@kernel.org, jassisinghbrar@gmail.com,
        jorge.ramirez-ortiz@linaro.org
From:   Stephen Boyd <swboyd@chromium.org>
User-Agent: alot/0.8.1
Date:   Wed, 28 Aug 2019 15:31:15 -0700
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Jorge Ramirez-Ortiz (2019-08-26 09:46:24)
> There is clock controller functionality in the APCS hardware block of
> qcs404 devices similar to msm8916.
>=20
> Co-developed-by: Niklas Cassel <niklas.cassel@linaro.org>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>  drivers/mailbox/qcom-apcs-ipc-mailbox.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qc=
om-apcs-ipc-mailbox.c
> index 705e17a5479c..76e1ad433b3f 100644
> --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> @@ -89,7 +89,11 @@ static int qcom_apcs_ipc_probe(struct platform_device =
*pdev)
>                 return ret;
>         }
> =20
> -       if (of_device_is_compatible(np, "qcom,msm8916-apcs-kpss-global"))=
 {
> +       platform_set_drvdata(pdev, apcs);

Why did this move? It's required in the child driver or something now?
Is it a Fixes sort of change?

> +
> +       if (of_device_is_compatible(np, "qcom,msm8916-apcs-kpss-global") =
||
> +           of_device_is_compatible(np, "qcom,qcs404-apcs-apps-global")) {

Maybe this should be a compatible list instead of two calls to
of_device_is_compatible().

> +
>                 apcs->clk =3D platform_device_register_data(&pdev->dev,
>                                                           "qcom-apcs-msm8=
916-clk",
>                                                           -1, NULL, 0);
> @@ -97,8 +101,6 @@ static int qcom_apcs_ipc_probe(struct platform_device =
*pdev)
>                         dev_err(&pdev->dev, "failed to register APCS clk\=
n");
>         }
> =20
> -       platform_set_drvdata(pdev, apcs);
> -
>         return 0;
>  }
> =20