Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1536036ybl; Wed, 28 Aug 2019 16:40:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqwEos3LiQidgsgncSwjhy6S9fiGnIt630nmTwaiWSBnHTJB3QQZLgJcZzZhoyUnLS02rX1J X-Received: by 2002:a17:90a:30ad:: with SMTP id h42mr6717669pjb.31.1567035629495; Wed, 28 Aug 2019 16:40:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567035629; cv=none; d=google.com; s=arc-20160816; b=lWS33U8Dql0vkMOs/ozniUtcHr70oOqWbRVsDB8bZfmDBVxYHaPc7n+daunz8L0kHN KXvS152krxT9M0goJ3IZ17RNkkoAZrsvG0PL/ODhQiR80vA+wSqJsrB+TdiQmPcNbWy+ V5Xr7a0MDeZcn909upNlEoCZ7VOtmdFRdswoejGxqQDICMi1EyJgZl7fqnV1q129TlnZ rfrqDM12gVEZPYunlSvZSly6+cWVp29wltZo5Ev4bXa+uny78Q+dFH6RwgQ12NLdzpPH eQ/55id14OQPmS5/FYJ8mnVfDa/Yiias9IEDQLvB15MXzoAhIbV61p6f4iuPNknY8jqk 0NOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:in-reply-to :subject:cc:to:from:user-agent:references; bh=FmFrZcXjXqySrlU1EmQiBTYQIcf9iN+waLiPZk8fSRA=; b=p8XcKiCznE0VP7N+i4SoWzugBaMOkMMMsiQ+waTcO4YZSA6nkn7Sw0/lVuets8b9f1 OfKmmAHgglre2txKFviTCE6CSE5NIA/2c9OfuR5qdnpYZB4Zv3E5oYBAyjE53HVP8us5 McvNuul1bvHdZ8c3xByG2rvPu7WVh5OXsPAX5WmcpC+UBQveOyR171FN0GsDQjTIdjvQ HNBQeLqwzSgyPE0BSdKJi9gMhYp8esyseQK4SHdKvIfpLnquunfG37/Pv0AB4sHfgt5J Hyu4AV2BtW2SXaXFOlMmfyhFOXItIIHDkZuWDFbcYLNd7xgIgWOjkECxVmnlXAxWtzlG iL0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x7si597614pjo.64.2019.08.28.16.40.13; Wed, 28 Aug 2019 16:40:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727126AbfH1XjP (ORCPT + 99 others); Wed, 28 Aug 2019 19:39:15 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:28312 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726926AbfH1XjO (ORCPT ); Wed, 28 Aug 2019 19:39:14 -0400 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x7SNcMW2108916; Wed, 28 Aug 2019 19:39:03 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 2up054dncw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Aug 2019 19:39:03 -0400 Received: from m0098416.ppops.net (m0098416.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.27/8.16.0.27) with SMTP id x7SNd2Km110429; Wed, 28 Aug 2019 19:39:02 -0400 Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0b-001b2d01.pphosted.com with ESMTP id 2up054dncn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Aug 2019 19:39:02 -0400 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id x7SNZnOs031535; Wed, 28 Aug 2019 23:39:01 GMT Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com [9.57.198.26]) by ppma01dal.us.ibm.com with ESMTP id 2unb3t123g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Aug 2019 23:39:01 +0000 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x7SNd0I639190984 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 28 Aug 2019 23:39:00 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D0ABE112062; Wed, 28 Aug 2019 23:39:00 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A5344112061; Wed, 28 Aug 2019 23:38:58 +0000 (GMT) Received: from morokweng.localdomain (unknown [9.85.128.122]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTPS; Wed, 28 Aug 2019 23:38:58 +0000 (GMT) References: <1567005240-12912-1-git-send-email-zohar@linux.ibm.com> User-agent: mu4e 1.2.0; emacs 26.2 From: Thiago Jung Bauermann To: Mimi Zohar Cc: linux-integrity@vger.kernel.org, Petr Vorel , Jessica Yu , Dave Young , shuah , linux-kselftest@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] sefltest/ima: support appended signatures (modsig) In-reply-to: <1567005240-12912-1-git-send-email-zohar@linux.ibm.com> Date: Wed, 28 Aug 2019 20:38:54 -0300 Message-ID: <87o908eu7l.fsf@morokweng.localdomain> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-08-28_13:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=762 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908280219 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Mimi, Mimi Zohar writes: > In addition to the PE/COFF and IMA xattr signatures, the kexec kernel > image can be signed with an appended signature, using the same > scripts/sign-file tool that is used to sign kernel modules. > > This patch adds support for detecting a kernel image signed with an > appended signature and updates the existing test messages > appropriately. > > Reviewed-by: Petr Vorel > Signed-off-by: Mimi Zohar Thanks for doing this! Reviewed-by: Thiago Jung Bauermann -- Thiago Jung Bauermann IBM Linux Technology Center