Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Peter Chen <peter.chen@nxp.com>
To:     Chuhong Yuan <hslester96@gmail.com>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: chipidea: msm: Use device-managed registration API
Thread-Topic: [PATCH] usb: chipidea: msm: Use device-managed registration API
Thread-Index: AQHVQQMqCyiV6SBdkkOiu7Ig/zYETKcQHUkAgACMCwCAAQttgA==
Date:   Thu, 29 Aug 2019 03:39:40 +0000
Message-ID: <20190829033941.GA14460@b29397-desktop>
References: <20190723030206.2919-1-hslester96@gmail.com>
 <20190828032118.GA2966@b29397-desktop>
 <CANhBUQ0PEOoVoVscO66spy0Jv4jf5wwtGKRUwa4vd=7b70kBwA@mail.gmail.com>
In-Reply-To: <CANhBUQ0PEOoVoVscO66spy0Jv4jf5wwtGKRUwa4vd=7b70kBwA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <48AB56A5E5670F41B0BE6A17F1BFAEDE@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: f12e4617-cec0-445b-c25b-08d72c328624
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Aug 2019 03:39:40.5858
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mJC0dj47BHhrBSSDWtn+MMH/D6etiDmeebXEiA3iqWm1m2MD6syqtbPofTISd2fhMv9WfcnKguVTXtUSqi6Iww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5309
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 19-08-28 19:42:32, Chuhong Yuan wrote:
> On Wed, Aug 28, 2019 at 11:24 AM Peter Chen <peter.chen@nxp.com> wrote:
> >
> > On 19-07-23 11:02:07, Chuhong Yuan wrote:
> > > Use devm_reset_controller_register to get rid
> > > of manual unregistration.
> > >
> > > Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> > > ---
> > >  drivers/usb/chipidea/ci_hdrc_msm.c | 4 +---
> > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipide=
a/ci_hdrc_msm.c
> > > index bb4645a8ca46..067542e84aea 100644
> > > --- a/drivers/usb/chipidea/ci_hdrc_msm.c
> > > +++ b/drivers/usb/chipidea/ci_hdrc_msm.c
> > > @@ -216,7 +216,7 @@ static int ci_hdrc_msm_probe(struct platform_devi=
ce *pdev)
> > >       ci->rcdev.ops =3D &ci_hdrc_msm_reset_ops;
> > >       ci->rcdev.of_node =3D pdev->dev.of_node;
> > >       ci->rcdev.nr_resets =3D 2;
> > > -     ret =3D reset_controller_register(&ci->rcdev);
> > > +     ret =3D devm_reset_controller_register(&pdev->dev, &ci->rcdev);
> > >       if (ret)
> > >               return ret;
> > >
> > > @@ -272,7 +272,6 @@ static int ci_hdrc_msm_probe(struct platform_devi=
ce *pdev)
> > >  err_iface:
> > >       clk_disable_unprepare(ci->core_clk);
> > >  err_fs:
> > > -     reset_controller_unregister(&ci->rcdev);
> >
> > It is devm API, why the unregister needs to be called at
> > fail path?
> >
>=20
> I am not very clear about your problem...
> After using devm_reset_controller_register(), I have removed
> reset_controller_unregister() calls
> in this patch.
>=20

Sorry, my fault.

Your patch is ok, but try to clean up the label "err_fs" since
it is not needed.

Peter

> > Peter
> >
> > >       return ret;
> > >  }
> > >
> > > @@ -284,7 +283,6 @@ static int ci_hdrc_msm_remove(struct platform_dev=
ice *pdev)
> > >       ci_hdrc_remove_device(ci->ci);
> > >       clk_disable_unprepare(ci->iface_clk);
> > >       clk_disable_unprepare(ci->core_clk);
> > > -     reset_controller_unregister(&ci->rcdev);
> > >
> > >       return 0;
> > >  }
> > > --
> > > 2.20.1
> > >=