Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: ILpTACtq7qGuCi4XvGX+Ju9Kwi0JWejfEA6pluxurwWnEPXXv1dxGQEN+w3UFHdNlQJP00gigo
 FwHnlE9Y4xvgHq5zH9BaH4h9rInIgkFUPlasQway5KE2U00FJaoE/KMxne3tiKzKUI5L8RmxgC
 GmwGQ4o+HyviuHX0XR8ihu9EXG3guvcXx1fXKbwYIuP1/PxPPUGfPm4K/uBEzNdAsP/5xAkzIt
 ASMxJJtKeiYJDNPjqdQNYoyakqdeiZ/RclDx34aB4yMs/rDTuq9KErZqA+IBqgmHl+mNhhiHgx
 5t4=
IronPort-PHdr: =?us-ascii?q?9a23=3ALaXjnhK+iHJ21ct9DdmcpTZWNBhigK39O0sv0r?=
 =?us-ascii?q?FitYgRL//xwZ3uMQTl6Ol3ixeRBMOHsqgC0rSP+PG8EUU7or+5+EgYd5JNUx?=
 =?us-ascii?q?JXwe43pCcHRPC/NEvgMfTxZDY7FskRHHVs/nW8LFQHUJ2mPw6arXK99yMdFQ?=
 =?us-ascii?q?viPgRpOOv1BpTSj8Oq3Oyu5pHfeQpFiCejbb9oMRm7rBjdusYSjIZtN6081g?=
 =?us-ascii?q?bHrnxUdupM2GhmP0iTnxHy5sex+J5s7SFdsO8/+sBDTKv3Yb02QaRXAzo6PW?=
 =?us-ascii?q?814tbrtQTYQguU+nQcSGQWnQFWDAXD8Rr3Q43+sir+tup6xSmaIcj7Rq06VD?=
 =?us-ascii?q?i+86tmTgLjiCIGNz4i62HXi8pwjK1Gqxy/vhJ03oDUYICLO/p6Y6zWYNcWSG?=
 =?us-ascii?q?RdUspUUSFKH4GyYJYVD+cZPehWsZTzqVUNoxW5HgSgGP/jxyVUinLswaE2z+?=
 =?us-ascii?q?IsGhzG0gw6GNIOtWzZo9f0NKYTUeC10a7IxijEYvJW2Db96JLHchE9rf2QU7?=
 =?us-ascii?q?99atfRxlU1Fw/fkFqftJHlMiqT2+8QsGab9/JtWfyzh2MjsQ18oTiiyt0yho?=
 =?us-ascii?q?XUho8Z0E3I+CF9zYotONG1SUp2bcS6HJZetyyWLZV6T8I4T2xqtys3zKANt4?=
 =?us-ascii?q?ShcygQ0psnwgbSa/mAc4eV/B3uTP2RITJkhHJ9f7K/mgqy/VCgyuLiUsm010?=
 =?us-ascii?q?5Hri9fndnNsnABzgTT6seaRvdk8EetxDKC2gTJ5uFLJkA0kqXbK5o/zbIqip?=
 =?us-ascii?q?UTtkHDEjf3mEXwkqCWal0p9va05+njeLnrpZ+RO5Vqhg3jMqkigNGzDOA8Pw?=
 =?us-ascii?q?QWWmiU4+W81Lnt/U3jR7VKi+U7k6nYsZDaP8sbp7K1DxNb34s49hawEy2m3M?=
 =?us-ascii?q?4GknYaMVJJYAiHgJTxO1HSPPD4Cu+yg1CtkDdt2vDHMaTtApbTIXjZlrfuY7?=
 =?us-ascii?q?J95lVCyAo8099f/YhYCrIfL/LpXE/+qtjYAgU+MwyuzOa0QPtn0YZLaGOdAr?=
 =?us-ascii?q?KeePfDo1+B57p3eMGRb5VTtTrgfat2r8XyhGM0zAdONZKi2oEaPSvgEw=3D?=
 =?us-ascii?q?=3D?=
From:   Yizhuo <yzhai003@ucr.edu>
Cc:     csong@cs.ucr.edu, zhiyunq@cs.ucr.edu, Yizhuo <yzhai003@ucr.edu>,
        linux-kernel@vger.kernel.org
Subject: [PATCH] adfs: obj.file_id is uninitialized if __adfs_dir_get() returns error code
Date:   Wed, 28 Aug 2019 22:35:28 -0700
Message-Id: <20190829053528.15702-1-yzhai003@ucr.edu>
To:     unlisted-recipients:; (no To-header on input)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Inside function adfs_dir_find_entry(), obj.file_id could be uninitialized
if __adfs_dir_get() returns error code. However, the return check cannot
promise the initialization of obj.file_id, which is used in the if
statement. This is potentially unsafe.

Signed-off-by: Yizhuo <yzhai003@ucr.edu>
---
 fs/adfs/dir_f.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/adfs/dir_f.c b/fs/adfs/dir_f.c
index 0fbfd0b04ae0..d7fc47598e78 100644
--- a/fs/adfs/dir_f.c
+++ b/fs/adfs/dir_f.c
@@ -335,7 +335,7 @@ adfs_dir_find_entry(struct adfs_dir *dir, unsigned long object_id)
 	ret = -ENOENT;
 
 	for (pos = 5; pos < ADFS_NUM_DIR_ENTRIES * 26 + 5; pos += 26) {
-		struct object_info obj;
+		struct object_info obj = {};
 
 		if (!__adfs_dir_get(dir, pos, &obj))
 			break;
-- 
2.17.1