Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1980736ybl; Thu, 29 Aug 2019 01:40:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqw8MBahO5s4A9fdKy8rjMvfn/Sg8GwrUOY6qMvvgeIGMN1bt8tIK+ku417IYkqvJqli7sZT X-Received: by 2002:a17:90a:feb:: with SMTP id 98mr8145388pjz.55.1567068013197; Thu, 29 Aug 2019 01:40:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567068013; cv=none; d=google.com; s=arc-20160816; b=H86by0012tqwjn/dOOpibDfOHoCldehNf1VFCdG/wj3fEawl3VqNhjowYu4qGGcl5M INtgMv0u/I0lvlLiEG35NQYr57RzTnfgKduymb70DOvn9+rF664jKpW4ixbW+lMMuHbC gRfsef4EO2HKsrRu/6op0Xz7rubsWMhvnMoTjU/aOddGhILG+S9MQXgK7GLtXnlWv7hz 0+feB0krpOOEjk/YnzKnhCAis0dMHvysKktBwpKxKwjDVwQIi9FDqPqV9yP8ASjoTnh9 GYWDYeySbC+pfnB3DUQYxoVjkX8wJjtYcV+UfhgfJFZ06q8r5wH6cyHYxug6I23K+r41 Tunw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=tXCF7AbKTiavyowWoh/vYmV9ZQwmX5kJekIVsIYLj/g=; b=mhvSBu6mgESU6vGQt8PO9odnFskYZ5a9+hc0nxsqSoFwAD3fhICnAnj3kP0v58OVdF A8lcj3oDnTzjjM4NG8YALMYU317Cdqdv2/y71bBZQEqOHPHA/eP+4mnDWdqObwQj7lzu EWRl+Xw4sCy1W9oEfDdvnpLWhKXvdFKn2/8/+nwGcmDj+kZ8e7R9uZSvnLGapkU85zv+ 3iVx6WFs0BJVHLK9VYdlY1qmx34vrUJLYgaYqLswa/tgPv0vct2s3HB0Bv4KfYgoAB8z q2BJRkgzI+0lE597mXHsAuBT4Mk5G1vD7PwyTVTXdY7Mowz2eVW7+OIsEnp6dBMoluG2 cQZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=Cfx8ykrB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s3si1351972plb.311.2019.08.29.01.39.57; Thu, 29 Aug 2019 01:40:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=Cfx8ykrB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727020AbfH2Ii7 (ORCPT + 99 others); Thu, 29 Aug 2019 04:38:59 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:37944 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726070AbfH2Ii6 (ORCPT ); Thu, 29 Aug 2019 04:38:58 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 46Jwxq4GPGz9tyg4; Thu, 29 Aug 2019 10:38:55 +0200 (CEST) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=Cfx8ykrB; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id HE3GtSajPGhf; Thu, 29 Aug 2019 10:38:55 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 46Jwxq37BMz9tyg2; Thu, 29 Aug 2019 10:38:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1567067935; bh=tXCF7AbKTiavyowWoh/vYmV9ZQwmX5kJekIVsIYLj/g=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Cfx8ykrBnE57ra6XU5KLHpxPOOQwPT5hI0EjyMJRgp6NeO5DaE5nxD1gsv/4AqXPf 1+7OA+ffewODFsUE1eySj/y6mRHDDcd3hLrwLDc9eJdMdofqX90rSO68LRTSMsNGs5 79MBd5DK+jm5kCtYycshxVcLfoaVvN+qbeMeRIzc= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 82CBD8B8AB; Thu, 29 Aug 2019 10:38:56 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id PPFRhYuRjlPE; Thu, 29 Aug 2019 10:38:56 +0200 (CEST) Received: from [192.168.204.43] (unknown [192.168.204.43]) by messagerie.si.c-s.fr (Postfix) with ESMTP id C8CFC8B7B2; Thu, 29 Aug 2019 10:38:53 +0200 (CEST) Subject: Re: [PATCH v3 3/4] powerpc/64: make buildable without CONFIG_COMPAT To: Arnd Bergmann , Christoph Hellwig Cc: Michael Neuling , Andrew Donnellan , Nicolai Stange , David Hildenbrand , Greg Kroah-Hartman , Heiko Carstens , Linux Kernel Mailing List , Nicholas Piggin , David Howells , Hari Bathini , Paul Mackerras , Joel Stanley , Christian Brauner , Firoz Khan , Breno Leitao , Geert Uytterhoeven , Thomas Gleixner , Michal Suchanek , linuxppc-dev , Allison Randal , "Eric W. Biederman" References: <0ad51b41aebf65b3f3fcb9922f0f00b47932725d.1567007242.git.msuchanek@suse.de> <20190829064624.GA28508@infradead.org> From: Christophe Leroy Message-ID: Date: Thu, 29 Aug 2019 10:38:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 29/08/2019 à 10:01, Arnd Bergmann a écrit : > On Thu, Aug 29, 2019 at 8:46 AM Christoph Hellwig wrote: > >>> @@ -277,7 +277,7 @@ static void do_signal(struct task_struct *tsk) >>> >>> rseq_signal_deliver(&ksig, tsk->thread.regs); >>> >>> - if (is32) { >>> + if ((IS_ENABLED(CONFIG_PPC32) || IS_ENABLED(CONFIG_COMPAT)) && is32) { >> >> I think we should fix the is_32bit_task definitions instead so that >> callers don't need this mess. I'd suggest something like: >> >> #ifdef CONFIG_COMPAT >> #define is_32bit_task() test_thread_flag(TIF_32BIT) >> #else >> #define is_32bit_task() IS_ENABLED(CONFIG_PPC32) >> #endif > > Are there actually any (correct) uses of is_32bit_task() outside of > #ifdef CONFIG_PPC64? There is at least stack_maxrandom_size() Also brk_rnd() and do_signal() Christophe > > I suspect most if not all could be changed to the generic > in_compat_syscall() that we use outside of architecture specific > code. > > Arnd >