Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Parav Pandit <parav@mellanox.com>
To:     Alex Williamson <alex.williamson@redhat.com>
CC:     Jiri Pirko <jiri@mellanox.com>,
        "kwankhede@nvidia.com" <kwankhede@nvidia.com>,
        "cohuck@redhat.com" <cohuck@redhat.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH v1 1/5] mdev: Introduce sha1 based mdev alias
Thread-Topic: [PATCH v1 1/5] mdev: Introduce sha1 based mdev alias
Thread-Index: AQHVXQwKr3hzuM9h9k6/weilGIZr2acRFDQAgADDoxA=
Date:   Thu, 29 Aug 2019 09:06:59 +0000
Message-ID: <AM0PR05MB486658228E2DE7FFE4327EB8D1A20@AM0PR05MB4866.eurprd05.prod.outlook.com>
References: <20190826204119.54386-1-parav@mellanox.com>
        <20190827191654.41161-1-parav@mellanox.com>
        <20190827191654.41161-2-parav@mellanox.com> <20190828152544.16ba2617@x1.home>
In-Reply-To: <20190828152544.16ba2617@x1.home>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e622d30-0c23-4094-764b-08d72c603fa9
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Aug 2019 09:06:59.1238
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FpO0r0o6Cx4Mpd042I0E20cxRWGeOQgQGIy8luyw3MwSg/WiNMEm9tKkFAEoi9IohhgXIaRq7mpumIuVtZmlIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB6113
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Alex Williamson <alex.williamson@redhat.com>
> Sent: Thursday, August 29, 2019 2:56 AM
> To: Parav Pandit <parav@mellanox.com>
> Cc: Jiri Pirko <jiri@mellanox.com>; kwankhede@nvidia.com;
> cohuck@redhat.com; davem@davemloft.net; kvm@vger.kernel.org; linux-
> kernel@vger.kernel.org; netdev@vger.kernel.org
> Subject: Re: [PATCH v1 1/5] mdev: Introduce sha1 based mdev alias
>=20

> > +	/* Allocate and init descriptor */
> > +	hash_desc =3D kvzalloc(sizeof(*hash_desc) +
> > +			     crypto_shash_descsize(alias_hash),
> > +			     GFP_KERNEL);
> > +	if (!hash_desc)
> > +		goto desc_err;
> > +
> > +	hash_desc->tfm =3D alias_hash;
> > +
> > +	digest_size =3D crypto_shash_digestsize(alias_hash);
> > +
> > +	digest =3D kzalloc(digest_size, GFP_KERNEL);
> > +	if (!digest) {
> > +		ret =3D -ENOMEM;
> > +		goto digest_err;
> > +	}
> > +	crypto_shash_init(hash_desc);
> > +	crypto_shash_update(hash_desc, uuid, UUID_STRING_LEN);
> > +	crypto_shash_final(hash_desc, digest);
>=20
> All of these can fail and many, if not most, of the callers appear that t=
hey might
> test the return value.  Thanks,
Right. Changing the signature and honoring return value in v2.

>=20
> Alex