Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 29 Aug 2019 19:18:00 +1000
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Bandan Das <bsd@redhat.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the tip tree
Message-ID: <20190829191800.28cd34c2@canb.auug.org.au>
In-Reply-To: <jpgwoewnzra.fsf@linux.bootlegged.copy>
References: <20190829080633.07c7a422@canb.auug.org.au>
        <jpgwoewnzra.fsf@linux.bootlegged.copy>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/nUfsEhJhRKB3HXl5Y4kgmEs";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--Sig_/nUfsEhJhRKB3HXl5Y4kgmEs
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Bandan,

On Thu, 29 Aug 2019 04:26:33 -0400 Bandan Das <bsd@redhat.com> wrote:
>
> Stephen Rothwell <sfr@canb.auug.org.au> writes:
>=20
> > In commit
> >
> >   bae3a8d3308e ("x86/apic: Do not initialize LDR and DFR for bigsmp")
> >
> > Fixes tag
> >
> >   Fixes: db7b9e9f26b8 ("[PATCH] Clustered APIC setup for >8 CPU systems=
")
> >
> > has these problem(s):
> >
> >   - Target SHA1 does not exist
> > =20
>=20
> I tried to dig this up and I believe that this is from pre-git.
> I went back as far as commit 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2
> Author: Linus Torvalds <torvalds@ppc970.osdl.org>
> Date:   Sat Apr 16 15:20:36 2005 -0700
>=20
>     Linux-2.6.12-rc2
>    =20
>     Initial git repository build. I'm not bothering with the full history,
>     even though we have it. We can create a separate "historical" git
>     archive of that later if we want to, and in the meantime it's about
>     3.2GB when imported into git - space that would just make the early
>     git days unnecessarily complicated, when we don't have a lot of good
>     infrastructure for it.
>    =20
>     Let it rip!
>=20
> which adds init_apic_ldr() in include/asm-i386/mach-bigsmp/mach_apic.h wi=
th
> the following:
>=20
> +static inline void init_apic_ldr(void)
> +{
> +       unsigned long val;
> +
> +       apic_write_around(APIC_DFR, APIC_DFR_VALUE);
> +       val =3D apic_read(APIC_LDR) & ~APIC_LDR_MASK;
> +       val =3D calculate_ldr(val);
> +       apic_write_around(APIC_LDR, val);
> +}
> ...
>=20
>=20
> So, the bug seems to be present here as well...

Ah ha!

commit db7b9e9f26b8 ("[PATCH] Clustered APIC setup for >8 CPU systems")
is from Thomas' history git tree ...  I should have read more of the
commit message :-(  Sorry for the noise.

--=20
Cheers,
Stephen Rothwell

--Sig_/nUfsEhJhRKB3HXl5Y4kgmEs
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl1nmEgACgkQAVBC80lX
0GxxSQf/esmj39P5SVTIqrCg5vFAtZSW+yvsY/+aXlL/KgpjzcYb+QoHdtOpggez
82a6eTmnyc2GbO0qq4YdoHULwQ1enK6W4J2ftEX3k9ougLC5ZbD2y98yFdrzUWQv
OISKd8JWMlMaMKV97GX3NoDl/qm+A3zRxrK2lqy4ptHTGY6DswEa67Q9h9L49h8k
fNoRH0EdAodf0wxFGk5MEkokkqxfItoE+Axp5fMw+QGpfVWPWsiAObP+ENmdD4iy
2Cxq4e9cjlmrStiFiQZEu2pXLBkzz+ln+yl4hDywvHjXaOXv4i9/vfx5kF+/4z3L
eG7rgD9Oa5qdAhOlZ4k8RKHY8Msmew==
=mSCw
-----END PGP SIGNATURE-----

--Sig_/nUfsEhJhRKB3HXl5Y4kgmEs--