Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp2032038ybl; Thu, 29 Aug 2019 02:33:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqx8itDuQTi6qK3w1cYGwYse8p2kWl5XtSz2IIpy5LFq+/ZQvNU83qL9ukqLMxP+XfKI0LWI X-Received: by 2002:a17:90a:8c94:: with SMTP id b20mr6730864pjo.127.1567071231611; Thu, 29 Aug 2019 02:33:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567071231; cv=none; d=google.com; s=arc-20160816; b=qQJM8+SsNGz9luReXSvriuKvVpB9iP8QXgAbSSDIbn6RDOS/2aAo0UOyscqa9CIzQI Pw6bAhVH5+tfnwo6qP17BGSqWW65ycas5fkWq4PlZuZDMQduQA1g+lKU6tOBxhvR3Gdp sl+vxXIgAmqDrfkLlLX6jLuEfElRvwao4KDdHmw3qs1HRzPAtbXRT65I2yo/CRu/ozhx OseVYy6CLCAGqWpdLDbzoWuZy5HHrFvVEsAwHkFjUvKpsJJyz73V6UtHMv2E95MZepom 6VtbvL+L3gwkSUHr24nGcFuJcR7891QkjnPWd55EbBpG6Dw5mKqC402vbz5WxUaeDvru i/JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=jXWv6rxcD/Ytdxuw9oCBSvjHqSotwy8H8FiFgT6NRRg=; b=sBAHS6Kd7ANA8n/wsuKyvhpQTuJnKhS2bIIeD+favkCDE1Jz0CZd7PYqY3UTJCFVtP OblS4Wg4vBoMOVT+FH5RJjQP1eTRf5lhIOEtGBVnewzFvKl0glbX1jiW1iaNGn5CTfDn sSSoGoIhP6i51DGzYu2dfgJYRKiDbIBxdhQHuEaTL6eCJW03gCsWsltkon19p8H45BtB uyHGnq/vhwle4ouXc3QuIc0hqvepoafg7hM7PBAbM/Hu+uvR8mhtbzNefrATAAD/8NjV 8F1aIrZQ3u3dRD+XUmDcIlK2+JEPyRpSkoYkgU9XUn8tOah/jpwk4tGwOB+OSUDP8Imu kjSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="eNdor4/f"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p5si1420053plr.161.2019.08.29.02.33.35; Thu, 29 Aug 2019 02:33:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="eNdor4/f"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726926AbfH2Jcm (ORCPT + 99 others); Thu, 29 Aug 2019 05:32:42 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:42802 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725776AbfH2Jcl (ORCPT ); Thu, 29 Aug 2019 05:32:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=jXWv6rxcD/Ytdxuw9oCBSvjHqSotwy8H8FiFgT6NRRg=; b=eNdor4/fygoZH6Xvs2bMeOvXp tLJNYDfk1cimf7+kbTn2BtXDWxLqRI4BEoxvkM59QMQwbcBMvCELCNq/zJkLCXbTBzuB4qK60s7R/ haWdRVRaEqnJlYuCV4UwO8CFnpN8keiifEYRocm9hSV7hdJbuhyANoVbu4fvGSZZTtQWctl+4PkEQ /oN+phe7MFMf78kAF3jl7VDQ4vwdv93FRJN87qRsxSrA+o2vNKwsWkTPjLWfJ6jdO987prP1KZI6Z 19zNadIV1LWue77KVSIM1O13lgtmraWBA1EkdjuK6SDKTpSqH94t7Ag5Ad+KKj2s3isfBEvJQ6hgD xAZ0rNRsA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1i3GnG-0007NX-Pm; Thu, 29 Aug 2019 09:32:38 +0000 Date: Thu, 29 Aug 2019 02:32:38 -0700 From: Christoph Hellwig To: Dan Williams Cc: Dave Chinner , Vivek Goyal , Christoph Hellwig , Miklos Szeredi , linux-nvdimm , Linux Kernel Mailing List , "Dr. David Alan Gilbert" , virtio-fs@redhat.com, Stefan Hajnoczi , linux-fsdevel Subject: Re: [PATCH 01/19] dax: remove block device dependencies Message-ID: <20190829093238.GA23102@infradead.org> References: <20190821175720.25901-1-vgoyal@redhat.com> <20190821175720.25901-2-vgoyal@redhat.com> <20190826115152.GA21051@infradead.org> <20190827163828.GA6859@redhat.com> <20190828065809.GA27426@infradead.org> <20190828175843.GB912@redhat.com> <20190828225322.GA7777@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 28, 2019 at 05:04:11PM -0700, Dan Williams wrote: > Agree. In retrospect it was my laziness in the dax-device > implementation to expect the block-device to be available. > > It looks like fs_dax_get_by_bdev() is an intercept point where a > dax_device could be dynamically created to represent the subset range > indicated by the block-device partition. That would open up more > cleanup opportunities. That seems like a decent short-term plan. But in the long I'd just let dax call into the partition table parser directly, as we might want to support partitions without first having to create a block device on top of the dax device. Same for the badblocks handling story.