Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp2086286ybl; Thu, 29 Aug 2019 03:23:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqwQ8rwYzRACS4shZgu2j32qQFEACGpFwGP3A4Ml0llXff+oTZMhYlGExHqsblU5T8aBl7SV X-Received: by 2002:a17:90a:ae15:: with SMTP id t21mr8990960pjq.50.1567074213900; Thu, 29 Aug 2019 03:23:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567074213; cv=none; d=google.com; s=arc-20160816; b=G16zdbAlcpXmA38uvG93TPsfZojteYFgyAzD9ZByVNILM1znilDnWjPAUwAl9orJ3L 9zr2MIkkJdyi/I9Gn/z979V40WPo8JFQ/QoaoogSh7g8Fd4xOXF6q+Q7oJcUYtqMpy5w jozVirxQhOQbhJfrOE63cARh0OH1SzhMwchJzdd2Uczo0k/LBoJ1Q5xNfU9Xz4tJ0Qzl TvfO01+gDd/YUOMLpSR1cHWSZB5ba6m2M0O6nlUkg7Vm4lBnc3M1uHlzUdOxxX3jXCRd A7kg6SgY6sSKnfmTqDUYRnVOIo4f/AdmmBDIuUFCN6lESYLwK6hHdP3SSpzBP4zUf/GA 5wXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=qO+zUj3gp3XMK8aYxXevKCa4918bXIn6jA5VnkcQHTU=; b=Jje9OM1j0CngoAD8AN5AYZfXmFMOl52m50nmLMdHFJ3xooCpzvp2Hd5xIIIJPpq8Ig XyO7D4qSR8BNW3yzh60x53ilcKfK/L0nwKLiF0CcgPqnbWDw5agWHkmPQq7oYHeqZfnx sH7kmCGsYTswz6mS94N9UgvKH8jSacD6xRMsaEhR82tXcFlsu5ZWU7t1id9+pyfGCyLS HZlUKFgSz9W8SZ7/ga8zFTqyqG0iSUyf/x46h39I7Ug/TRqGuC1OwmopKPJV9WymzDWr 8QV7qP7LvVZd9IUkr4eba1ESl9ZoTAXhzlQnJ2sXkHkSC0GQI5vqDWmJI2cBTZhGzVsx 56tA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DYIm9hOx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b36si1444128pla.403.2019.08.29.03.23.18; Thu, 29 Aug 2019 03:23:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DYIm9hOx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727223AbfH2KVR (ORCPT + 99 others); Thu, 29 Aug 2019 06:21:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:58252 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727139AbfH2KVR (ORCPT ); Thu, 29 Aug 2019 06:21:17 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9A1E922CF5; Thu, 29 Aug 2019 10:21:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567074076; bh=g1Vo69At6c1xR0l7nlKwcgX9mVRHSUIsRWGGsUzYoAY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DYIm9hOxhnnU9A/2IiunPz+jZr1vZXI9Ept0UHjkqAmu6KeVq1+6W2m+6DBLD3slu kKBtsuMIemVcKV92CVvNBmzhiRL3WAIcnC3rJ1YgrCMh5VoDR6zA5y+Y/YDMyabdn1 WF47KVgyK3xnhjMp9V9j01KxWHuxNTNF8EKJmH7U= Date: Thu, 29 Aug 2019 12:21:13 +0200 From: Greg Kroah-Hartman To: Marek Szyprowski Cc: linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Blumenstingl , Mathias Nyman , Felipe Balbi , Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , Jochen Sprickerhof , Anand Moon Subject: Re: [PATCH v2 1/2 RESEND] usb: core: phy: add support for PHY calibration Message-ID: <20190829102113.GA20823@kroah.com> References: <20190808094128.27213-1-m.szyprowski@samsung.com> <20190808094128.27213-2-m.szyprowski@samsung.com> <20190828204146.GA21235@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 29, 2019 at 07:26:50AM +0200, Marek Szyprowski wrote: > Hi Greg, > > On 2019-08-28 22:41, Greg Kroah-Hartman wrote: > > On Mon, Aug 26, 2019 at 10:55:33AM +0200, Marek Szyprowski wrote: > >> Hi Greg > >> > >> On 2019-08-08 11:41, Marek Szyprowski wrote: > >>> Some PHYs (for example Exynos5 USB3.0 DRD PHY) require calibration to be > >>> done after every USB HCD reset. Generic PHY framework has been already > >>> extended with phy_calibrate() function in commit 36914111e682 ("drivers: > >>> phy: add calibrate method"). This patch adds support for it to generic > >>> PHY handling code in USB HCD core. > >>> > >>> Signed-off-by: Marek Szyprowski > >>> Tested-by: Anand Moon > >>> Tested-by: Jochen Sprickerhof > >> Greg: any chance to give it this a try in -next? If not, maybe You can > >> point someone whose review will help? > > Ah crap, this is me, not the PHY maintainer :( > > > > Can you resend this and I will be glad to review it. But it would also > > be good to get Felipe's review as well. > > No problem, I will resend it again in a few minutes. Felipe already > acked it: https://lkml.org/lkml/2019/8/8/460 I don't see the resend, did I miss it? And can you add Felipe's ack to it? thanks, greg k-h