Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp2120748ybl; Thu, 29 Aug 2019 03:58:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqwLFPuQNip5P5ii3MgZJZrO1TpJXKw2E6tfgvEmR2aUbCunmxxdoY/OoEu6E8dR9g0GOfX5 X-Received: by 2002:a62:ce0e:: with SMTP id y14mr10630256pfg.73.1567076324553; Thu, 29 Aug 2019 03:58:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567076324; cv=none; d=google.com; s=arc-20160816; b=KRZyorhHPkQY9JxK5ie4fhUCoz74weU9J9guwb/EjOttyWuFSLuKtBKt4VLTVPBTp+ J5M5woCBPwWnZ+Dt5xJsC2zn/RcOq+ayiXqhaXWElr2l6eB1ySiiuKVspLMlqncxfKxq diVKmiuRKUZ0t5IXEf7WMheijKTSUvuIZw/BPn6k4SQDtE6voKsXUeYKLjZY5XVjK9ET i4rm09V6Y08XVJ9+sjznaB9pdzJ63fKg9XMIRAxfwmUYZJqFlgkrfOZumv1TQI9E78Kj QQiF+sAwpQCBDnnlTxPaI4aMpSimZhh2tnuuEYPbzR1ltaS2lr6ifo63+hLyCsZ7BxxL lsXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=zGhLBR0A7qfv6CWZPkKZEbt0N93fufawom5jHSXyEHI=; b=pEPhPnRqZ5oYDxQbnP02oDiRh78AIcuCgbdrLf+6CQi8nv95+1tdol0Ss6NdZ+VVKs xfR/NjL6lRZd0PCkvMQ7Yg9rIc4ypbFE+DzHN86VVDI9E54ZDHK2N6k0Yh4uuWHNq6Yj jO9LczHSH7Giia+1IlwgARw2coW4Nowhjfo0rf/g4rkV3tM/I7Yzut0ih5q+ZNF99mxP mwZ9RgB5cRL5HncQV9E0y99Hj0nNjy/72S7fWR8ZI4ga7xE6EoDLH/Gw9kwf/nsZRjm6 AQhjYDZ4Sj1loPduvmzB1xU0moS3B3Idz6CMRv8xcbu8WXwr7K3WosF3OtR2ODZraziQ CMDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=RK7ysFei; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id az8si1653882plb.34.2019.08.29.03.58.28; Thu, 29 Aug 2019 03:58:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=RK7ysFei; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727999AbfH2K4U (ORCPT + 99 others); Thu, 29 Aug 2019 06:56:20 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:38976 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725782AbfH2K4U (ORCPT ); Thu, 29 Aug 2019 06:56:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=zGhLBR0A7qfv6CWZPkKZEbt0N93fufawom5jHSXyEHI=; b=RK7ysFeiNsDXvG/kes172+IWv LMy2DudogAzRVGxvCcqIqdLWIUn7xAhwMJ+rrZhs3zy/czK+l3s7wItfCqxBfqG24W3ss+2Kz530V Gg3lImidY9uYIJ5fOccCQZ8UdPAM4PRWGoTPHqntfjQ3nqqR325acokq2EXI2NcjO+c2eW4c4vI2K weMfwpqRA8ZlOaKgvQG8Va4MI9MJEeMxrA5/NnEeDXtO+pf1xIZAzb6Pb7WpKXtow4NgSOHVM4lv4 HqOKuTDV5gXr/LFW7KpA+hdYXtc3BHs2z61F7AVTrU8wWLan8pqRash+CUwMKQugvHrhHE6HndtZZ V5oDci1+w==; Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1i3I6B-0002Mc-Gt; Thu, 29 Aug 2019 10:56:15 +0000 Date: Thu, 29 Aug 2019 03:56:15 -0700 From: "hch@infradead.org" To: Atish Patra Cc: "hch@infradead.org" , "aou@eecs.berkeley.edu" , "alankao@andestech.com" , "gregkh@linuxfoundation.org" , "anup@brainfault.org" , "palmer@sifive.com" , "linux-kernel@vger.kernel.org" , "rppt@linux.ibm.com" , "alexios.zavras@intel.com" , "gary@garyguo.net" , "paul.walmsley@sifive.com" , "linux-riscv@lists.infradead.org" , "tglx@linutronix.de" Subject: Re: [RFC PATCH 1/2] RISC-V: Mark existing SBI as legacy SBI. Message-ID: <20190829105615.GA8968@infradead.org> References: <20190826233256.32383-1-atish.patra@wdc.com> <20190826233256.32383-2-atish.patra@wdc.com> <20190827140304.GA21855@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 27, 2019 at 08:37:27PM +0000, Atish Patra wrote: > That would split the implementation between C file & assembly file for > no good reason. > > How about moving everything in sbi.c and just write everything inline > assembly there. Well, if we implement it in pure assembly that would be the entire implementation, wouldn't it?