Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp2131027ybl; Thu, 29 Aug 2019 04:06:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqzUdEcEt/QktsGcOuD/1UjT5tzSscVsdezAucTbZAWhb51w/PYbE+Nzd+ctAHjt9DO4w62F X-Received: by 2002:a17:902:d883:: with SMTP id b3mr9672182plz.323.1567076808235; Thu, 29 Aug 2019 04:06:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567076808; cv=none; d=google.com; s=arc-20160816; b=DZAO0YkuzhjmhbjG9IBM4+9gXk5JwKaZBvv/vGiovxGK2QLD5U9tj4acxim7kd6vw9 FHgvW5ej82BKxkV9KXmPpbzjuToPozI3MM9xp3pNk+ySXpO1bgGJ2nR5uqxHMI4lGDsx 1qGa9EJcE+xLrvJqOO7mYs6m5mLvYaRP35zv1bNibH1pfH/1v0eTByZcRcJ17Ye/NhVm disWTr+727y9EA+L37XhT57n0d6uJb5wKfjWoTkRK+CmZInUJJG2QHQSEJI07FMA3wnX SVl51CblFhgRKv1/0v3b9azQrtE2lE19a+GfXKuR/fE364q/HZoBE+9u/4ZIx74Mso36 6XkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=+FjttHpiAjq7BmjdvGxdnREsAED0YGjIw3hXS1+fR94=; b=iPt2iypoZx+I3f4VhGW6mi+imZ23SGBmiXwOEEB3vPCliDDVTBlqg6XkkruX3nDr61 gCzs2mVzqVmq9tXi5/AbBPU/w7PeQNNDxAG1Z8KiWwXzjXNXdnd9Zvyt7VDJkNJDftAY AXfAN4lBWLLOayhJ4oFfOLsSUucD78suWJRjjI+sE4hGnoWs8Fisv5MMf6g+qKvBAo03 MVVM6s4ZayGPydD1tO/b2VaYwS214YQw2VdvqJYU1RtOnglao880mSXvzNB7rKa42xBO WIP2ECCmYBr6h5BUVuFfQ/mzLvKOtJzPOdUexWb4VjlUgGRMZxoRPE+Dqoc+hx0nyhxR tt/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x21si1600103pln.397.2019.08.29.04.06.31; Thu, 29 Aug 2019 04:06:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727216AbfH2LFe (ORCPT + 99 others); Thu, 29 Aug 2019 07:05:34 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:54658 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727080AbfH2LFd (ORCPT ); Thu, 29 Aug 2019 07:05:33 -0400 Received: from DGGEMM404-HUB.china.huawei.com (unknown [172.30.72.54]) by Forcepoint Email with ESMTP id 16F821B307E7087152BD; Thu, 29 Aug 2019 19:05:31 +0800 (CST) Received: from dggeme762-chm.china.huawei.com (10.3.19.108) by DGGEMM404-HUB.china.huawei.com (10.3.20.212) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 29 Aug 2019 19:05:30 +0800 Received: from architecture4 (10.140.130.215) by dggeme762-chm.china.huawei.com (10.3.19.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Thu, 29 Aug 2019 19:05:30 +0800 Date: Thu, 29 Aug 2019 19:04:43 +0800 From: Gao Xiang To: Christoph Hellwig CC: Greg Kroah-Hartman , , Sasha Levin , Valdis =?gbk?Q?Kl=A8=A5tnieks?= , , , "OGAWA Hirofumi" Subject: Re: [PATCH] staging: exfat: add exfat filesystem code to staging Message-ID: <20190829110443.GD64893@architecture4> References: <20190828160817.6250-1-gregkh@linuxfoundation.org> <20190828170022.GA7873@kroah.com> <20190829062340.GB3047@infradead.org> <20190829063955.GA30193@kroah.com> <20190829094136.GA28643@infradead.org> <20190829095019.GA13557@kroah.com> <20190829103749.GA13661@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20190829103749.GA13661@infradead.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [10.140.130.215] X-ClientProxiedBy: dggeme707-chm.china.huawei.com (10.1.199.103) To dggeme762-chm.china.huawei.com (10.3.19.108) X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 29, 2019 at 03:37:49AM -0700, Christoph Hellwig wrote: > On Thu, Aug 29, 2019 at 11:50:19AM +0200, Greg Kroah-Hartman wrote: > > I did try just that, a few years ago, and gave up on it. I don't think > > it can be added to the existing vfat code base but I am willing to be > > proven wrong. > > And what exactly was the problem? > > > > > Now that we have the specs, it might be easier, and the vfat spec is a > > subset of the exfat spec, but to get stuff working today, for users, > > it's good to have it in staging. We can do the normal, "keep it in > > stable, get a clean-room implementation merged like usual, and then > > delete the staging version" three step process like we have done a > > number of times already as well. > > > > I know the code is horrible, but I will gladly take horrible code into > > staging. If it bothers you, just please ignore it. That's what staging > > is there for :) > > And then after a while you decide it's been long enough and force move > it out of staging like the POS erofs code? The problem is that EROFS has been there for a year and I sent v1-v8 patches here, You didn't review or reply it once until now. And I have no idea what is the relationship between EROFS and the current exfat implementation. Thanks, Gao Xiang