Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190828064749.GA165571@LGEARND20B15> <20190829075655.GD18966@infradead.org>
In-Reply-To: <20190829075655.GD18966@infradead.org>
From:   Austin Kim <austindh.kim@gmail.com>
Date:   Thu, 29 Aug 2019 21:59:17 +0900
Message-ID: <CADLLry7s=-v5cjAmu04rKad-ycOycO1UCPTpC+exL6MqbzUGtw@mail.gmail.com>
Subject: Re: [PATCH] xfs: Use WARN_ON rather than BUG() for bailout mount-operation
To:     Christoph Hellwig <hch@infradead.org>,
        "Darrick J. Wong" <darrick.wong@oracle.com>
Cc:     linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2019=EB=85=84 8=EC=9B=94 29=EC=9D=BC (=EB=AA=A9) =EC=98=A4=ED=9B=84 4:56, C=
hristoph Hellwig <hch@infradead.org>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
> On Wed, Aug 28, 2019 at 03:47:49PM +0900, Austin Kim wrote:
> > If the CONFIG_BUG is enabled, BUG() is executed and then system is cras=
hed.
> > However, the bailout for mount is no longer proceeding.
> >
> > For this reason, using WARN_ON rather than BUG() could prevent this sit=
uation.
> > ---
> >  fs/xfs/xfs_mount.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c
> > index 322da69..10fe000 100644
> > --- a/fs/xfs/xfs_mount.c
> > +++ b/fs/xfs/xfs_mount.c
> > @@ -213,8 +213,7 @@ xfs_initialize_perag(
> >                       goto out_hash_destroy;
> >
> >               spin_lock(&mp->m_perag_lock);
> > -             if (radix_tree_insert(&mp->m_perag_tree, index, pag)) {
> > -                     BUG();
> > +             if (WARN_ON(radix_tree_insert(&mp->m_perag_tree, index, p=
ag))){
>
> Please make this a WARN_ON_ONCE so that we don't see a flodding of
> messages in case of this error.
>
Hello, Mr. Christoph
Thanks for good feedback.
If the kernel log is flooded with error message, as you pointed out,
it may cause other side-effect.(e.g: system non-responsive or lockup)

To. Mr. Darrick J. Wong
If you or other kernel developers do not disagree with the
idea(WARN_ON_ONCE instead of WARN_ON),
do I have to resend the patch with new revision?

The title, the commit message and patch might be changed as followings;
=3D=3D=3D=3D=3D=3D
xfs: Use WARN_ON_ONCE rather than BUG() for bailout mount-operation

If the CONFIG_BUG is enabled, BUG() is executed and then system is crashed.
However, the bailout for mount is no longer proceeding.

For this reason, using WARN_ON_ONCE rather than BUG() could prevent
this situation.

diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c
index 322da69..d831c13 100644
--- a/fs/xfs/xfs_mount.c
+++ b/fs/xfs/xfs_mount.c
@@ -213,8 +213,7 @@ xfs_initialize_perag(
                        goto out_hash_destroy;

                spin_lock(&mp->m_perag_lock);
-               if (radix_tree_insert(&mp->m_perag_tree, index, pag)) {
-                       BUG();
+               if (WARN_ON_ONCE(radix_tree_insert(&mp->m_perag_tree,
index, pag))) {
                        spin_unlock(&mp->m_perag_lock);
                        radix_tree_preload_end();
                        error =3D -EEXIST;
=3D=3D=3D=3D=3D=3D

BR,
Guillermo Austin Kim