Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH V6 5/5] mmc: host: sdhci-pci: Add Genesys Logic GL975x
 support
To:     "Michael K. Johnson" <johnsonm@danlj.org>
Cc:     Ben Chuang <benchuanggli@gmail.com>, ulf.hansson@linaro.org,
        linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
        ben.chuang@genesyslogic.com.tw
References: <20190827003335.2494-1-benchuanggli@gmail.com>
 <99735a03-c698-624d-f5cf-4feed7e6a9ca@intel.com>
 <20190828134714.GA30547@people.danlj.org>
From:   Adrian Hunter <adrian.hunter@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki
Message-ID: <7fcd0fd5-97cb-1dab-7477-666838478541@intel.com>
Date:   Thu, 29 Aug 2019 16:21:11 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20190828134714.GA30547@people.danlj.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 28/08/19 4:47 PM, Michael K. Johnson wrote:
> On Wed, Aug 28, 2019 at 04:13:03PM +0300, Adrian Hunter wrote:
>> On 27/08/19 3:33 AM, Ben Chuang wrote:
>> Looks good, one minor comment
> ...
>>> +#ifdef CONFIG_MMC_SDHCI_IO_ACCESSORS
>>
>> Arguably CONFIG_MMC_SDHCI_IO_ACCESSORS needs to be removed altogether. i.e.
>> making the accessors always available.  So for now, I'd prefer to select
>> MMC_SDHCI_IO_ACCESSORS:
>>
>> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
>> index 14d89a108edd..c3bd967d8a1a 100644
>> --- a/drivers/mmc/host/Kconfig
>> +++ b/drivers/mmc/host/Kconfig
>> @@ -94,6 +94,7 @@ config MMC_SDHCI_PCI
>>  	depends on MMC_SDHCI && PCI
>>  	select MMC_CQHCI
>>  	select IOSF_MBI if X86
>> +	select MMC_SDHCI_IO_ACCESSORS
>>  	help
>>  	  This selects the PCI Secure Digital Host Controller Interface.
>>  	  Most controllers found today are PCI devices.
> 
> Unless I'm missing something, this seems like a separate patch;
> are you asking for it first, as a predecessor to the GLI patch?
> 

No, it is fine with this patch.