Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp2308664ybl; Thu, 29 Aug 2019 06:35:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqwcgtxxQv8nsohHLVHSc3843BOGuuxnY7Z2oI8DDxiFgD9PtJCePCr6ISiBWBXZPYU3Fl7W X-Received: by 2002:a62:ac0d:: with SMTP id v13mr11202019pfe.129.1567085743040; Thu, 29 Aug 2019 06:35:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567085743; cv=none; d=google.com; s=arc-20160816; b=Lp+WOixFdF8sy58YoNzJErVNjnpLVa4R1WX7AYUYzWooDGd2T7hg4nv6uoKodl2Z7t 8kwyY5SqwWMhbdbJhFa1A4oQB3PUoMghrHnghIX7IXItHOZ6IxNJyEreQUJbc99SXvAx w0ttGymfOBk3nZtGOvRy0zAAeCJTZCFg3RBm5CA8yvMn4xd7j1R3ouBBlTS3iFraBJRu r9h35u5S/GGgMpjDKPqa+h9Tm+HJ24FIlaP3es5AIvUzF4hBYYbaYm/4Tz3EqIlQmFlV 3UOhyOOTgHx70NsU3b8mxbi16WQ7bbARj9PFb7rDPBPTX5hSlIq2R4v5R3Og7QZUYWBb 4rMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=pbfLO54fkGctW6Jh5DnT6FdY0NlRCtGGlA8ihlh8Bok=; b=BubTW7XEZX6eRnPeckP84Gjhw377jtcrdyekU1iCNJfU9FST8gqk0baSXEQo9SWUo5 4QS/vh/gwWGA0Ev3jOZpG5sM1ZU/Nc3tv2CjKL7DjKblOxsjlcmHXEDjXjrIX+Jr0dxx QVEe7dHB/Dwd3pWOJIk3/RBs5WqgxkIukpt0UYqKhyUy8HhqnTfXFPQEFZHrPXICdQab UTHJFaJedKruWij2zTKw2qwhLcLedx07ELR74StLxj26GkxIuFmeHlD1pBBiSftgVNR6 hSaQe/EC//f8djt2A29hCK0OJtquIuT/o+cz7EMKZyMJ5uQpjPbcYJY/l7U4Vlql6B8v Dk4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cdiyZKw0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l28si1966934pgm.311.2019.08.29.06.35.26; Thu, 29 Aug 2019 06:35:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cdiyZKw0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727087AbfH2Nee (ORCPT + 99 others); Thu, 29 Aug 2019 09:34:34 -0400 Received: from mail-vk1-f195.google.com ([209.85.221.195]:35252 "EHLO mail-vk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726950AbfH2Nee (ORCPT ); Thu, 29 Aug 2019 09:34:34 -0400 Received: by mail-vk1-f195.google.com with SMTP id b184so784354vkh.2 for ; Thu, 29 Aug 2019 06:34:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pbfLO54fkGctW6Jh5DnT6FdY0NlRCtGGlA8ihlh8Bok=; b=cdiyZKw0FGDeXSaVtsL/dSzTBl/kvpt04wB3NRBsSPjBkldExDztFzwE13fsj+VK2t uF/YiKCuaLyK0iXIfwZn7zxeat6x25HBEJmKTTMrDIz0CBQ1Jx1r+y3x6ZuGzxOVJP8K TwITrVKBmm9AG4hp747UBzsTVCOuvHxyFKVsjTNY4SSVWSCOuzE2iqNbFpnbjDyZ5B6y uQZx+T6JseAnbRJwF8kxrcfaOXCjkS6W7nGnvpuNDR0Z5X7o3++Mj/fiW2HeoozAPUX7 vSh+bLSwpkq6whrzBhWz0Y950Ik4iVK6nEdDVnujiHqUYicqb3efzinJYIzs75Y6+A4Q CUqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pbfLO54fkGctW6Jh5DnT6FdY0NlRCtGGlA8ihlh8Bok=; b=Rs4ohvwbRTkJaX+ZF2Slbd9VQxDw4ZpkCHq4y/x3k+houWvAoB7JnAb9ipuwrcqL6Z NnYssyoOb/cJ5kjw8CyfDoSwjZLF8YtA0T6ZXJdKh4FL/N34y6sLBY7TVbnIsK6LqV5I Zhqul1BCBNEvMB10sOH7bsF0jv+N+MNK785JzFgQnT6Xc88EtYR51wiAgCkK3Au1U1w4 eLfEz4WhzNgzLTybHIgREC3hqfAzT8n0y9NIMiLLL2VB4l1D2VQUjd5/03qz+Sse7+3d qze0bAcGdvF+Lh0Dy/Yfedwagp3OVgQq+0OPTISvhyP78DLpzoYL5Jt2kcJ283jsdlDR utAw== X-Gm-Message-State: APjAAAXJ+UgQMpkDJdqUmlpa8NDId3QE/bpOhQgv4aBoFPHoihPkICXw XVChQyUGGZvxbZh25/JMXN88nLErcyNcejY/YxjUeg== X-Received: by 2002:a1f:5185:: with SMTP id f127mr5041539vkb.52.1567085673102; Thu, 29 Aug 2019 06:34:33 -0700 (PDT) MIME-Version: 1.0 References: <20190827003145.2249-1-benchuanggli@gmail.com> In-Reply-To: <20190827003145.2249-1-benchuanggli@gmail.com> From: Ulf Hansson Date: Thu, 29 Aug 2019 15:33:57 +0200 Message-ID: Subject: Re: [PATCH V6 0/5] Add Genesys Logic GL975x support To: Ben Chuang Cc: Adrian Hunter , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , "Michael K. Johnson" , Ben Chuang Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 27 Aug 2019 at 02:32, Ben Chuang wrote: > > From: Ben Chuang > > The patches modify internal clock setup to match SD Host Controller > Simplified Specifications 4.20 and support Genesys Logic GL9750/GL9755 chipsets. > > V6: > - export sdhci_abot_tuning() function symbol > - use C-style comments > - use BIT, FIELD_{GET,PREP} and GENMASK to define bit fields of register > - use host->ops->platform_execute_tuning instead of mmc->ops->execute_tuning > - call sdhci_reset() instead of duplicating the code in sdhci_gl9750_reset > - remove .hw_reset > - use condition define CONFIG_MMC_SDHCI_IO_ACCESSORS for read_l Applied patch 1-4, deferring patch5 for another version to fix Adrian's comment. Kind regards Uffe