Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp2453965ybl; Thu, 29 Aug 2019 08:23:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqyhkLhCpjM5AuE4VEiSor5xdfMiZdtydIktrjZSp0CU+IxhEWB0Dko41wJzDs1sfegccv1x X-Received: by 2002:a62:2aca:: with SMTP id q193mr12339581pfq.209.1567092190825; Thu, 29 Aug 2019 08:23:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567092190; cv=none; d=google.com; s=arc-20160816; b=HekBTnPegdFkT4t1lC3HXVEvhnEK9BoTKIXeWrvtZYl/41usa49F+d+x6QYL9S3tE4 UCw7lGG9Hqn6J5+hw31/XFhPughMohQn+SvoFxHA5g60Zonm791H0hs2x1XAvqrpQcXj oWrwNkOigpqdoAtm3UHBP6+/3zwvo94cxweMVfKPgnZu90ELJnKCBLDWe1PXK3Qj+Uvz ecrGdblroP4U4sK9vGnxh9Yolu6M/nG/SSsm024MFQO1+gZ3dqF6pjj+CYyMJVxQuj8/ KTgNwE7WTQF8K5B937JUhq3R/tLZnSI2wOYPoApaze+nZQ4GSAemm1J9wk9IcqNZ/sGw v1Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=6amLjpZg0DC2KK0RCVMOIF86aJoIiPCm1UiGMONqHFk=; b=QrKMqGf+cFeek/zIrGVP6ZNdd/dae7XWiPNcvq31/e5ABqbPauXi7Ewnx2fJRlT5pN ELe2X0mar44+al4RBi51J61Hb8wvn2sefGd7IicwXmBFbWNYvENeqidCmhEaH/eYyWNu gFqtOZ2xO0xG2ZR++HHbLDl+BXVIdjlvXUgJZM34DEmk13J0ijmGTYBWQSfBRqGOseUM xpmSOt9l5xMzL1h272ys1Yu3dUo5DQ8H4rNtLKJJpzKxqV84mIkTdn2s/Z/bcrJCujW6 TrIDeN4NOD1VnXxf9AiliJu8ZBdQLaKk1hD4ecivFHZgXoDPl8TPzuOIB1IlGHpyI0F5 bBcQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q11si2275243pgq.282.2019.08.29.08.22.54; Thu, 29 Aug 2019 08:23:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727650AbfH2PVc (ORCPT + 99 others); Thu, 29 Aug 2019 11:21:32 -0400 Received: from foss.arm.com ([217.140.110.172]:46682 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726739AbfH2PVc (ORCPT ); Thu, 29 Aug 2019 11:21:32 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3393528; Thu, 29 Aug 2019 08:21:31 -0700 (PDT) Received: from [10.1.196.133] (e112269-lin.cambridge.arm.com [10.1.196.133]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CFE9F3F246; Thu, 29 Aug 2019 08:21:29 -0700 (PDT) Subject: Re: [PATCH v3 01/10] KVM: arm64: Document PV-time interface To: Christoffer Dall Cc: kvm@vger.kernel.org, linux-doc@vger.kernel.org, Marc Zyngier , linux-kernel@vger.kernel.org, Russell King , Catalin Marinas , Paolo Bonzini , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org References: <20190821153656.33429-1-steven.price@arm.com> <20190821153656.33429-2-steven.price@arm.com> <20190827085706.GB6541@e113682-lin.lund.arm.com> <20190828134900.GA2113@lvm> From: Steven Price Message-ID: <33d315e5-6c17-02ff-abcc-17f11c2ce883@arm.com> Date: Thu, 29 Aug 2019 16:21:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190828134900.GA2113@lvm> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/08/2019 14:49, Christoffer Dall wrote: > On Tue, Aug 27, 2019 at 10:57:06AM +0200, Christoffer Dall wrote: >> On Wed, Aug 21, 2019 at 04:36:47PM +0100, Steven Price wrote: >>> Introduce a paravirtualization interface for KVM/arm64 based on the >>> "Arm Paravirtualized Time for Arm-Base Systems" specification DEN 0057A. >>> >>> This only adds the details about "Stolen Time" as the details of "Live >>> Physical Time" have not been fully agreed. >>> >>> User space can specify a reserved area of memory for the guest and >>> inform KVM to populate the memory with information on time that the host >>> kernel has stolen from the guest. >>> >>> A hypercall interface is provided for the guest to interrogate the >>> hypervisor's support for this interface and the location of the shared >>> memory structures. >>> >>> Signed-off-by: Steven Price >>> --- >>> Documentation/virt/kvm/arm/pvtime.txt | 100 ++++++++++++++++++++++++++ >>> 1 file changed, 100 insertions(+) >>> create mode 100644 Documentation/virt/kvm/arm/pvtime.txt >>> >>> diff --git a/Documentation/virt/kvm/arm/pvtime.txt b/Documentation/virt/kvm/arm/pvtime.txt >>> new file mode 100644 >>> index 000000000000..1ceb118694e7 >>> --- /dev/null >>> +++ b/Documentation/virt/kvm/arm/pvtime.txt >>> @@ -0,0 +1,100 @@ >>> +Paravirtualized time support for arm64 >>> +====================================== >>> + >>> +Arm specification DEN0057/A defined a standard for paravirtualised time >>> +support for AArch64 guests: >>> + >>> +https://developer.arm.com/docs/den0057/a >>> + >>> +KVM/arm64 implements the stolen time part of this specification by providing >>> +some hypervisor service calls to support a paravirtualized guest obtaining a >>> +view of the amount of time stolen from its execution. >>> + >>> +Two new SMCCC compatible hypercalls are defined: >>> + >>> +PV_FEATURES 0xC5000020 >>> +PV_TIME_ST 0xC5000022 >>> + >>> +These are only available in the SMC64/HVC64 calling convention as >>> +paravirtualized time is not available to 32 bit Arm guests. The existence of >>> +the PV_FEATURES hypercall should be probed using the SMCCC 1.1 ARCH_FEATURES >>> +mechanism before calling it. >>> + >>> +PV_FEATURES >>> + Function ID: (uint32) : 0xC5000020 >>> + PV_func_id: (uint32) : Either PV_TIME_LPT or PV_TIME_ST >>> + Return value: (int32) : NOT_SUPPORTED (-1) or SUCCESS (0) if the relevant >>> + PV-time feature is supported by the hypervisor. >>> + >>> +PV_TIME_ST >>> + Function ID: (uint32) : 0xC5000022 >>> + Return value: (int64) : IPA of the stolen time data structure for this >>> + (V)CPU. On failure: >>> + NOT_SUPPORTED (-1) >>> + >>> +The IPA returned by PV_TIME_ST should be mapped by the guest as normal memory >>> +with inner and outer write back caching attributes, in the inner shareable >>> +domain. A total of 16 bytes from the IPA returned are guaranteed to be >>> +meaningfully filled by the hypervisor (see structure below). >>> + >>> +PV_TIME_ST returns the structure for the calling VCPU. >>> + >>> +Stolen Time >>> +----------- >>> + >>> +The structure pointed to by the PV_TIME_ST hypercall is as follows: >>> + >>> + Field | Byte Length | Byte Offset | Description >>> + ----------- | ----------- | ----------- | -------------------------- >>> + Revision | 4 | 0 | Must be 0 for version 0.1 >>> + Attributes | 4 | 4 | Must be 0 >>> + Stolen time | 8 | 8 | Stolen time in unsigned >>> + | | | nanoseconds indicating how >>> + | | | much time this VCPU thread >>> + | | | was involuntarily not >>> + | | | running on a physical CPU. >>> + >>> +The structure will be updated by the hypervisor prior to scheduling a VCPU. It >>> +will be present within a reserved region of the normal memory given to the >>> +guest. The guest should not attempt to write into this memory. There is a >>> +structure per VCPU of the guest. >>> + >>> +User space interface >>> +==================== >>> + >>> +User space can request that KVM provide the paravirtualized time interface to >>> +a guest by creating a KVM_DEV_TYPE_ARM_PV_TIME device, for example: >>> + >>> + struct kvm_create_device pvtime_device = { >>> + .type = KVM_DEV_TYPE_ARM_PV_TIME, >>> + .attr = 0, >>> + .flags = 0, >>> + }; >>> + >>> + pvtime_fd = ioctl(vm_fd, KVM_CREATE_DEVICE, &pvtime_device); >>> + >>> +Creation of the device should be done after creating the vCPUs of the virtual >>> +machine. >>> + >>> +The IPA of the structures must be given to KVM. This is the base address >>> +of an array of stolen time structures (one for each VCPU). The base address >>> +must be page aligned. The size must be at least 64 * number of VCPUs and be a >>> +multiple of PAGE_SIZE. >>> + >>> +The memory for these structures should be added to the guest in the usual >>> +manner (e.g. using KVM_SET_USER_MEMORY_REGION). >>> + >>> +For example: >>> + >>> + struct kvm_dev_arm_st_region region = { >>> + .gpa = , >>> + .size = >>> + }; >> >> This feel fragile; how are you handling userspace creating VCPUs after >> setting this up, the GPA overlapping guest memory, etc. Is the >> philosophy here that the VMM can mess up the VM if it wants, but that >> this should never lead attacks on the host (we better hope not) and so >> we don't care? >> >> It seems to me setting the IPA per vcpu throught the VCPU device would >> avoid a lot of these issues. See >> Documentation/virt/kvm/devices/vcpu.txt. >> >> > I discussed this with Marc the other day, and we realized that if we > make the configuration of the IPA per-PE, then a VMM can construct a VM > where these data structures are distributed within the IPA space of a > VM, which could lead to a lower TLB pressure for some > configurations/workloads. Ok, I'm dubious it will make much difference in terms of TLB pressure, but I've done the refactoring and I think it actually simplifies the code. So I'll post a new version where the base address is set via the VCPU device. Thanks for the review, Steve