Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp2567475ybl; Thu, 29 Aug 2019 09:52:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqwXxenH+ZX5aV5Y2HtDVsdnf0KsKwt9UmO+TtOIkR6TQB6FjSRR/TPYxHL/mxcS+1RzIAe7 X-Received: by 2002:a17:902:7586:: with SMTP id j6mr3093910pll.8.1567097555544; Thu, 29 Aug 2019 09:52:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567097555; cv=none; d=google.com; s=arc-20160816; b=V5ldbRvyR13/IZ+eXZh5qw8v20MROOrkRJ+vaeGLdG3MOrX/PKdt0Zht83EQ9jGFDq V/ZX89B0RJfmnbOl7zUN2bmAHnhL3dRzFZ8Oe0cFVD2ZAp/sAdhhNWG1+YTc8qJjVoKq o3bdb+19a7Xy3V7wfdjLbvv4c3ydvUzE+zE1DUcPv6s9GOXOs9kBNtHp18NS+Zsa8HUk Mehg+PbWxexAQUN9tCjpfV7ZE9AKvFDuXwDRoibn819SQWwUBCSNqNOzCmDSyE0pfJsh waq3LiqmspL0m6oM/blJI6W6dNMkKtupSNf8K/upg3K+4S+mCBqK7buPxEShIEDKvVms QgvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=1ieTbADRtT05Y0/VomMmER6T0zXu2SWOP6oz60FuDLI=; b=kOhRKh0jp272EuBajuakWrEXeLA44a1x8+DcdagkfemN5kLXxhOT6W816vRkJe8wP/ KD7jtUppI5n4BU2CuCYv3PcW4R20yxeQv3wLm1cUZmMVK4NwaIrCKE5aH9xQeNZO8kC9 PsZBnbFFUj7c4DwY+RCgJH1k+F4tEeOpS3YDQMups13Ydf4xGocn7xm+5hGRuLODKmxi ekkIojv9qrqsmFo0b60DW7O0B0qVUaZtkrwHvVj9ZNo+seFHoqiDgcAiKZX/TR3wymPC t6eAwjjKtr0MEZLBK7b4FG5DZoinj+dZIoDlcwxDNopODNwNh3w0vH4HdZAJ1FG0cQj5 vfcQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s4si2553034pgs.25.2019.08.29.09.52.20; Thu, 29 Aug 2019 09:52:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727978AbfH2QvT (ORCPT + 99 others); Thu, 29 Aug 2019 12:51:19 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:56141 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726973AbfH2QvR (ORCPT ); Thu, 29 Aug 2019 12:51:17 -0400 Received: by mail-wm1-f67.google.com with SMTP id g207so482116wmg.5; Thu, 29 Aug 2019 09:51:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1ieTbADRtT05Y0/VomMmER6T0zXu2SWOP6oz60FuDLI=; b=WNhqjvEGtJaeN/iWXP29s40EtlnDjloZPkf1Weo6yv2cDZA9uDgY0gLS5G5cDrZTie 4TMjwFlS459MEVkb2W+rWT3O5koqUvY+yx32o7RaM3sWejRH/GpvXxmkwGxcsH4XaPd3 pf8YW3nTfd5ANAtUbd734/N7b9uJ1Bi1Q9bPUdwHkvoXJ5Kq7Tr2upWaTVFiqJquLA58 PaCmvG/5TY/KznZ1x5zLWpR4+Nmcb6EPv/NMr2R0pEGF9d5Mha2PnZdLdIUij4gvwmtk 1Yt19Hz0rRxK3PxJ2ovNN+wp9RhwycU0IvQKE5l8Pa1d5Dvm7WmPWR+fYgft2KVXt7Ix Y0TQ== X-Gm-Message-State: APjAAAWfnJaeUvhdHTOdgyoleB8p/F9xa9hq6N3G5hVwxNsmkrNsfixp PtRUlDJSdKX4R5CgmZTlmeLlB965 X-Received: by 2002:a1c:4b0a:: with SMTP id y10mr11658200wma.78.1567097475563; Thu, 29 Aug 2019 09:51:15 -0700 (PDT) Received: from green.intra.ispras.ru (bran.ispras.ru. [83.149.199.196]) by smtp.googlemail.com with ESMTPSA id o14sm8340770wrg.64.2019.08.29.09.51.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2019 09:51:15 -0700 (PDT) From: Denis Efremov To: linux-kernel@vger.kernel.org Cc: Denis Efremov , Boris Pismenny , Saeed Mahameed , Leon Romanovsky , Joe Perches , Andrew Morton , netdev@vger.kernel.org Subject: [PATCH v3 03/11] net/mlx5e: Remove unlikely() from WARN*() condition Date: Thu, 29 Aug 2019 19:50:17 +0300 Message-Id: <20190829165025.15750-3-efremov@linux.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190829165025.15750-1-efremov@linux.com> References: <20190829165025.15750-1-efremov@linux.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "unlikely(WARN_ON_ONCE(x))" is excessive. WARN_ON_ONCE() already uses unlikely() internally. Signed-off-by: Denis Efremov Cc: Boris Pismenny Cc: Saeed Mahameed Cc: Leon Romanovsky Cc: Joe Perches Cc: Andrew Morton Cc: netdev@vger.kernel.org --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c index 7833ddef0427..e5222d17df35 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c @@ -408,7 +408,7 @@ struct sk_buff *mlx5e_ktls_handle_tx_skb(struct net_device *netdev, goto out; tls_ctx = tls_get_ctx(skb->sk); - if (unlikely(WARN_ON_ONCE(tls_ctx->netdev != netdev))) + if (WARN_ON_ONCE(tls_ctx->netdev != netdev)) goto err_out; priv_tx = mlx5e_get_ktls_tx_priv_ctx(tls_ctx); -- 2.21.0