Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp2599786ybl; Thu, 29 Aug 2019 10:17:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqzW3Ue6cxdBoyMySpKNaXNXqPVVfHg7UAO65MwjPcXWz0V42Y36eo+Un/lBX6HDXH+SGt1G X-Received: by 2002:a17:90b:14c:: with SMTP id em12mr11445036pjb.28.1567099021428; Thu, 29 Aug 2019 10:17:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567099021; cv=none; d=google.com; s=arc-20160816; b=P8J9me2IyQrg2jLPo4J0t+7eF/sPd8EfkwalmgvJ9rXzrIJiwJA3GypwBVwlngCqEP 7fHgNyvnB+YuWlU8g13YidDp4FmswYhWn/rva8yCMqJSj0TgdNtdsqmwhUonLQ8YLyV5 4GlOajSmDygWe272KmvvtXJLvuAMcXOH8rDui0hl2+B6gqf/YeQlKhB5+MRreO/ErRsC mLctyJBhrBK2Fez/GShCQ+ow7jhSRVNkl8dvclgrUQWKa5ZRdvrKIBMVteH1EgImeC6w TwfkQ0ZTeRPuW5P1GV6yD+WlZxsbXqqQNE9rkQq4EeOG6HVjoylW+OTCSeUo2gdrM/Lh 3nJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=p4uTkyLP7HNuAk5BThY5DtORM+6T5xYRJOWu166gBK4=; b=kQ3eLY5jtuuzeMdxArtnyIuJ1zK4qEL9aO5xv0KB9hJRbLL2SX3x+cfHO9R13dBtwd t/b54a8/J1//zT0jmk4EiaaEUsKrd2eBiOos3Fbdn0qeRCBQaX+ELiFOCkHV6+a/qaq4 vTPoGQ0pJBPafY9US3h1OuZhMU9tr9k9qX4sp4VZmNTVWCjYCN7DRg7KrPmD8th/VQ9x eJe7lnmwZmi8XzfJ9JY/99LugIiplZJ5l5aSt5A2gRH3VV/8OWEN6P1uKPTtmadKXOrv deH2EE2p+elAtdavBxjQu+iwroD/sR59HsPEdNEvTlUQLj1P76i4TmqMVmgtzBG5AcCG E9Mg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k73si2408156pge.353.2019.08.29.10.16.45; Thu, 29 Aug 2019 10:17:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727403AbfH2RPy (ORCPT + 99 others); Thu, 29 Aug 2019 13:15:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52886 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726973AbfH2RPy (ORCPT ); Thu, 29 Aug 2019 13:15:54 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 606C43086218; Thu, 29 Aug 2019 17:15:53 +0000 (UTC) Received: from kamzik.brq.redhat.com (unknown [10.43.2.160]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DC7895D9E2; Thu, 29 Aug 2019 17:15:50 +0000 (UTC) Date: Thu, 29 Aug 2019 19:15:48 +0200 From: Andrew Jones To: Steven Price Cc: Marc Zyngier , Will Deacon , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Catalin Marinas , linux-doc@vger.kernel.org, Russell King , Paolo Bonzini Subject: Re: [PATCH v3 01/10] KVM: arm64: Document PV-time interface Message-ID: <20190829171548.xfk7i2bwnwl4w2po@kamzik.brq.redhat.com> References: <20190821153656.33429-1-steven.price@arm.com> <20190821153656.33429-2-steven.price@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190821153656.33429-2-steven.price@arm.com> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Thu, 29 Aug 2019 17:15:53 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 21, 2019 at 04:36:47PM +0100, Steven Price wrote: > Introduce a paravirtualization interface for KVM/arm64 based on the > "Arm Paravirtualized Time for Arm-Base Systems" specification DEN 0057A. > > This only adds the details about "Stolen Time" as the details of "Live > Physical Time" have not been fully agreed. > > User space can specify a reserved area of memory for the guest and > inform KVM to populate the memory with information on time that the host > kernel has stolen from the guest. > > A hypercall interface is provided for the guest to interrogate the > hypervisor's support for this interface and the location of the shared > memory structures. > > Signed-off-by: Steven Price > --- > Documentation/virt/kvm/arm/pvtime.txt | 100 ++++++++++++++++++++++++++ > 1 file changed, 100 insertions(+) > create mode 100644 Documentation/virt/kvm/arm/pvtime.txt > > diff --git a/Documentation/virt/kvm/arm/pvtime.txt b/Documentation/virt/kvm/arm/pvtime.txt > new file mode 100644 > index 000000000000..1ceb118694e7 > --- /dev/null > +++ b/Documentation/virt/kvm/arm/pvtime.txt > @@ -0,0 +1,100 @@ > +Paravirtualized time support for arm64 > +====================================== > + > +Arm specification DEN0057/A defined a standard for paravirtualised time > +support for AArch64 guests: > + > +https://developer.arm.com/docs/den0057/a > + > +KVM/arm64 implements the stolen time part of this specification by providing > +some hypervisor service calls to support a paravirtualized guest obtaining a > +view of the amount of time stolen from its execution. > + > +Two new SMCCC compatible hypercalls are defined: > + > +PV_FEATURES 0xC5000020 > +PV_TIME_ST 0xC5000022 > + > +These are only available in the SMC64/HVC64 calling convention as > +paravirtualized time is not available to 32 bit Arm guests. The existence of > +the PV_FEATURES hypercall should be probed using the SMCCC 1.1 ARCH_FEATURES > +mechanism before calling it. > + > +PV_FEATURES > + Function ID: (uint32) : 0xC5000020 > + PV_func_id: (uint32) : Either PV_TIME_LPT or PV_TIME_ST > + Return value: (int32) : NOT_SUPPORTED (-1) or SUCCESS (0) if the relevant > + PV-time feature is supported by the hypervisor. > + > +PV_TIME_ST > + Function ID: (uint32) : 0xC5000022 > + Return value: (int64) : IPA of the stolen time data structure for this > + (V)CPU. On failure: Why the () around the V in VCPU? > + NOT_SUPPORTED (-1) > + > +The IPA returned by PV_TIME_ST should be mapped by the guest as normal memory > +with inner and outer write back caching attributes, in the inner shareable > +domain. A total of 16 bytes from the IPA returned are guaranteed to be > +meaningfully filled by the hypervisor (see structure below). > + > +PV_TIME_ST returns the structure for the calling VCPU. The above sentence seems redundant here. > + > +Stolen Time > +----------- > + > +The structure pointed to by the PV_TIME_ST hypercall is as follows: > + > + Field | Byte Length | Byte Offset | Description > + ----------- | ----------- | ----------- | -------------------------- > + Revision | 4 | 0 | Must be 0 for version 0.1 > + Attributes | 4 | 4 | Must be 0 > + Stolen time | 8 | 8 | Stolen time in unsigned > + | | | nanoseconds indicating how > + | | | much time this VCPU thread > + | | | was involuntarily not > + | | | running on a physical CPU. > + > +The structure will be updated by the hypervisor prior to scheduling a VCPU. It > +will be present within a reserved region of the normal memory given to the > +guest. The guest should not attempt to write into this memory. There is a > +structure per VCPU of the guest. > + > +User space interface > +==================== > + > +User space can request that KVM provide the paravirtualized time interface to > +a guest by creating a KVM_DEV_TYPE_ARM_PV_TIME device, for example: > + > + struct kvm_create_device pvtime_device = { > + .type = KVM_DEV_TYPE_ARM_PV_TIME, > + .attr = 0, > + .flags = 0, > + }; > + > + pvtime_fd = ioctl(vm_fd, KVM_CREATE_DEVICE, &pvtime_device); The ioctl doesn't return the fd. If the ioctl returns zero the fd will be in pvtime_device.fd. > + > +Creation of the device should be done after creating the vCPUs of the virtual > +machine. Or else what? Will an error be reported in that case? > + > +The IPA of the structures must be given to KVM. This is the base address > +of an array of stolen time structures (one for each VCPU). The base address > +must be page aligned. The size must be at least 64 * number of VCPUs and be a > +multiple of PAGE_SIZE. > + > +The memory for these structures should be added to the guest in the usual > +manner (e.g. using KVM_SET_USER_MEMORY_REGION). Above it says the guest shouldn't attempt to write the memory. Should KVM_MEM_READONLY be used with KVM_SET_USER_MEMORY_REGION for it? > + > +For example: > + > + struct kvm_dev_arm_st_region region = { > + .gpa = , > + .size = > + }; > + > + struct kvm_device_attr st_base = { > + .group = KVM_DEV_ARM_PV_TIME_PADDR, This is KVM_DEV_ARM_PV_TIME_REGION in the code. > + .attr = KVM_DEV_ARM_PV_TIME_ST, > + .addr = (u64)®ion > + }; > + > + ioctl(pvtime_fd, KVM_SET_DEVICE_ATTR, &st_base); > -- > 2.20.1 > Thanks, drew