Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp2645464ybl; Thu, 29 Aug 2019 10:55:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqxCdFj/7Mi4FoTIjJP8sAxtcH1eGzhqwlRfok2UerHt1WXS4vCvb7ykh9S1ytflX3hTR/Di X-Received: by 2002:aa7:8814:: with SMTP id c20mr12849466pfo.87.1567101333504; Thu, 29 Aug 2019 10:55:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567101333; cv=none; d=google.com; s=arc-20160816; b=aK57iJGcnCOxKYPVcGc1ovFeEvdfFiX1XrS1C+BqgTqT5MnZLWgcP/a0Q1O2RHQELM XlysLcW9g6Quu5K7k4YOouMjI82nXPPy5YjmQrvZ4UJ2KKGAYYOmIE37v5tR+V3Gd3fV v5MdXPJqB2f7QDs4+UvZVSylcMmeEhpf4JbAs19xrF/O7OKAyp0tVHzdTN+KoJ/MFC/F AB98KELKlzueJ/e3i/x6Y7erGynQhCfu6lt7YHkcC1aJxqukN2FbU6zuCl5xzmYVQAyC 0VaKzYJQmhHmahCrbOtGcSDXcG94YBEVa0uv2SS+jvNZ4WCYNndA56fxCtXcTCSkr5HB hElw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=rQe28KLlHDvRerbTckpdwu9z06KjBNQSCvgEdw6K0Eg=; b=CB0XtLVRR/QHRbE3/iE+K8jeUmo+QcQmJhVTSxXm1iwL5haRHuq+Dn1Lu8pjHq+UEP TxXPCIVsexe13AW9eGwKWt/RLhZjGE7iORgBAG0AsH1xy0MfpZ9RiwaNunTGE5+U3TaH ct76eQIYmCwqMWC6KYNwpKAj1uF31G15rd/yMVm9L6Xiq5of3gJr3I3xT3ljXXHn2XSa 7PzTcO8zHNvIavuwbOxAl8XMOOAq+l5gnv7QrnE/tJW/x/rmcFFzrf/rxZu1yum7I1IP AeGeyLLBj383pSXOAS/GYoo9qM9nylWIP/Dj/19aezvC4+bEIkve7Fxct/43rr4soCWr hMiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=tT4DAN9g; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w19si3301517pfi.248.2019.08.29.10.55.17; Thu, 29 Aug 2019 10:55:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=tT4DAN9g; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727834AbfH2RxE (ORCPT + 99 others); Thu, 29 Aug 2019 13:53:04 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:39948 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727495AbfH2RxE (ORCPT ); Thu, 29 Aug 2019 13:53:04 -0400 Received: by mail-ed1-f67.google.com with SMTP id h8so4986124edv.7 for ; Thu, 29 Aug 2019 10:53:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=rQe28KLlHDvRerbTckpdwu9z06KjBNQSCvgEdw6K0Eg=; b=tT4DAN9gN76+WHbhh4TG+YpgAKU/LKtZGbtUHvgNZpZPWwwxb3Pwgp9gY7KmU56bpy Xv1Oq1K0lQufSYgylVI+058laygeoiV6N89ge00rHLiXwHGiNADSAFMw+IREzVPLdmbm 29QRSeWyqEjtFKzgmU/Oh4LEis0bpqKyTEXryAK2+G74ogQAz2rvUVehVUUgTm3guAGR tc0wT9c1rWjzmZScMBFDvQx8095V+I/Peg6OfokDBFRF8hCJTN3fBKPdwPvp0YW3qq/0 OTHoEIVl0PKVOAilqTaxbMVHTpX3mKVBd8whSWyym6Whg2ycKCFrqVDXraFG8/Rltggo Dqsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=rQe28KLlHDvRerbTckpdwu9z06KjBNQSCvgEdw6K0Eg=; b=un5iAW32SwDOrHhUIp7iCs13SI0t+ajcAxHePT/HYd8xt5NDMQEEn0hjnjW+Mey42f T2KijGpqLoMaArrQo9HIDRyLoc0XdkTt2YvhExB2iBh++HydZM3rKTYxNnl1c9hpq84G sbWXY0wmloB8AKEhFEiJUL3j52oI1C0Y1OtT5xhrvjTlevbFPFZQOgnGCvXcFnCvQXxM LuoHTKPtTjKgd1oJL9N9EH8Rv5iH7LV9P2TViUlNM97NXRQhRLD4IY4nQb4/x0GGukMB 6CPi3cUsrlxiPQaGsDB/1AUqexkc6mBQ7B0hZ8JauL5uX0Bk9pqXaCCRKor6fpg5LDxk QafA== X-Gm-Message-State: APjAAAV+Y0MkJ1Jm4J7RBVIsrjdXu7GuOKD9oUHT7IZoH6rlJOum7Zgl msjG/1ZTrqe/04tep2SriCR4AQ== X-Received: by 2002:a50:b155:: with SMTP id l21mr11232219edd.186.1567101182497; Thu, 29 Aug 2019 10:53:02 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id w3sm562294edq.12.2019.08.29.10.53.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2019 10:53:02 -0700 (PDT) Date: Thu, 29 Aug 2019 10:52:37 -0700 From: Jakub Kicinski To: YueHaibing Cc: , , , Subject: Re: [PATCH] amd-xgbe: Fix error path in xgbe_mod_init() Message-ID: <20190829105237.196722f9@cakuba.netronome.com> In-Reply-To: <20190829024600.16052-1-yuehaibing@huawei.com> References: <20190829024600.16052-1-yuehaibing@huawei.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 29 Aug 2019 10:46:00 +0800, YueHaibing wrote: > In xgbe_mod_init(), we should do cleanup if some error occurs > > Reported-by: Hulk Robot > Fixes: efbaa828330a ("amd-xgbe: Add support to handle device renaming") > Fixes: 47f164deab22 ("amd-xgbe: Add PCI device support") > Signed-off-by: YueHaibing Looks correct. For networking fixes please try to use [PATCH net] as a tag ([PATCH net-next] for normal, non-fix patches).