Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp3013583ybl; Thu, 29 Aug 2019 16:54:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqx3o6Z698jOh9gHpAQNTU7jdSG/o0BHWG1YiTAmFXC6AQ5I2ZeUplDPCPSMFaoXbyJcN6pS X-Received: by 2002:a17:902:1121:: with SMTP id d30mr12669149pla.174.1567122856532; Thu, 29 Aug 2019 16:54:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567122856; cv=none; d=google.com; s=arc-20160816; b=uioNMWTwBBlMwHYDegSGngZnr/Tzz0P3gZLXx40eUPcSwWjGnYMXvUZCJ8ktxfccWw EIDOqMyQjbc9tVi+9PPJsZLCvqeXFVSqG1fHhO8M0uTyNrYbbhmGctYt8vBpeHQjlwQy kuNNQG5V/PwkaHGcUkfJWBvaJjsaBiTDkMNFcGBH2IESlf0Ck5EbCmiZSpTf6k4p14ul sUQRI9Xhr704zmKW4y5d+lkiB+KKOWwYbymPL+L9EWcP6AmFg235Rx5UW13Glw1VGtyA oTzz5WJprSbVCjHxjXKsckhcI9FxiydDphwlnaXhMrYtqM/+ew0dX4pUZDkcSbAHDVFq LDIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=6oTB1dU146xuL9pK4Gwg180KU60SGC31jIorRGs7ptk=; b=cLvYXTxe/9r+A7q3v+UXdnno9NKsueObpb95iF3M9AefHNwbqELAvfxEQ3+6yO+/9+ /1oilEDkxk21RiRnajX5PpQBvd9J+i0zaFM+H7EVfo/WtPRX+BA0KKbQhsTE3yegyPcf 6Kw6H+XY2eCW7h8Ypv/SGUxrsOrXGEyeepYD0qiixziQwqAmO/eZT0gWBha5oGwn0iWW 0QbXaO6d9AFfO1JaoY4LtDVzJ1wB1JZUCtFn5cdaKxKt7olgxiqMNbZxJs4TFIVG1VT5 x1KS6XWwAPPTe0oupu661C5qssLA2DleVZkPIWMonvrLaIwA3Bm+kAwyMKdIdOfFriC1 SkgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=a250Zfx3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s12si3314121plp.290.2019.08.29.16.54.00; Thu, 29 Aug 2019 16:54:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=a250Zfx3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727041AbfH2Xw7 (ORCPT + 99 others); Thu, 29 Aug 2019 19:52:59 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:43784 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726670AbfH2Xw7 (ORCPT ); Thu, 29 Aug 2019 19:52:59 -0400 Received: by mail-pg1-f195.google.com with SMTP id k3so2453173pgb.10 for ; Thu, 29 Aug 2019 16:52:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6oTB1dU146xuL9pK4Gwg180KU60SGC31jIorRGs7ptk=; b=a250Zfx3hOfWzOHrL5E2dEv/6jxRZA+JbksFHHqddgm0GXvE1i4OV0Ui/sUUwWq9Qz 4sKMyiAb+MJUEMoErBcXFPrcnPtDT2GaH8lfEelAqVK5nG8PlK407kkkx6hvjFc6VoV9 U33PcQmOIjjinVTDjaCccNNDE79eJ2UxQkEfA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6oTB1dU146xuL9pK4Gwg180KU60SGC31jIorRGs7ptk=; b=NHSxRhCg0C5J4mGbagLiKZYrWR4/s2fLsVO0O1HAYNL8SJQH/K0Ve9tRSeF0SWp01K w7ILi6ERKc9ONDamoCv0tFhe4IdFp4OQQkBW5X9QpMJVLtBPgfxNEBhN4nvlovQtasAf e972j+IDAIhOuDwkU0Ndh5qeLsth8kUJ/XFLyed3DZXvhvwkNkUsDagBs/gVxFbK5dIe iHJEV+aLx2Tgqebmz1hVmQ0NOQj/Xwrz3wyx/vEQYFwXGutOnWyyjB2fVVLbR9Knq+SC h2PoxBcutNuMtvPOsOI+sVDroC+CMjQwkHDg7uW3yv9bwV1p3TxyO8aLJ7ED8xQ0pwyf ugWg== X-Gm-Message-State: APjAAAXS3YAqu4iwqawWwbXeaEAkLo4lpSKYMsbpldvojMfLO5D+Ozx4 Tx0qEQq8emcqgHjkxJnIxbRf8Q== X-Received: by 2002:a62:1a45:: with SMTP id a66mr15134237pfa.142.1567122778338; Thu, 29 Aug 2019 16:52:58 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id v189sm4473046pfv.176.2019.08.29.16.52.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2019 16:52:57 -0700 (PDT) Date: Thu, 29 Aug 2019 16:52:56 -0700 From: Kees Cook To: Chuhong Yuan Cc: Tejun Heo , Li Zefan , Johannes Weiner , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Joe Perches , Laura Abbott , Michael Ellerman , Steven Rostedt Subject: Re: [PATCH 01/12] rdmacg: Replace strncmp with str_has_prefix Message-ID: <201908291652.46E2D65@keescook> References: <20190729151346.9280-1-hslester96@gmail.com> <201907292117.DA40CA7D@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 30, 2019 at 02:39:40PM +0800, Chuhong Yuan wrote: > I think with the help of Coccinelle script, all strncmp(str, const, len) > can be replaced and these problems will be eliminated. :) Hi! Just pinging this thread again. Any progress on this conversion? Thanks! -- Kees Cook