Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] tpm_tis: Fix interrupt probing
To:     Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc:     Stefan Berger <stefanb@linux.vnet.ibm.com>,
        linux-integrity@vger.kernel.org,
        linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20190820122517.2086223-1-stefanb@linux.vnet.ibm.com>
 <20190827131400.qchcwa2act24c47b@linux.intel.com>
 <20190827151915.hb4xwr2vik2i5ryb@linux.intel.com>
 <797ff54e-dceb-21d2-dd74-e5244f9c6dfd@linux.ibm.com>
 <20190829132021.6vfc535ecb62jokf@linux.intel.com>
 <20190829161057.22l72j55jy3dyib7@linux.intel.com>
From:   Stefan Berger <stefanb@linux.ibm.com>
Message-ID: <039601c6-e22a-d113-0eb2-ee2a206f5b73@linux.ibm.com>
Date:   Thu, 29 Aug 2019 20:11:27 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <20190829161057.22l72j55jy3dyib7@linux.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-MW
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 8/29/19 12:10 PM, Jarkko Sakkinen wrote:
> On Thu, Aug 29, 2019 at 04:20:21PM +0300, Jarkko Sakkinen wrote:
>> On Tue, Aug 27, 2019 at 03:34:36PM -0400, Stefan Berger wrote:
>>> On 8/27/19 11:19 AM, Jarkko Sakkinen wrote:
>>>> On Tue, Aug 27, 2019 at 04:14:00PM +0300, Jarkko Sakkinen wrote:
>>>>> On Tue, Aug 20, 2019 at 08:25:17AM -0400, Stefan Berger wrote:
>>>>>> From: Stefan Berger <stefanb@linux.ibm.com>
>>>>>>
>>>>>> The interrupt probing of the TPM TIS was broken since we are trying to
>>>>>> run it without an active locality and without the TPM_CHIP_FLAG_IRQ set.
>>>>>>
>>>>>> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
>>>>> Need these:
>>>>>
>>>>> Cc: linux-stable@vger.kernel.org
>>>>> Fixes: a3fbfae82b4c ("tpm: take TPM chip power gating out of tpm_transmit()")
>>>>>
>>>>> Thank you. I'll apply this to my tree.
>>>>>
>>>>> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>>>> The commit went in the following form:
>>>>
>>>> http://git.infradead.org/users/jjs/linux-tpmdd.git/commit/9b558deab2c5d7dc23d5f7a4064892ede482ad32
>>> I saw you dropped the stetting of the IRQ flag - I needed it, otherwise it
>>> wouldn't execute certain code paths.
>> I explained why I removed that part. There was no any reasoning for
>> it. Also, it cannot be in the same commit if it fixes a diffent
>> issue.
> AFAIK they go with different fixes-tags.

I sent a separate patch for this. It looks like this bug goes back to 
when the TPM_CHIP_FLAG_IRQ was introduced in March 2019?!

    Stefan