Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <CGME20190813105359eucas1p2c4fecf74be23d3e7739a61c55050bc89@eucas1p2.samsung.com>
 <20190813105337.3065-1-a.swigon@partner.samsung.com>
In-Reply-To: <20190813105337.3065-1-a.swigon@partner.samsung.com>
From:   Mike Marshall <hubcap@omnibond.com>
Date:   Thu, 29 Aug 2019 21:28:12 -0400
Message-ID: <CAOg9mSTCwb6fd0SfWYgVGoQ9gsSjPGNYwBDHMV3b9hBzGFHQgg@mail.gmail.com>
Subject: Re: [PATCH] orangefs: Add octal zero prefix
To:     =?UTF-8?B?QXJ0dXIgxZp3aWdvxYQ=?= <a.swigon@partner.samsung.com>
Cc:     devel@lists.orangefs.org, LKML <linux-kernel@vger.kernel.org>,
        Martin Brandenburg <martin@omnibond.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thanks for catching this, I added this patch on top of Linux 5.3-rc6 and
ran xfstests on orangefs with no regressions.

Acked-by: Mike Marshall <hubcap@omnibond.com>

-Mike


On Tue, Aug 13, 2019 at 6:54 AM Artur =C5=9Awigo=C5=84
<a.swigon@partner.samsung.com> wrote:
>
> This patch adds a missing zero to mode 755 specification required to
> express it in octal numeral system.
>
> Reported-by: =C5=81ukasz Wrochna <l.wrochna@samsung.com>
> Signed-off-by: Artur =C5=9Awigo=C5=84 <a.swigon@partner.samsung.com>
> ---
>  fs/orangefs/namei.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/orangefs/namei.c b/fs/orangefs/namei.c
> index 1dd710e5f376..3e7cf3d0a494 100644
> --- a/fs/orangefs/namei.c
> +++ b/fs/orangefs/namei.c
> @@ -224,7 +224,7 @@ static int orangefs_symlink(struct inode *dir,
>         struct orangefs_object_kref ref;
>         struct inode *inode;
>         struct iattr iattr;
> -       int mode =3D 755;
> +       int mode =3D 0755;
>         int ret;
>
>         gossip_debug(GOSSIP_NAME_DEBUG, "%s: called\n", __func__);
> --
> 2.17.1
>