Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190830003022.GA152970@LGEARND20B15> <20190830003356.GW5354@magnolia>
In-Reply-To: <20190830003356.GW5354@magnolia>
From:   Austin Kim <austindh.kim@gmail.com>
Date:   Fri, 30 Aug 2019 10:37:58 +0900
Message-ID: <CADLLry5Z1ex_FCnBj4_kX=FTRkVY9ykKR5u3bpL5Z30zMHVdyQ@mail.gmail.com>
Subject: Re: [PATCH] xfs: Use WARN_ON_ONCE rather than BUG for bailout mount-operation
To:     "Darrick J. Wong" <darrick.wong@oracle.com>
Cc:     linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2019=EB=85=84 8=EC=9B=94 30=EC=9D=BC (=EA=B8=88) =EC=98=A4=EC=A0=84 9:33, D=
arrick J. Wong <darrick.wong@oracle.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=
=B1:
>
> On Fri, Aug 30, 2019 at 09:30:22AM +0900, Austin Kim wrote:
> > If the CONFIG_BUG is enabled, BUG is executed and then system is crashe=
d.
> > However, the bailout for mount is no longer proceeding.
> >
> > For this reason, using WARN_ON_ONCE rather than BUG can prevent this si=
tuation.
> >
> > Signed-off-by: Austin Kim <austindh.kim@gmail.com>
> > ---
> >  fs/xfs/xfs_mount.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c
> > index 322da69..c0d0b72 100644
> > --- a/fs/xfs/xfs_mount.c
> > +++ b/fs/xfs/xfs_mount.c
> > @@ -213,8 +213,7 @@ xfs_initialize_perag(
> >                       goto out_hash_destroy;
> >
> >               spin_lock(&mp->m_perag_lock);
> > -             if (radix_tree_insert(&mp->m_perag_tree, index, pag)) {
> > -                     BUG();
> > +             if (WARN_ON_ONCE(radix_tree_insert(&mp->m_perag_tree, ind=
ex, pag))) {
>
> Er... please wrap the line at 80 columns.

Oh..
Let me resend patch soon after wrapping 80 column lines.

>
> --D
>
> >                       spin_unlock(&mp->m_perag_lock);
> >                       radix_tree_preload_end();
> >                       error =3D -EEXIST;
> > --
> > 2.6.2
> >