Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp259110ybl; Thu, 29 Aug 2019 22:38:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqwACxM2Zs3Wt6dGVdAL6wbYaI1tGqtxAnB8zee/Pwg8BcT1lKQ9nR7owpcALelEb1nahVfn X-Received: by 2002:a17:90a:cc0e:: with SMTP id b14mr13494801pju.126.1567143507996; Thu, 29 Aug 2019 22:38:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567143507; cv=none; d=google.com; s=arc-20160816; b=0m7LuZZIuXdEMRkUtZHXm9u5pV7n+Y1+0tSBjNLXszju73ZXZE9FknTAc0CX1w52js KU8rCPZBT+VRJ2DHmK6TAvogWNbw1yNbsNHrYVDhjjn7dliCk8BSkIzG7wcpNk4A13Yh DHk6s7kWPFt6VmnVGnGegdxjCIB1HNXJweWEmouqGooslpt02sOIDEOeYK0tr422pk/g f/Mc2gB5yHXyNBSq8ut1u5ytlCZ7cVTJ2jcOTR3qJ8j11be9AXK6I4I+Bcff3IqdnflW wsuuKDgMRbWJ8eTvktVIZ/7zvpd05gMy3RycSkSwvCfkBq3icJ4hMx2m8le3g1a757D2 M8VQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=6A5D5n4as+RLhjD7IzB/hCU5xfcTxaIxONW3roni/AM=; b=LBw6B+9hsQZEoZM3c3wKkvYGNR1AAMzAx9l8eQRiqG2yoltSaS5EGRcrBge4sFWFag dDVu7h7MbF1auU5suyfoVGuvdJb5di9NnJSjEYvlpWcS+yTqa5rY3zTz6+5SgxWSXBDL 2DyLKHDOUQJsOZbOcD3ekBbOtaQzmP+IkfRmfrdXdADqOO9cLqQKHzv0BHrxzVL3QCtG DES4eOf2BPKB6mu1+RJNnYR3rsOlCLk3bM43YjZXRN3Oxg7FFg6dLZeDtkfOz+1kt876 Q0fluF7LLdx1KerzOahD7Mp/QaotohjrTG7k5OEbT3ZMICv50wQl5uVRmdfECBNAp7eJ FZ/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Gjfe8Gqa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t143si3677762pgb.542.2019.08.29.22.38.12; Thu, 29 Aug 2019 22:38:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Gjfe8Gqa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727854AbfH3FhV (ORCPT + 99 others); Fri, 30 Aug 2019 01:37:21 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:50848 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725901AbfH3FhV (ORCPT ); Fri, 30 Aug 2019 01:37:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=6A5D5n4as+RLhjD7IzB/hCU5xfcTxaIxONW3roni/AM=; b=Gjfe8GqaEkVPz04gWrDJ17jK3 BpT3gPt7e1zml7cMPX+mdmSfmBBF0Nt8s3bGaXpywhokh5e+9pj+WEfr87hUayOMKEalf+cNgBioj yFRAdMxs6CMQQk/q9ufLMhfvM+ZB0kSMsALRJMcvYgMxfyizMMCofbGeqzby8Cb/xXOstEy1m2X0m O3ACm7cp2hPKA8w0syL1zyftDgVYWJE/bPSq/tOxJhbV7Cr8w8d+lvcOgGVFv926J7ft0IXEC5bQq kUl4f6xYSJ8vIWAA0AiVI3ypC/RhI3aZ9Wy0XH/O4K4Ytsvu6tAXUT8leIIRE5KgWTOMYt8sKDV4m JDVn8TPeQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1i3Zb6-0007Oq-Fr; Fri, 30 Aug 2019 05:37:20 +0000 Date: Thu, 29 Aug 2019 22:37:20 -0700 From: Christoph Hellwig To: Denis Efremov Cc: linux-kernel@vger.kernel.org, "Darrick J. Wong" , Joe Perches , Andrew Morton , linux-xfs@vger.kernel.org Subject: Re: [PATCH v3 07/11] xfs: remove unlikely() from WARN_ON() condition Message-ID: <20190830053720.GI6077@infradead.org> References: <20190829165025.15750-1-efremov@linux.com> <20190829165025.15750-7-efremov@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190829165025.15750-7-efremov@linux.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 29, 2019 at 07:50:21PM +0300, Denis Efremov wrote: > "unlikely(WARN_ON(x))" is excessive. WARN_ON() already uses unlikely() > internally. Looks good, Reviewed-by: Christoph Hellwig