Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp290114ybl; Thu, 29 Aug 2019 23:12:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqzD3Q/X7VzN11mn8htxZOXRvnrUV2Qyh//l+HFq9uLJilKLckYI+P+0QnQHAkA8AFjXSutg X-Received: by 2002:a17:90a:8906:: with SMTP id u6mr14472076pjn.70.1567145569506; Thu, 29 Aug 2019 23:12:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567145569; cv=none; d=google.com; s=arc-20160816; b=CH0bhkicI6m+qa/u8ExqkM1lu++fFquPYMUvX9icXn0lUwDmh9N1RJD5rw3gAk/ds1 9cqDTNBPl8r7Fc+vz6pVE5qriKIL3M91Xkt/mfKQsQz4g+PbO4C0tNgvQwWf4hIuKN60 Eic4RyWkp/opzco3EClZtIsOLKXJG5BHbtbO9u/rMHnqGSyRCEFFIiEh0TpAv2b9ikP1 MtcWMuZjZWbvjiC3WyzRZjOKJS/atR9eq86WSo4FXkvNN1rHrcuwAie7pY6hyGD3cQGS 1Po8XeQk6MXSpmrpTq2fXbGWpivgfPXS7uwhq0d4Eavi77QdVC3sqs5AzSs5n269aFTf OXaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=GZKoQRiLMdpo4wcCu9tES84Ru05vfhtO03sXOvbzSpM=; b=HHc99Nw3SUa2g3psYsJMs7kL33a/Xv/TCRUAzeDm2lh9VoGBevdUzUTecbsBYhu4tA VcfP80o2gio4YnNgRUaDqUEiex3eRQWgKQp6zF2g68cNyHSZyhpE+5Ug7+pC4lOpv03J rnBCS4X4bIeenJPL9CEED2UPnyvwjbY99a1wDmYxCmlZ+6YkcRLxSDxHAYUgeUoE9Lpc 872BO6OZkyRg8iHRdT06oLv144kxjTcOZQSiuGHHwOfC7O9DHA9Do8sCM5iuCIYM8frI EcMTZ5iL5ml6UbjPP7HIkKppg/rA4yx0DHshStnXULiW9Oxerg1nGD34QhdZ21GslEzA LIcQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y8si64723pfq.15.2019.08.29.23.12.34; Thu, 29 Aug 2019 23:12:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727836AbfH3GLW (ORCPT + 99 others); Fri, 30 Aug 2019 02:11:22 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:57158 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727783AbfH3GLW (ORCPT ); Fri, 30 Aug 2019 02:11:22 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 243BDC970D4FE45035EC; Fri, 30 Aug 2019 14:11:18 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 30 Aug 2019 14:11:11 +0800 Subject: Re: [PATCH v3 2/7] erofs: some macros are much more readable as a function To: Gao Xiang , Dan Carpenter , Christoph Hellwig , "Joe Perches" , Greg Kroah-Hartman , CC: LKML , , "Chao Yu" , Miao Xie , , Fang Wei References: <20190830032006.GA20217@architecture4> <20190830033643.51019-1-gaoxiang25@huawei.com> <20190830033643.51019-2-gaoxiang25@huawei.com> From: Chao Yu Message-ID: <4904b5a1-8e10-7c43-6be1-6191958c021d@huawei.com> Date: Fri, 30 Aug 2019 14:11:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190830033643.51019-2-gaoxiang25@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/8/30 11:36, Gao Xiang wrote: > As Christoph suggested [1], these marcos are much > more readable as a function. > > [1] https://lore.kernel.org/r/20190829095954.GB20598@infradead.org/ > Reported-by: Christoph Hellwig > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,