Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Robert Richter <rrichter@marvell.com>
To:     Borislav Petkov <bp@alien8.de>
CC:     James Morse <james.morse@arm.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 13/24] EDAC, ghes: Add support for legacy API counters
Thread-Topic: [PATCH v2 13/24] EDAC, ghes: Add support for legacy API counters
Thread-Index: AQHVXxY/k/O/m3ZuPEe2DEuUofytfw==
Date:   Fri, 30 Aug 2019 09:35:23 +0000
Message-ID: <20190830093515.wrvoszz73aovl7tk@rric.localdomain>
References: <20190624150758.6695-1-rrichter@marvell.com>
 <20190624150758.6695-14-rrichter@marvell.com>
 <20190816095559.GL18980@zn.tnic>
In-Reply-To: <20190816095559.GL18980@zn.tnic>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [31.208.96.227]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0c016180-f99d-4dc2-1657-08d72d2d619c
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:MN2PR18MB3181;
x-ms-traffictypediagnostic: MN2PR18MB3181:
x-ms-exchange-purlcount: 1
x-microsoft-antispam-prvs: <MN2PR18MB318188133ED7291CA0A8B64FD9BD0@MN2PR18MB3181.namprd18.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 0145758B1D
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(396003)(136003)(39850400004)(346002)(366004)(376002)(199004)(189003)(54906003)(66556008)(14454004)(316002)(6512007)(66476007)(64756008)(66946007)(6306002)(6246003)(9686003)(6486002)(71200400001)(26005)(4326008)(6916009)(11346002)(486006)(6116002)(66446008)(446003)(6436002)(66066001)(102836004)(476003)(229853002)(53546011)(6506007)(386003)(81156014)(5660300002)(8676002)(81166006)(966005)(14444005)(8936002)(3846002)(71190400001)(25786009)(52116002)(1076003)(256004)(2906002)(305945005)(186003)(7736002)(53936002)(86362001)(478600001)(99286004)(76176011);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR18MB3181;H:MN2PR18MB3408.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: Dft6qAze9V7GeQm6ftbAQ+9a4a8ppN539vnCuK4uwHo3oQdo9CBGy/twvQ0TQt5kjjofq88L1PM+GmS5w3kmMNT/TkZgiIMTsAPYV7i7RF1dwf1rjWt3UL05ptFxNu34XVW+VWmR6dbN5jbH32nHLSXDBhTCSteTtUZ5Psm1UxsR8If4j+ANIVh2n3wwnBtjS/WjucBwVFKBnew9BHoFe1GhIfm1WKMnq7HfC5S7p8DDqEqTuCAq6ik+gQ98DcVLarGIlcWn++Zag9+zZF5ElkrVJ1lQrKGFokmczRU4CbN+eoklqQpw1WdErj1mAiiPPnzQPtsyT77LhodrcFpxLejQ9PcWOIDje/NTILQU9QIpIc3/HfKXVpJhCuWEPP4ZBiY0Bpe1/GvEcUDJOf6vFMw8h1RVnkklMurKeFdO0dI=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <ED7B691DD4B8D347BDB6071EE202A956@namprd18.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c016180-f99d-4dc2-1657-08d72d2d619c
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2019 09:35:23.3850
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5xr1vuAWeMOxI/Isq3Ayke7fbannyOx0t8AbzChyDuH+j4QYFQN1DjGVnaz4BN3lRlf4vvWU2RDPuGQWogqonA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3181
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8
 definitions=2019-08-30_04:2019-08-29,2019-08-30 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 16.08.19 11:55:59, Borislav Petkov wrote:
> On Mon, Jun 24, 2019 at 03:09:22PM +0000, Robert Richter wrote:
> > The ghes driver is not able yet to count legacy API counters in sysfs,
> > e.g.:
> >=20
> >  /sys/devices/system/edac/mc/mc0/csrow2/ce_count
> >  /sys/devices/system/edac/mc/mc0/csrow2/ch0_ce_count
> >  /sys/devices/system/edac/mc/mc0/csrow2/ch1_ce_count
> >=20
> > Make counting csrows/channels generic so that the ghes driver can use
> > it too.
>=20
> What for?

Same was asked here:

 https://lore.kernel.org/patchwork/patch/1080277/

Actually it is a fix for the counters exposed by the legacy API for
the ghes driver. Counters are broken (set to zero). The ghes driver is
the only where errors are reported using edac_raw_mc_handle_error()
instead of edac_mc_handle_error().  The fix is to move the error
counting to edac_mc_handle_error() where the other counters are
incremented.

All distributions that I have checked enable the legacy API option
(CONFIG_EDAC_LEGACY_SYSFS=3Dy) and the interface cannot be disabled for
individual drivers. As long as the counters are exposed, their values
should be correct. See all options discussed in the thread from v1.

> ghes_edac enumerates the DIMMs from SMBIOS - it doesn't need chip
> selects and ranks. Those are used when you can't count the DIMMs
> properly...

Right, but that is true also for other drivers (actually all other
drivers since DIMMs are used now). It is to support older tools that
deal with */csrow*/ch* instead of */dimm* in sysfs.

-Robert