Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp641479ybl; Fri, 30 Aug 2019 05:09:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqwn2PjXk15kd5GjrMqCCp1bc3wYpbCGx563U17u1eYmCVofU9T1DE5ayMXbkUnX1Fwmz2ak X-Received: by 2002:a17:90a:2e86:: with SMTP id r6mr15124900pjd.67.1567166940748; Fri, 30 Aug 2019 05:09:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567166940; cv=none; d=google.com; s=arc-20160816; b=iND6OPX7CGPA7UXcB6iQ1cbRH+bhE4OGmb5PPAEV9C1FTK5eCp2ptVpPa5z1AR8TwY gmI6Fal/fRXNXUlJR3L1DD8QQQXaYajF9Kco8ob95/oFK+EiJ9U8kJxtV39rl8QrO9wF XYn898kmIhPg1TRIda4fzv49csf7k0ifZ6PV7hjz2z/5UNyAl/WbYJmxy6VNpfkxKcaA 9sd3gBwEXlRVLgCoRCACf9S4JHudU8kP3/UCps1j+cvtgVh2qdhj+byoijfJIXvpJX4/ 6mSZ9Fh5OobbWB8Qx5VNZ+fMtoCP3PLqJeRhX6AR6fM7x4EwIVL8VMqRBkCwF3bzK9e2 UWBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=hGegLswRsXDMS7Mt0Mf9JkYB6NpI8ypuxStTJrsPGuE=; b=0PNB7h+RmfMs+qonwE6Z1lwEJJy1bUvHC4r6hfhk+CwkLl8M0vuySPJ2QkYzUodzyz ju0Ir4z2291juveNvtCbOcYFzEsCpFJwk/zdmWvQBhUfmJU3Y+GPn26JI/PmnctJSYiu JDsG2lyqo7VTVnQhLdajSh/hbP7PBBO2xg5Pnq2B9JSr1uwMOFLj5RqGX2MjOjReEU3g AIiInPmVQ8Jx6KIRX8OW63gM5har9u8apbjXUy6VknGNIjHeNzwA+Zi3NHEz6Mf4Aigz 39fbYwRl55kDuV3uyVj4efb+PatAl7yBF2q0VqTlXWXyLFzkKwkSxN8f/fdZo+nPWOG+ /O8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@aol.com header.s=a2048 header.b=XPYhccin; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=aol.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y7si4454944plr.408.2019.08.30.05.08.44; Fri, 30 Aug 2019 05:09:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@aol.com header.s=a2048 header.b=XPYhccin; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=aol.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727792AbfH3MGU (ORCPT + 99 others); Fri, 30 Aug 2019 08:06:20 -0400 Received: from sonic303-24.consmr.mail.gq1.yahoo.com ([98.137.64.205]:45252 "EHLO sonic303-24.consmr.mail.gq1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727525AbfH3MGT (ORCPT ); Fri, 30 Aug 2019 08:06:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1567166778; bh=hGegLswRsXDMS7Mt0Mf9JkYB6NpI8ypuxStTJrsPGuE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=XPYhccin0vNwy0qHU/AFTWVWWumy4xlu62gU/kiwuUoSqccL/ITAYQfsT9GOtawMrO6JpuewW8xTsbQ0K+IE1P0OK1p3dlFFmA7oBIRozcBGpxAxoweipZ6Hjf0lZIfZwP+B+ZwSd0lyf26Tz1Lb3lIHfIJUEwD6qm8gALrCt6YNkQ5Zw2Hb58z6MIzzzNXNcUUlOl98VnHwRgFWAltTinKnARKy0UWZg7pYVosX0/k91Ko2F+9/kmbQMOOsH8Qqr95UOzIr2fgy2wwa78Z8MyxHnd321+TudzHx3F8X4iKgj5R7FgRZtXxjI8DeX70HdBMMIQnxr+A9RvPUosm+9g== X-YMail-OSG: n7uX8fwVM1kpk7u0piUdmYrLH_5BBhUDBSNQd97K.Kneq0njub_LkIXQ7gDURbp 1JG5yVYKXHMcVq2P2Pwvr6tfUZ84yLbsUH18ynkMR8x50aXD2KUBVMux3qitqGbXwIfi2vgNFASf HNLNJl7aSQ7bJokzgnWM60lfcWZqjkerLFWKZV0mDfGjZavIR_pQz63xIeDheWxqwkAbUa7vjKAu C_r6zNVenso.eP34gWhvnCtpkeN9scOPp7457MFWsrrE2GEbaImWiHf4CZfev7vkiI6Dflp.wetb 3jHaY2y9C9DgnjRfnZSnfaDEyOkjlrPrlklDeEirfcUAyIxsqNBfYozJmR.._K8bW9KmJtoKzq3N iRoNCI1hVqBIfDuA7PHDFRaM0fITssZURRpvFM1Dq6VpdtIU.RIEs_CraHjun8aSrXeSosCZ7mRi 5Xe8oM1dw9Y571MR6iguM2Q95_D.1VLYZMMM2hNXzybUVolDJH7UtocP8_Ug7aCOseZtOfGJvd6e ADU.KWtv88Ts2OZuVspPL4vrBvHmywXBogxA81GLyEq8iIlaaICpdcrfC46xpfnXCNl85md5pG7z V4ln6zDzYSe5SgNBCoAOdyqZcPMZ6ja2pCq7T1xQzDefnZofKx1rk3mY1P1KwSlXFlClalTDzqNy S7g33ExlvnR0NbsuMD5Tjv4YhwC8b4lUJ77okhXGWJ4iZC5kUeVy9Bui_65NJANxpb4ZjYNJspx2 _H9MbxdCtkse1hfCSIFwtq.qVEPXmFpPx04uYOy7piWiZMLRSV_zWEktduCp.HftEgVKZFpX_F.W GPl4d2YVsE3G1z6iP.2_9y8bgEnN34qQ9qlJs17NWNoEq28eU5noISOv1lUXeWgCDk8LpaZrGLzV 0KU4R7w8Z02F3df7egyCvIZVnmu.V8huCRkrplLgwByuvHs9_zPKbgueNcqNVLdj7HzWajD1E7hY gp2NVF9pmrxaAypliSgt0rSAnOVbGYw7_WYpbOnf9eLafigu3JmfTPuwwxi0rgZNmZ8W9HQN2Z40 n4EB7ykmOkVq03fvjIYIas4L5hbYZZBT8GBrEmVkKDwGdNxY72ZhAJTpaeHbsp90JIFk2eoH8rON Tt3N0jpnWgfshM2qavDU44SU3u35In3DF5lTsYrashl0SjStUN9Bquw3rJHYgLB.mCDfu4zh6J9l jxBdV1es6ULUQVLDVP2WxfQNgnVV9Bbs0I1jmtoNUol58WyFAV8zG5a5EtGNJECL49RFtEXwB0R2 a1Pgqh833px_HmEH195a41YfEZZg9dzAB5AE- Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.gq1.yahoo.com with HTTP; Fri, 30 Aug 2019 12:06:18 +0000 Received: by smtp408.mail.gq1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 27fd797655cd7ababf61147ca3d721bf; Fri, 30 Aug 2019 12:06:14 +0000 (UTC) Date: Fri, 30 Aug 2019 20:06:05 +0800 From: Gao Xiang To: Dan Carpenter Cc: Gao Xiang , devel@driverdev.osuosl.org, Chao Yu , Greg Kroah-Hartman , Miao Xie , Chao Yu , LKML , Christoph Hellwig , weidu.du@huawei.com, Fang Wei , Joe Perches , linux-erofs@lists.ozlabs.org Subject: Re: [PATCH v3 6/7] erofs: remove all likely/unlikely annotations Message-ID: <20190830120601.GC10981@hsiangkao-HP-ZHAN-66-Pro-G1> References: <20190830032006.GA20217@architecture4> <20190830033643.51019-1-gaoxiang25@huawei.com> <20190830033643.51019-6-gaoxiang25@huawei.com> <20190830113047.GG8372@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190830113047.GG8372@kadam> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dan, On Fri, Aug 30, 2019 at 02:30:47PM +0300, Dan Carpenter wrote: > On Fri, Aug 30, 2019 at 11:36:42AM +0800, Gao Xiang wrote: > > As Dan Carpenter suggested [1], I have to remove > > all erofs likely/unlikely annotations. > > > > [1] https://lore.kernel.org/linux-fsdevel/20190829154346.GK23584@kadam/ > > Reported-by: Dan Carpenter > > Signed-off-by: Gao Xiang > > --- > > Thanks! > > This is a nice readability improvement and I'm so sure it won't impact > benchmarking at all. > > Acked-by: Dan Carpenter It seems Greg merged another version... I have no idea but thanks for your acked-by :) https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/commit/?h=staging-testing&id=8d8a09b093d7073465c824f74caf315c073d3875 THanks, Gao Xiang > > regards, > dan carpenter >