Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Parav Pandit <parav@mellanox.com>
To:     Cornelia Huck <cohuck@redhat.com>
CC:     "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        Jiri Pirko <jiri@mellanox.com>,
        "kwankhede@nvidia.com" <kwankhede@nvidia.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH v2 2/6] mdev: Make mdev alias unique among all mdevs
Thread-Topic: [PATCH v2 2/6] mdev: Make mdev alias unique among all mdevs
Thread-Index: AQHVXluj2Coi5xiSw0C4zJLLU40uracTo5kAgAAE2sA=
Date:   Fri, 30 Aug 2019 12:59:49 +0000
Message-ID: <AM0PR05MB4866DAABF1711069899FEC67D1BD0@AM0PR05MB4866.eurprd05.prod.outlook.com>
References: <20190826204119.54386-1-parav@mellanox.com>
        <20190829111904.16042-1-parav@mellanox.com>
        <20190829111904.16042-3-parav@mellanox.com>
 <20190830144052.11d23ec3.cohuck@redhat.com>
In-Reply-To: <20190830144052.11d23ec3.cohuck@redhat.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 05224749-e52d-4d01-b76e-08d72d49f0ce
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2019 12:59:49.1876
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nBxe0JYrypFK71JGjdufEPIuSK3uZztKMBTM5tiUR4+ht+mmIqQYVl68Tc1+l5hYrThB2uJP6CL7V2q2G2KZQg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5073
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Cornelia Huck <cohuck@redhat.com>
> Sent: Friday, August 30, 2019 6:11 PM
> To: Parav Pandit <parav@mellanox.com>
> Cc: alex.williamson@redhat.com; Jiri Pirko <jiri@mellanox.com>;
> kwankhede@nvidia.com; davem@davemloft.net; kvm@vger.kernel.org; linux-
> kernel@vger.kernel.org; netdev@vger.kernel.org
> Subject: Re: [PATCH v2 2/6] mdev: Make mdev alias unique among all mdevs
>=20
> On Thu, 29 Aug 2019 06:19:00 -0500
> Parav Pandit <parav@mellanox.com> wrote:
>=20
> > Mdev alias should be unique among all the mdevs, so that when such
> > alias is used by the mdev users to derive other objects, there is no
> > collision in a given system.
> >
> > Signed-off-by: Parav Pandit <parav@mellanox.com>
> >
> > ---
> > Changelog:
> > v1->v2:
> >  - Moved alias NULL check at beginning
> > v0->v1:
> >  - Fixed inclusiong of alias for NULL check
> >  - Added ratelimited debug print for sha1 hash collision error
> > ---
> >  drivers/vfio/mdev/mdev_core.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/vfio/mdev/mdev_core.c
> > b/drivers/vfio/mdev/mdev_core.c index 3bdff0469607..c9bf2ac362b9
> > 100644
> > --- a/drivers/vfio/mdev/mdev_core.c
> > +++ b/drivers/vfio/mdev/mdev_core.c
> > @@ -388,6 +388,13 @@ int mdev_device_create(struct kobject *kobj, struc=
t
> device *dev,
> >  			ret =3D -EEXIST;
> >  			goto mdev_fail;
> >  		}
> > +		if (alias && tmp->alias && strcmp(alias, tmp->alias) =3D=3D 0) {
> > +			mutex_unlock(&mdev_list_lock);
> > +			ret =3D -EEXIST;
> > +			dev_dbg_ratelimited(dev, "Hash collision in alias
> creation for UUID %pUl\n",
> > +					    uuid);
> > +			goto mdev_fail;
> > +		}
> >  	}
> >
> >  	mdev =3D kzalloc(sizeof(*mdev), GFP_KERNEL);
>=20
> Any reason not to merge this into the first patch?
No. It surely can be merged. Its easy to start with smaller patches instead=
 of splitting. :-)
Doing uniqueness comparison was easy to split as independent functionality,=
 so did as 2nd patch.
But either way is ok.