Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp709756ybl; Fri, 30 Aug 2019 06:07:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqwm+VXl21RJ/S1A0WqtUoT6kgli1776FrP+TSmzRTWSQF+HiKwYVwSHGiHB1+awoLVAK/lL X-Received: by 2002:a63:20d:: with SMTP id 13mr13203330pgc.253.1567170449801; Fri, 30 Aug 2019 06:07:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567170449; cv=none; d=google.com; s=arc-20160816; b=FXrFMzasTo6eT7Vd8hTnzyyByWyiJRqcax1TFhYRF7o+BiTMV5eNwxvUO4MsSTBwHz n9+KJmEupKSR1pMKd2z4Df4j/nwPnqonx/zrybZ283fjVvD5mIe2bUzgbbpepb4MZxG3 KP34dLrHs/XbWqjiwhapgopWxnezVGS9ez6OclapNWr/xA36Z06JPSu6Mw+R50C85vRt ARYcPMlvbXoneYgGEz1Gnw63I3EGflxorOJia8HbOBegTJyFV/9MzL0PZgvM2K4pncig Ul7jA/kmjYH4nfjDFi2Vs8UpO1zN2+ImA1BDH19xr0m18I1I0lnZvP3xqLSYtvE+LRZ0 hhjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=+y/TKjEJAnBPma2bbqzZvYOtDiqFn4DC6nul9hcLUB4=; b=lYIU70nBdvDtJoR2aJa0ltLkmrgdKEZkWut90hmG4M+bAwwKVxTseu//ejsk1ICNjd aL/6pwQEYrIgCYaJMN81V96k8TPcwIHBPqHManuZW8W4/zoqxvZJpehn8XNj1B1AuT0g rS++cUxEDdUDRm7T0jLoMpcSvfrrTng9O40FL266jFYVdZajI7nIyx5BpmyYwgJGFIZH VuIvHiA6MI6gSXVgWPlvmFG/tXFtIVEvs5CK93Fk5J9ikq9/T69D7hVAzIGoJBRSOxTX GHhwF4UnI39OdG/6q8FUCAnorc6bQHKo4iJVAc+aWO6VqFTIsV9YlxQgB021/g+PCXCw 5+rw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u17si4336876pgg.204.2019.08.30.06.07.13; Fri, 30 Aug 2019 06:07:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727883AbfH3NGO (ORCPT + 99 others); Fri, 30 Aug 2019 09:06:14 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:50185 "EHLO relay11.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727135AbfH3NGN (ORCPT ); Fri, 30 Aug 2019 09:06:13 -0400 Received: from localhost (aclermont-ferrand-651-1-259-53.w86-207.abo.wanadoo.fr [86.207.98.53]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id AEF02100004; Fri, 30 Aug 2019 13:06:10 +0000 (UTC) Date: Fri, 30 Aug 2019 15:06:03 +0200 From: Alexandre Belloni To: Wolfram Sang Cc: Wolfram Sang , linux-i2c@vger.kernel.org, Chanwoo Choi , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Alessandro Zummo , linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH 1/2] rtc: max77686: convert to devm_i2c_new_dummy_device() Message-ID: <20190830130603.GQ21922@piout.net> References: <20190820154239.8230-1-wsa+renesas@sang-engineering.com> <20190820154239.8230-2-wsa+renesas@sang-engineering.com> <20190829205752.GL21922@piout.net> <20190830124554.GB2870@ninjato> <20190830125338.GP21922@piout.net> <20190830130035.GF2870@ninjato> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190830130035.GF2870@ninjato> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/08/2019 15:00:35+0200, Wolfram Sang wrote: > > > > > I'm confused because I already applied: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?h=rtc-next&id=7150710f3084de8d35ce3221eeae2caee8813f92 > > > > > > The above was a mass conversion to i2c_new_dummy_device() to make sure > > > all in-kernel users use the API returning an ERRPTR. Mass conversion to > > > the devm_ variant of the same function was too troublesome. > > > > > > With another series, I wanted to remove superfluous error checking of > > > i2c_unregister_device() because it is NULL-ptr safe, like here: > > > > > > > > - if (info->rtc) > > > > > - i2c_unregister_device(info->rtc); > > > > > > But for these two RTC drivers, I figured moving to devm_* is way easier > > > than fixing up the mass conversion result from coccinelle. > > > > > > > Ok so should I drop the previous patches and apply those instead? > > Nope, they should be incremental, aren't they? > No, your patches don't apply on top of rtc-next -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com