Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp754001ybl; Fri, 30 Aug 2019 06:44:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqy3vRYARwnFBsnTNQgvRKMsLE/YBOHVR7wq6YcNFiH/c84ufndHYWNmkYEylpouedGU6e1O X-Received: by 2002:a17:902:566:: with SMTP id 93mr16015113plf.172.1567172663474; Fri, 30 Aug 2019 06:44:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567172663; cv=none; d=google.com; s=arc-20160816; b=St7L1tRHduVJsMBJUHV7LeuiZw2KloTVEZELUAzUqIZQUtTyDX9jWUB2bq0p/x1qmA +9sp/+BZUqV0VtzeGFs/gM9TTq3qn755JZHqMHOZOQOX64dJkawvVL5QaAGaQmN+jtuR kF/eHKhBE/dpZUmdf3vGzUpFyKDFbvtJA5vOusBBj0lQdd6RosQtM0fP2h7UJTFxM7vj VRuTckQYwNU1id2RE73U13FdMCcFmtQi3A9wugZqMH2xtBSJioFviEc1RyPW5h9Goow8 BQDOZ2xXt9pSIh+NLULVHOrGNRCz1BFKFtjGqsRRmjmJNfSlYg4j2+0wv1UYJbD/I3PI +Lrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=zYGH3fN4v8plY5qOryvWCm0ZkkSEcqIXPLFE0LXF1xM=; b=P+xMR/K8vW8obc7Dvk+mryyWEvJkdZwcx3/RrcHeQzKNZOSr4klCqulDsRTiMQ52e4 DmDX/9UqeqfGFv6heOtWAJVNsULA/b/ITS3+xlRczCM7VGIsd3RREYfKI2wdwocGb3KN 7WnTnqtcfaHQk7irdIzbiCNOcPnYW0olLIfNRlt720VQggqwejA6HvvJoUf4XIBGKRs1 weDWMVyvxVMveLOU3JNj0mGbAZnZSVpfmdU5LNAbHzru1Fvr8uG3hZlEdNWGmalYS3DC c5KIq+nHsy4PWZPbxFbNJVkUwktY/3t8Q8enJcG1pt+K6W1ZN2G1Am5wL5lQROWQtfaH E9Zw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=S4xlxo1M; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s3si4492376pgq.392.2019.08.30.06.44.07; Fri, 30 Aug 2019 06:44:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=S4xlxo1M; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727850AbfH3NnT (ORCPT + 99 others); Fri, 30 Aug 2019 09:43:19 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:36806 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727751AbfH3NnS (ORCPT ); Fri, 30 Aug 2019 09:43:18 -0400 Received: by mail-io1-f68.google.com with SMTP id o9so14069051iom.3 for ; Fri, 30 Aug 2019 06:43:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zYGH3fN4v8plY5qOryvWCm0ZkkSEcqIXPLFE0LXF1xM=; b=S4xlxo1McUe3ODbG6lFGApEUyreIy3lVJLjs+cn9444a0h0+Rw/NY4ZYuiUhvrjZPo DmB3w8J5vYckaTr6NsZa5XfN94OcZxbrVgulnZbOWhB6mRLpe4+kLyv43tswN/kHk4GG 9UHMiIN5cFXivXPg3y9OVT9Tg1EsF/bMJHpgPMOgiv6k4nDTt2wvthKF6hoO3GMwReXK fIQpZ2YrA/op7HljEdDrnfM3cap4cNptn4aIL7Tiiue5UgTXJiAZOyYcBEvGwX4MJfyC kYCa9ot7vwFWEc/WqwgS2OomWM/Ed1tsIkDvT7jB8a7sXwHTnKsiDO4uIU9ToiEeWM30 Hlww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zYGH3fN4v8plY5qOryvWCm0ZkkSEcqIXPLFE0LXF1xM=; b=UnGrmdalhPoMXGr55PgeudHvB0dqafSWzHnERfdyAZTCx6s0kf/qCdxGtEK/ymzw6p YBZdF1/9jmTtQm+QqUXKB7VnyQQq7RkhDELc2SfZXN0L2ACtyWVzO+p0lt6hkxhlGewK b0upd7BeYojeroR9rPrNy72hmNR6OYoL+MHSrnZ4t0eUnT4TH9lwAPmX2GFmuWcphEF6 9m2hUUuNJnDXvdanu0mQJeHq8+ubR9E4G1XNqhxGAEeZxPwwvcB7xKcNQC5KuShScS+n IWkCvVRpudSbN7PNDxNThuU+WpBaZVPzy354jOOuRnVqIDcx+F9aeUG0K42RtC3x6831 z+jQ== X-Gm-Message-State: APjAAAUujGe0iUVLvacfoNutXSrZIF7TIqurvkxn2NK3LpaSTk4/i3+k jAtX80HMQo9hewtTZPrQuDzZEA== X-Received: by 2002:a6b:3c0a:: with SMTP id k10mr12501340iob.282.1567172597938; Fri, 30 Aug 2019 06:43:17 -0700 (PDT) Received: from [192.168.1.50] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id o2sm5032889iob.64.2019.08.30.06.43.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Aug 2019 06:43:16 -0700 (PDT) Subject: Re: [PATCH block/for-next] writeback: add tracepoints for cgroup foreign writebacks To: Tejun Heo Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara References: <20190829224701.GX2263813@devbig004.ftw2.facebook.com> From: Jens Axboe Message-ID: Date: Fri, 30 Aug 2019 07:43:14 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190829224701.GX2263813@devbig004.ftw2.facebook.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/29/19 4:47 PM, Tejun Heo wrote: > cgroup foreign inode handling has quite a bit of heuristics and > internal states which sometimes makes it difficult to understand > what's going on. Add tracepoints to improve visibility. LGTM, applied. -- Jens Axboe