Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <20190830085646.14740-1-hdanton@sina.com>
References: <20190830085646.14740-1-hdanton@sina.com>
To:     Hillf Danton <hdanton@sina.com>
Cc:     dhowells@redhat.com, Sachin Sant <sachinp@linux.vnet.ibm.com>,
        linuxppc-dev@ozlabs.org, keyrings@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: Oops (request_key_auth_describe) while running cve-2016-7042 from LTP
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4383.1567174383.1@warthog.procyon.org.uk>
Date:   Fri, 30 Aug 2019 15:13:03 +0100
Message-ID: <4384.1567174383@warthog.procyon.org.uk>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hillf Danton <hdanton@sina.com> wrote:

> -	struct request_key_auth *rka = dereference_key_rcu(key);
> +	struct request_key_auth *rka;
> +
> +	rcu_read_lock();
> +	rka = dereference_key_rcu(key);

This shouldn't help as the caller, proc_keys_show(), is holding the RCU read
lock across the call.  The end of the function reads:

		if (key->type->describe)
			key->type->describe(key, m);
		seq_putc(m, '\n');

		rcu_read_unlock();
		return 0;
	}

and the documentation says "This method will be called with the RCU read lock
held".

I suspect the actual bugfix is this bit:

> +	if (!rka)
> +		goto out;

David