Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp904417ybl; Fri, 30 Aug 2019 08:49:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqx/64gD7hJRCvmeVkDYpDeiwHzPUa3fU1cGtK9LPXyW6NqEgoDTT3W6mncvHkCDRTqszykX X-Received: by 2002:a17:902:343:: with SMTP id 61mr17120366pld.215.1567180162436; Fri, 30 Aug 2019 08:49:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567180162; cv=none; d=google.com; s=arc-20160816; b=gTiGEWBj/zMfvvfpv4fyLs1n+yqSbpGWHZ9w2+3IluxD5+dxPgz1v/+3JkLQM3XKxN GquxBH0lhb5dbzlSkZXB3HbV6oWrQaAxPdZ1Kk5/XMnvIx68ROefZ/UK4avwOqutI2/J P6Xrryn/0Aaj+Tf4yovSx3AYllzPxs6vA32G8ck8VMJfYRJoMVGdfJP1D3kuDCe8+9Y7 e6rUllK8he5hTUwxPnHaijUSDkufc3FTkyOXiFnQVRdaRjD8naRufgp2oM7iWsEoNuPj q80XlnHtlOXvtserifHxyaIkiLj/HPLdvvw6T7KMeDdo1eELANG/BSwBk6z5Ztb0dF2b kKMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=VI0bXCVY8P10H0YT3Rjq7E9GvaiLma/bGh4rBPUdQKg=; b=wV3GtmTQunfSruWBZnIbIZKq328nu6119chNycr9cbd+Zqy/BDL8dN/VDtMaDGe+Pm BVCD5BHIDsVS+LkNkw65iruO1x2nlNh3EytnIWoWBQw9LzMcMq6qH5w9KyTNCAGuPsz8 WzazxT09QCbE2ja3WuVUQvoHTCxNtVcuwJ0Cmk7q0kAKPIpEzbd0V3/7utk51Trtg5TU /WFz5ZXu0HyUmWygz4GYaytY+9jZIaivKqvtRuCbwTIoYufH/JWCpKPiiJsaEKZdwu8L WhlbOGtl5oUHPrESGW9GESIjitLnTlUBMAzeXuwqfNyvN9aJXhqfuj4yqq9fkim364i0 fmQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=UNxWJcbn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z186si4712130pgd.162.2019.08.30.08.49.07; Fri, 30 Aug 2019 08:49:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=UNxWJcbn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728282AbfH3Pq4 (ORCPT + 99 others); Fri, 30 Aug 2019 11:46:56 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:40094 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727820AbfH3Pqz (ORCPT ); Fri, 30 Aug 2019 11:46:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=VI0bXCVY8P10H0YT3Rjq7E9GvaiLma/bGh4rBPUdQKg=; b=UNxWJcbn1PB9qyM05AHzrOjp5 5OskrUVMmr8E657vBPDa4nkoWpXwS48U5vGj4wCTVjhSjPsYF9oRgdHtWUmvFMhrCJAYi/vj/FF0A eqtZ6wSH1lfvGv1GPkgsPpPIerkGgc7t5x48gBu1tOfBVOwSYvcK0/+EU/sPIZC46P/wLirq4zdqU XfhYtWeTiF4DB0ggGTGH8aPlSjIycvvzNj0plwZ/TqjzP75Kh270DOEmNsNXfzL6jiP1W4xRkNnM5 QTf5A+zcHpKdOVTuqhQsqOUXWgmr7Sb/YmJMUEZy2PoFRAneQ98gZ5p6Kk+TNiIOqEihoP7TgLOWt aI3ChGSWA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1i3j6w-0005vs-1C; Fri, 30 Aug 2019 15:46:50 +0000 Date: Fri, 30 Aug 2019 08:46:50 -0700 From: Christoph Hellwig To: Gao Xiang Cc: Chao Yu , Dan Carpenter , Christoph Hellwig , Joe Perches , Greg Kroah-Hartman , devel@driverdev.osuosl.org, LKML , linux-erofs@lists.ozlabs.org, Chao Yu , Miao Xie , weidu.du@huawei.com, Fang Wei Subject: Re: [PATCH v3 6/7] erofs: remove all likely/unlikely annotations Message-ID: <20190830154650.GB11571@infradead.org> References: <20190830032006.GA20217@architecture4> <20190830033643.51019-1-gaoxiang25@huawei.com> <20190830033643.51019-6-gaoxiang25@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190830033643.51019-6-gaoxiang25@huawei.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 30, 2019 at 11:36:42AM +0800, Gao Xiang wrote: > As Dan Carpenter suggested [1], I have to remove > all erofs likely/unlikely annotations. Do you have to remove all of them, or just those where you don't have a particularly good reason why you think in this particular case they might actually matter?