Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp958028ybl; Fri, 30 Aug 2019 09:34:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqzRXBhYRasNUFxhA/pfFpFhereiFzosOnVmKN9msWcFgrvRyQ8+l9KCAYopIkAGW4n3BgS/ X-Received: by 2002:a17:902:1126:: with SMTP id d35mr16682649pla.330.1567182845474; Fri, 30 Aug 2019 09:34:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567182845; cv=none; d=google.com; s=arc-20160816; b=y+z5gJiDzX9npNoEsxfpE/v8bDlDc2YFffgdv1s37VRy5HPEEAeRiRFxk//5mf145R 3Rh5Ia8iyFJz7vHOiKWEcufSKvPMOxqmTDftWQiIjzLlVSCvWhdJgP8O8m/G0nn1MOXk l6g4qqaVbepzcxEF0KNmhmpl1yDc5s2Ex+0QIJnrfvRQxpmm6KbL4QT19aYo8/TfbRIP LnEf5sYRvXT+3lmPUK8H1YGsF0yNBRdK4sfiQrLOUlUc61JgeSMMZ3aP6c3Zm2XcK+Gs RdILxwH6BDxr0NPk1Q9AzRnH2wEuiPhxoFv1dhNlhoNZmX2Bx6W7A3Vi4QDDvsknLkVF FN5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization; bh=uh3JJimJBA/C9fA1Cm3KPB6nnvS5TSCOLi7lccTGRfE=; b=HO0nJvwUfU43443sGYk6q4UmvD99iA1YCOc+Wb7STRT77ejtKSkCJBQ7OpoG2VNwDa 9E/PeNBtSD+I4Sp/yb8DfFT07CSrpWVm7BBGsAnkpNGtDkzOo8cfWtCQZnzSjUJSJjHm CHUDd+u59MgDml4NJmMTpPea208WqXqIynBNmGuc3ajEZFsJrgh2Omi6ehv+yUnHG/De sIV7Wcw98ZkRFSBDczqZ5EbYcYemPpXFrhfS3xB+BVwR+AIunsOlQLahzGTz8OCXWL6s L/4lr5dpCK7XJocCuNRsAex3Qoz7+dbdj9ISL1IprQMP7Gzg29AvvFFu2zJEgy1S3TiW 1q6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 15si4648175pgy.517.2019.08.30.09.33.50; Fri, 30 Aug 2019 09:34:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728120AbfH3QdC (ORCPT + 99 others); Fri, 30 Aug 2019 12:33:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19665 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727792AbfH3QdB (ORCPT ); Fri, 30 Aug 2019 12:33:01 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 485CC3001839; Fri, 30 Aug 2019 16:33:01 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-255.rdu2.redhat.com [10.10.120.255]) by smtp.corp.redhat.com (Postfix) with ESMTP id D562160BF7; Fri, 30 Aug 2019 16:32:58 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20190820001805.241928-24-matthewgarrett@google.com> References: <20190820001805.241928-24-matthewgarrett@google.com> <20190820001805.241928-1-matthewgarrett@google.com> To: Matthew Garrett Cc: dhowells@redhat.com, jmorris@namei.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Alexei Starovoitov , Matthew Garrett , Kees Cook , netdev@vger.kernel.org, Chun-Yi Lee , Daniel Borkmann Subject: Re: [PATCH V40 23/29] bpf: Restrict bpf when kernel lockdown is in confidentiality mode MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3801.1567182778.1@warthog.procyon.org.uk> Date: Fri, 30 Aug 2019 17:32:58 +0100 Message-ID: <3802.1567182778@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Fri, 30 Aug 2019 16:33:01 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Matthew Garrett wrote: > From: David Howells > > bpf_read() and bpf_read_str() could potentially be abused to (eg) allow > private keys in kernel memory to be leaked. Disable them if the kernel > has been locked down in confidentiality mode. > > Suggested-by: Alexei Starovoitov > Signed-off-by: Matthew Garrett > Reviewed-by: Kees Cook > cc: netdev@vger.kernel.org > cc: Chun-Yi Lee > cc: Alexei Starovoitov > Cc: Daniel Borkmann > Signed-off-by: James Morris Signed-off-by: David Howells