Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932295AbVLUHKK (ORCPT ); Wed, 21 Dec 2005 02:10:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932300AbVLUHKJ (ORCPT ); Wed, 21 Dec 2005 02:10:09 -0500 Received: from zproxy.gmail.com ([64.233.162.193]:41842 "EHLO zproxy.gmail.com") by vger.kernel.org with ESMTP id S932294AbVLUHKH convert rfc822-to-8bit (ORCPT ); Wed, 21 Dec 2005 02:10:07 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=sqykHYfZsXAru9XW8752jG+mZSBdHsNbyW6JOi54WEV2g2Qhf82Xe6E1P0aRxL4JWAEvBC3aEFGGF190Xr+Dmp25v3h5j9Ifa9Ua8eHvT85DiQ8Y3U+kuTCAZ/iJ4RyZYvksGhGuX/NHHKOjeHq0vm25eZq+F7LXTf6Or6NxlHY= Message-ID: <41b516cb0512202310q78d5a25apab3c9d6fbb17089e@mail.gmail.com> Date: Tue, 20 Dec 2005 23:10:07 -0800 From: Chris Leech To: lkml , netdev Subject: Fwd: [RFC][PATCH 4/5] I/OAT DMA support and TCP acceleration In-Reply-To: <41b516cb0512202305p45439464o6b7ba6c2c88062bc@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Content-Disposition: inline References: <1135142263.13781.21.camel@cleech-mobl> <43A8F43B.6020307@cosmosbay.com> <41b516cb0512202305p45439464o6b7ba6c2c88062bc@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1374 Lines: 39 Sorry, bounced from vger the first time due to formatting ---------- Forwarded message ---------- From: Chris Leech Date: Dec 20, 2005 11:05 PM Subject: Re: [RFC][PATCH 4/5] I/OAT DMA support and TCP acceleration To: Eric Dumazet Cc: lkml , netdev , "Grover, Andrew" , "Ronciak, John" On 12/20/05, Eric Dumazet wrote: > Please consider not enlarging cb[] if not CONFIG_NET_DMA ? > > I mean, most machines wont have a compatable NIC, so why should they pay the > price (memory, cpu) in a critical structure named sk_buff ? > > #ifdef CONFIG_NET_DMA > typedef dma_cookie_t net_dma_cookie_t; > #else > typedef struct {} net_dma_cookie_t; > #endif > > ... > > char cb[40+sizeof(net_dma_cookie_t)]; > That could be a good way to deal with it. Actually, I should double check the length of tcp_skb_cb. I took a quick look and thought that there might be some room left there anyway, even though the comment in tcp.h says otherwise. -Chris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/