Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1567191974-11578-1-git-send-email-zdai@linux.vnet.ibm.com>
In-Reply-To: <1567191974-11578-1-git-send-email-zdai@linux.vnet.ibm.com>
From:   Cong Wang <xiyou.wangcong@gmail.com>
Date:   Fri, 30 Aug 2019 12:11:44 -0700
Message-ID: <CAM_iQpVMYQUdQN5L+ntXZTffZkW4q659bvXoZ8+Ar+zeud7Y4Q@mail.gmail.com>
Subject: Re: [v2] net_sched: act_police: add 2 new attributes to support
 police 64bit rate and peakrate
To:     David Dai <zdai@linux.vnet.ibm.com>
Cc:     Jamal Hadi Salim <jhs@mojatatu.com>, Jiri Pirko <jiri@resnulli.us>,
        David Miller <davem@davemloft.net>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, zdai@us.ibm.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Aug 30, 2019 at 12:06 PM David Dai <zdai@linux.vnet.ibm.com> wrote:
> -       if (p->peak_present)
> +               if ((police->params->rate.rate_bytes_ps >= (1ULL << 32)) &&
> +                   nla_put_u64_64bit(skb, TCA_POLICE_RATE64,
> +                                     police->params->rate.rate_bytes_ps,
> +                                     __TCA_POLICE_MAX))

I think the last parameter should be TCA_POLICE_PAD.