Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Krishna Reddy <vdumpa@nvidia.com>
To:     Thierry Reding <thierry.reding@gmail.com>
CC:     "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        Thierry Reding <treding@nvidia.com>,
        "Yu-Huan Hsu" <YHsu@nvidia.com>, Sachin Nikam <Snikam@nvidia.com>,
        Pritesh Raithatha <praithatha@nvidia.com>,
        Timo Alho <talho@nvidia.com>,
        Alexander Van Brunt <avanbrunt@nvidia.com>,
        "Thomas Zeng (SW-TEGRA)" <thomasz@nvidia.com>,
        "olof@lixom.net" <olof@lixom.net>,
        Juha Tukkinen <jtukkinen@nvidia.com>,
        Mikko Perttunen <mperttunen@nvidia.com>,
        Robin Murphy <robin.murphy@arm.com>,
        "will.deacon@arm.com" <will.deacon@arm.com>,
        "joro@8bytes.org" <joro@8bytes.org>
Subject: RE: [PATCH 4/7] iommu/arm-smmu: Add global/context fault
 implementation hooks
Thread-Topic: [PATCH 4/7] iommu/arm-smmu: Add global/context fault
 implementation hooks
Thread-Index: AQHVXruKZbtcs6ei/UWKtdObCjFLnacTi3OAgACDQrA=
Date:   Fri, 30 Aug 2019 19:16:34 +0000
Message-ID: <BYAPR12MB27106FD6B6CC9E148B65EC00B3BD0@BYAPR12MB2710.namprd12.prod.outlook.com>
References: <1567118827-26358-1-git-send-email-vdumpa@nvidia.com>
 <1567118827-26358-5-git-send-email-vdumpa@nvidia.com>
 <20190830111707.GD23902@ulmo>
In-Reply-To: <20190830111707.GD23902@ulmo>
Accept-Language: en-US
msip_labels: MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Enabled=True;
 MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SiteId=43083d15-7273-40c1-b7db-39efd9ccc17a;
 MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Owner=VDUMPA@nvidia.com;
 MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SetDate=2019-08-30T19:16:31.2138242Z;
 MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Name=Unrestricted;
 MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Application=Microsoft Azure
 Information Protection;
 MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_ActionId=b0a80692-08dd-4053-81e6-c9ad30e09d0b;
 MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Extended_MSFT_Method=Automatic
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=vdumpa@nvidia.com; 
x-originating-ip: [216.228.112.21]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: fd8bd4a6-5fda-49f7-3e61-08d72d7e9285
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:BYAPR12MB3302;
x-ms-traffictypediagnostic: BYAPR12MB3302:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <BYAPR12MB33025AA63FDB763F7AB8BCDEB3BD0@BYAPR12MB3302.namprd12.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 0145758B1D
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39850400004)(136003)(376002)(366004)(396003)(346002)(189003)(199004)(7736002)(5660300002)(66476007)(6116002)(2906002)(54906003)(86362001)(9686003)(14454004)(4326008)(4744005)(66066001)(71190400001)(25786009)(476003)(71200400001)(316002)(478600001)(6916009)(256004)(53936002)(33656002)(14444005)(81166006)(6246003)(76116006)(446003)(7696005)(186003)(99286004)(55016002)(66946007)(6436002)(66446008)(102836004)(229853002)(64756008)(8936002)(76176011)(8676002)(3846002)(52536014)(6506007)(11346002)(486006)(305945005)(74316002)(81156014)(26005)(66556008);DIR:OUT;SFP:1101;SCL:1;SRVR:BYAPR12MB3302;H:BYAPR12MB2710.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: nvidia.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: hThOQPOD4UyBBJDssS49O8vPXdX/+3YtkJW0M/AEFvuna3eei0/SSWzR+Y3Y6n9xta8K58e4UT3oF/7lEKPoy2SrzkiJVIREHvgkPBUmi3vU3xqwEsx6qBJs8proKyXkm2SDLOGto0iO6KG+pzd0YccRnrRUI2sQzhg6vW7TUOe9AGKQsguGNeM+9VWQgXkNQaKG4gJKSOpGMYH/X+SotWh7sIJB6ITsvVDuamdNaU8HAx0t1FCCk0WNJOEi5ddfJkamfCiGjlknqdr71l/LZTPUAGlR1OdsggcyyAQlVOhXU9oEt6ArUGJqVHm3B2MFRrvz30jV98S4rkKQ6VxDiuFPlAwIoyfH6uuFx5DY0XiOkNEfSuF3mXIFN9U0ye2KC2ooBNiHQcQDB2uuQYLoxmABRocC8NWnDEwjHx0zJFI=
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: fd8bd4a6-5fda-49f7-3e61-08d72d7e9285
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2019 19:16:34.1580
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ua89oU9l2jLakWNC86UDmgNC2QsrinsJJdMFzYabhIc1RA/fqeDWmahRTxGjr/dz7uTqBBX38ZeR54Pyh3Ctkw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3302
X-OriginatorOrg: Nvidia.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1567192598; bh=UqFbOfHlHxl+PHSSdHh256Wvxcc8/fJG63tSzVGI4p0=;
        h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature:
         ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:
         Thread-Index:Date:Message-ID:References:In-Reply-To:
         Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:msip_labels:
         authentication-results:x-originating-ip:x-ms-publictraffictype:
         x-ms-office365-filtering-correlation-id:x-microsoft-antispam:
         x-ms-traffictypediagnostic:x-ms-exchange-transport-forked:
         x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers:
         x-forefront-prvs:x-forefront-antispam-report:received-spf:
         x-ms-exchange-senderadcheck:x-microsoft-antispam-message-info:
         MIME-Version:X-MS-Exchange-CrossTenant-Network-Message-Id:
         X-MS-Exchange-CrossTenant-originalarrivaltime:
         X-MS-Exchange-CrossTenant-fromentityheader:
         X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:
         X-MS-Exchange-CrossTenant-userprincipalname:
         X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg:
         Content-Language:Content-Type:Content-Transfer-Encoding;
        b=WcOLvSMP/HN4EkQuZ5sh/9j2Cz12E6x5uQxWqWsq0CtUfrk/4lECssd/b78fndLy0
         DWhyXOdYxXhonEyJ7GRMKY5xYzw5/kT/FPvd8eyf75VH/aOXvFKoiEig84IMQ4xpCW
         0I0C2P0R5hFBiGG95RrCQJWiIxoLn8ExuTKa7MmWLDqlPwWsKDZ6zlIXomoPeKBef4
         YewkKMgBI1TjDjzTax0eOsi+9QVAlr5gJk5rV6bUcFmxMDtICE0LWdP2VjMUPjfvwA
         MrXWQyJN5y34nYM/16mbgKzmI+lO99KqzuLAuY9qE8LfPW45sh1FM0sSYHLF1OyyjQ
         STnf4FY0pbn6w==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> +static irqreturn_t nsmmu_context_fault_inst(int irq,
>> +					    struct arm_smmu_device *smmu,
>> +					    int idx, int inst);

>More of these signed integers that could be unsigned. Also why the need to=
 predeclare this? Can you not just put the definition of the function up he=
re?

The singed integers are based on original function prototype from arm-smmu.=
c.  inst can be updated to unsigned.
This is because I was checking context faults from global fault handler as =
well.  This can avoided by using interrupt lines of all the instances acros=
s global and context irq entries.  Let me update.
=20
> +	if (smmu->impl->global_fault)
> +		return smmu->impl->global_fault(irq, smmu);
>>... and here about the extra level of indirection.

Fixing in next version.

-KR