Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1150110ybl; Fri, 30 Aug 2019 12:38:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqzhm90AYwiZvE2dsFW1bsXdDlTxC++eESlDkl4o8oMOUHCcYqAuQ5He+b1pMKWL3K+aOmRQ X-Received: by 2002:a17:90a:b115:: with SMTP id z21mr198583pjq.79.1567193925581; Fri, 30 Aug 2019 12:38:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567193925; cv=none; d=google.com; s=arc-20160816; b=YuPGNLTFwP0dybd/CSqYfOlBwlO627jsQT4xMvN8Fc7sxg+kew43nNlvOvm7v8epIA prhCl+RMArvHTKMN1zUbznnBEqc2teVhOUCpe0GlkCcW/VRSa2EAgcp0BRjTMo7kJnEa IJ1k7SEr+cyHcEfbGNHqEjQMcxEDuG8C7n3Gqg6JU2SqdGovksYkfAq5PNWIXA6D9CbD fEk84D3dAzIyESxvYhdqc+x71V44U3IgWbQg+Ui4UmUTKqjcGHKeKtsGBirsLo128aNG 4y6nViN0RYCu9RCvcE464TIDtuWn6LFVBOndWQb3uvLat8nwFHIgq2EfEZnhbJ3E5YAR x5Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=3kZ/NJnyXN0yquM09pSH+z00YFv7ov+AjZa3Udsid30=; b=0q9ohGzAP9DFHBuOApvK3Ze6NmVFy3wmVPCx8STpHnQ/da4d3wOSGcTdWFoJoH+Mur XFouFgRvCbvBSNt5aITGuQE+F6dj11+nI3Rm4y90IOxPxdCVtY9/7esNXndtfssVyF2Z Rj5XFVzdCbECegKAZy9y+ZyegCV3eg8Nc7VUOEd4qFlIMRJxZdbWb7CIsB24zeaqeEar NB1+KaIMKfwj7CuB+SS0TeaQW19xJt+382nnv9Tor6pDer/4rP95jj/yldIDvn9YP4z7 AExv9J9FqnjTeWiSRk5tjGUD7egTD7ZsHDchpnPtCpci8FPOvs7c0rkcw2oJutm6nMGN Z6WQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@networkplumber-org.20150623.gappssmtp.com header.s=20150623 header.b="XKAVN/4I"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a123si6814090pfd.114.2019.08.30.12.38.30; Fri, 30 Aug 2019 12:38:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@networkplumber-org.20150623.gappssmtp.com header.s=20150623 header.b="XKAVN/4I"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728293AbfH3ThY (ORCPT + 99 others); Fri, 30 Aug 2019 15:37:24 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:37264 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727979AbfH3ThX (ORCPT ); Fri, 30 Aug 2019 15:37:23 -0400 Received: by mail-pl1-f193.google.com with SMTP id bj8so3805317plb.4 for ; Fri, 30 Aug 2019 12:37:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3kZ/NJnyXN0yquM09pSH+z00YFv7ov+AjZa3Udsid30=; b=XKAVN/4IVjAB97Ac7Zope7eu3O+qGHxH5q3Cb6OdxMaikpodOqCLdST4a2QVGgXQzv 6mtabjSRdEG+JN0/+cl+OBYxsrnQwMhA/Nu0rDhUXcorw2fq+hWIUHFpBwqtmxIHkgCF Rk6fkUqhmSeCvBmLwuSSSHPaVjdk8CE8G55kQXvFlpn/E/xrQz9Ll2x0bpseuofiOoO2 5F0BNHn+07IaqyvsqaE9NHCIj0p7FnVaYZvtwDFAncBHjzJFDJJW3ze3O3u2qhni+aMa QEr6ug2H0TagdlpBs+qNaFp02VjaRzi8VckN4nRSUEzz3i9TfqPs3zzsxrR0wfHOQm3W RSkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3kZ/NJnyXN0yquM09pSH+z00YFv7ov+AjZa3Udsid30=; b=qjOCMggCwC44kerS7Gl4LYg3lQdBgVw/KA8wzYMYdcXGJNFqEfMLvcNCe95h8RMO9J eMjDSddd1sMqiTUI1A9gzADvuSEaE1t8atj0v8nvW1pBINcJZRsG+8YpfiwyH5eM4Hsx 3yVh1ueiA9GiJqqLnVffAzKL9/m+LOaKZE2iVqc2tWjkv0MMm5xGnEy9f4Y48Khw7QUj GCYYRCjqTgHc6YpXI6SzkFmcN2tEc/kKBaXUheX3C1kkF/7VGUTDgvR3BCQxXHxn6D05 PgTcmB84zVOqNYy/QZpRd6/Tfmpm5QoAl/DE/vouBiC3Uhkg1vERWg6PZN7+FgEE3yb0 aXSQ== X-Gm-Message-State: APjAAAV3vtS5qZ/Fhc6LG9xBUFU/tlb3LwcBVkzLGnV7BhUSp4qm0DKY SR0KfD/DciAvcM1Om0YEws1Grg== X-Received: by 2002:a17:902:f64:: with SMTP id 91mr17373110ply.334.1567193842913; Fri, 30 Aug 2019 12:37:22 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id v8sm2650838pje.6.2019.08.30.12.37.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Aug 2019 12:37:22 -0700 (PDT) Date: Fri, 30 Aug 2019 12:37:20 -0700 From: Stephen Hemminger To: David Dai Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, zdai@us.ibm.com Subject: Re: [v2] iproute2-next: police: support 64bit rate and peakrate in tc utility Message-ID: <20190830123720.167de780@hermes.lan> In-Reply-To: <1567192037-11684-1-git-send-email-zdai@linux.vnet.ibm.com> References: <1567192037-11684-1-git-send-email-zdai@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 30 Aug 2019 14:07:17 -0500 David Dai wrote: > + if (rate64) { > fprintf(stderr, "Double \"rate\" spec\n"); > return -1; > } The m_police filter should start using the common functions for duparg and invarg that are in lib/utils.c