Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Ben Wei <benwei@fb.com>
To:     David Miller <davem@davemloft.net>
CC:     "sam@mendozajonas.com" <sam@mendozajonas.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH net-next] net/ncsi: add response handlers for PLDM over
 NC-SI
Thread-Topic: [PATCH net-next] net/ncsi: add response handlers for PLDM over
 NC-SI
Thread-Index: AdVdK7Dkb5gbkg6XQAi/YA23MivgTgAyLPMAAGApfFA=
Date:   Fri, 30 Aug 2019 20:57:21 +0000
Message-ID: <CH2PR15MB3686B906CA6E822D69F3C225A3BD0@CH2PR15MB3686.namprd15.prod.outlook.com>
References: <CH2PR15MB3686302D8210855E5AB643B1A3A00@CH2PR15MB3686.namprd15.prod.outlook.com>
 <20190828.160032.599086044004802986.davem@davemloft.net>
In-Reply-To: <20190828.160032.599086044004802986.davem@davemloft.net>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: f1f69af0-dd7e-4862-2a30-08d72d8ca71f
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2019 20:57:21.7733
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 34gd2OY0ZsYZzJ2axKRBMOJBCtUaBS5JthFAaUuu7z3uRjpWx8H5OviZLGV2atnI
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR15MB3736
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8
 definitions=2019-08-30_07:2019-08-29,2019-08-30 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 clxscore=1015 bulkscore=0
 impostorscore=0 suspectscore=0 spamscore=0 phishscore=0 mlxscore=0
 malwarescore=0 adultscore=0 lowpriorityscore=0 mlxlogscore=784
 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-1906280000 definitions=main-1908300200
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> > This patch adds handlers for PLDM over NC-SI command response.
> >=20
> > This enables NC-SI driver recognizes the packet type so the responses d=
on't get dropped as unknown packet type.
> >=20
> > PLDM over NC-SI are not handled in kernel driver for now, but can be pa=
ssed back to user space via Netlink for further handling.
> >=20
> > Signed-off-by: Ben Wei <benwei@fb.com>
>
> I don't know why but patchwork puts part of your patch into the commit me=
ssage, see:
>
> https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__patchwork.ozlabs.o=
rg_patch_1154104_&d=3DDwICAg&c=3D5VD0RTtNlTh3ycd41b3MUw&r=3DU35IaQ-> 7Tnwjs=
7q_Fwf_bQ&m=3DvxOIQa5Sv7aY4LKSUvlobJd_TtHOz1KLjxZw8WXmkJM&s=3DA8rpxgac6iuSE=
H2DqCSzBDdM82Eu3pD8_nGHx9YtGW8&e=3D=20
>
> It's probably an encoding issue or similar.
>
> > +static int ncsi_rsp_handler_pldm(struct ncsi_request *nr) {
>>  +	return 0;
> > +}
> > +
> >  static int ncsi_rsp_handler_netlink(struct ncsi_request *nr)  {
>
> I know other functions in this file do it, but please put the openning
> curly braces of a function on a separate line.
>
> Thank you.

Thanks David. I think the issue is related to my email client setting. I fi=
xed it and resubmitted a v2 version of this patch.

Thanks,
-Ben