Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1235697ybl; Fri, 30 Aug 2019 14:16:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqwOJejNHESv/wGTB7lVnJVoZZ9VAPDa0sE9WRBiYJGZS6alrTkywbEXNHiLDXx8I1tAPbh6 X-Received: by 2002:a63:db45:: with SMTP id x5mr14446051pgi.293.1567199818888; Fri, 30 Aug 2019 14:16:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567199818; cv=none; d=google.com; s=arc-20160816; b=dJeDOEPzcMaEDUK9kSU+98W8f8y3HkLA2zZVb0A1yt+vjK3sOsN6epqRIzVoU/Huf7 NiVEqcn87lIwPWeyRlgwM2QiMdKvxn7bD0N5b6EgZSwWY+siEaYyfIedCMX6uzierWDp nrAeDHH8FB/3LYujkFY8/vJUoqlQob9C8nQhxrqsGPDHL2YWMG6RYgiqdC1XbFy3OAIi EwKCAh718j4b+j1eQK0TncoHl1AUkcvggfRjpWGfm72r9PjSX3ehfro7NWHgdUnm3Y2d JA5RfbWM3YLazc+zxsppmNtrW/KMT/zuc4LwlEj//ukCB0DzD2TYeG8ZQ1vufEMvOSvg jmlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=9T1aInmSxWKts73/3oAaaPpt+JimbAFO/22nFLCsJ0Q=; b=UpWJr2YpidChXq2bAgAJiQD+i3isjVuUtkJGzaRs5+PB/RBy91qgiWkEa2Bl1cpFi3 yrOaYqc+Z5vWMLsJGhIMPFy+kTHZCBXNbpjUEHBY+4Os+PbVItXvT9cuLZg9V6J5qotK IA6Nokdp4UXteWq5ib+UeI+/DtErm1GHZRgYNxTHK8flOZafRD8jZKGFVopMAa3VWiUy ythDawmDbcUDsmwvtvcH8om8b0mJ9LF/F8IkAHyyv0HcoBeJmRp7LZsNHjWVCF7JgXXL cAFoIqwuombx6T9T2gWL7M3d6CUvRor116Gsi/7peImYnv0kjOvSpTVNHLDuWpasrM77 jWKA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g3si5637847pjs.21.2019.08.30.14.16.43; Fri, 30 Aug 2019 14:16:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728185AbfH3VPw (ORCPT + 99 others); Fri, 30 Aug 2019 17:15:52 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:42046 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727991AbfH3VPv (ORCPT ); Fri, 30 Aug 2019 17:15:51 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 531DA154FE294; Fri, 30 Aug 2019 14:15:51 -0700 (PDT) Date: Fri, 30 Aug 2019 14:15:50 -0700 (PDT) Message-Id: <20190830.141550.302970621444143276.davem@davemloft.net> To: yuehaibing@huawei.com Cc: thomas.lendacky@amd.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] amd-xgbe: Fix error path in xgbe_mod_init() From: David Miller In-Reply-To: <20190829024600.16052-1-yuehaibing@huawei.com> References: <20190829024600.16052-1-yuehaibing@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 30 Aug 2019 14:15:51 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing Date: Thu, 29 Aug 2019 10:46:00 +0800 > In xgbe_mod_init(), we should do cleanup if some error occurs > > Reported-by: Hulk Robot > Fixes: efbaa828330a ("amd-xgbe: Add support to handle device renaming") > Fixes: 47f164deab22 ("amd-xgbe: Add PCI device support") > Signed-off-by: YueHaibing Applied.