Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: kr0Q9TL0/kFdncT9926ysFvpQAaMqrp2mUz2jFwkWhZ64JBHoNi9WdmR0AIRfFseROYXFwTv8G
 CXW8JpfyleoIQmG0eRz6Pl9dr6+L1vBgAW8MsW0biZepJVxB3XZm+cPYi+3ivks2sW5yAdZ/v0
 1ZdXwA60Ru5FSRfLBFN37IfJOZ8IFRiMpAc/3lqmGVG2ZR8bmypbv/zBUU3pfI3eoaVduxPhhh
 ECLcgrQsFnterhoGvfL+rvqTrdKE1kZH5CddHclWbNHbOwfpZZsgdllVtrW6gVdyngKcH7Auxo
 e5Y=
IronPort-PHdr: =?us-ascii?q?9a23=3AXoLW3B9YxSDOgv9uRHKM819IXTAuvvDOBiVQ1K?=
 =?us-ascii?q?B41OwcTK2v8tzYMVDF4r011RmVBN+dsqwZwLOP+4nbGkU4qa6bt34DdJEeHz?=
 =?us-ascii?q?Qksu4x2zIaPcieFEfgJ+TrZSFpVO5LVVti4m3peRMNQJW2aFLduGC94iAPER?=
 =?us-ascii?q?vjKwV1Ov71GonPhMiryuy+4ZLebxhWiDanfL9/LRW7oQrMusULnIBvNrs/xh?=
 =?us-ascii?q?zVr3VSZu9Y33loJVWdnxb94se/4ptu+DlOtvwi6sBNT7z0c7w3QrJEAjsmNX?=
 =?us-ascii?q?s15NDwuhnYUQSP/HocXX4InRdOHgPI8Qv1Xpb1siv9q+p9xCyXNtD4QLwoRT?=
 =?us-ascii?q?iv6bpgRQT2gykbKTE27GDXitRxjK1FphKhuwd/yJPQbI2MKfZyYr/RcdYcSG?=
 =?us-ascii?q?FcXMheSjZBD5uzYIsBDeUPPehWoYrgqVUQsRSzHhWsCP/1xzNUmnP6wa833u?=
 =?us-ascii?q?I8Gg/GxgwgGNcOvWzWo9X0NaYSUf21zK7VxjrAb/NZwzb945XPfxEhoPCMXa?=
 =?us-ascii?q?h/ccvNxUUzGQ7IlUiQppD/Pz+PyOsCrnWb4vNmWOmyiGAnsxl8riazysookI?=
 =?us-ascii?q?XEhYIYxkrZ+Sh4wos5P9+1RFJ9bNW5CpVfrTuaOJFzQs46RmFovzs1xaMetJ?=
 =?us-ascii?q?6geSgK1IwnxxnCa/yba4SI4gzsVOKWITpggXJqYrO/hxKr/UikxO3wS9C40F?=
 =?us-ascii?q?hIoyZZiNXMuXcN1xvc6siDVPRx5Fuu2TGK1wzL6+FEJ147lbbDJpI/3rI9ko?=
 =?us-ascii?q?AfvEfDEyPshUn7ja2bel8m9+S08+jnZ6/ppp6YN496kAH+NaEul9S/AOU5Mg?=
 =?us-ascii?q?gBRWmb9fig2LDt5kD5XalFjucsnqbHrZ/aONwXprSlDA9NzoYj9xG/Ai+i0N?=
 =?us-ascii?q?QZm3kHMV1EdAuEj4f3IVHOJu73DfOkjlSynzdk2erGMqfiAprTNHjDlqnufb?=
 =?us-ascii?q?Jn505b0gozwoMX25UBJrgfIf67f071sNHCRks1OhK5xs7rActw04cZV37JBK?=
 =?us-ascii?q?KFZvD8q1iNs9MuMemRY8cnuD/8Y6w09f7njCdhwncAdrPv0JcKPiPrVs96Kl?=
 =?us-ascii?q?mUNCK/yuwKFn0H609nFLTn?=
MIME-Version: 1.0
References: <20190207174623.16712-1-yzhai003@ucr.edu> <20190208.230117.1867217574108955553.davem@davemloft.net>
In-Reply-To: <20190208.230117.1867217574108955553.davem@davemloft.net>
From:   Yizhuo Zhai <yzhai003@ucr.edu>
Date:   Fri, 30 Aug 2019 15:29:07 -0700
Message-ID: <CABvMjLRzuUVh7FxVQj2O40Sbr+VygwSG8spMv0fW2RZVvaJ8rQ@mail.gmail.com>
Subject: Re: [PATCH] net: stmmac: Variable "val" in function
 sun8i_dwmac_set_syscon() could be uninitialized
To:     David Miller <davem@davemloft.net>
Cc:     Chengyu Song <csong@cs.ucr.edu>, Zhiyun Qian <zhiyunq@cs.ucr.edu>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        Maxime Ripard <maxime.ripard@free-electrons.com>,
        Chen-Yu Tsai <wens@csie.org>, netdev@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi David:

Thanks for your feedback, this patch should work for v4.14.


On Fri, Feb 8, 2019 at 11:01 PM David Miller <davem@davemloft.net> wrote:
>
> From: Yizhuo <yzhai003@ucr.edu>
> Date: Thu,  7 Feb 2019 09:46:23 -0800
>
> > In function sun8i_dwmac_set_syscon(), local variable "val" could
> > be uninitialized if function regmap_read() returns -EINVAL.
> > However, it will be used directly in the if statement, which
> > is potentially unsafe.
> >
> > Signed-off-by: Yizhuo <yzhai003@ucr.edu>
>
> This doesn't apply to any of my trees.


--
Kind Regards,

Yizhuo Zhai

Computer Science, Graduate Student
University of California, Riverside