Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1331900ybl; Fri, 30 Aug 2019 16:19:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqxg1P8m4RKflD+HAbab3ryBhIwr7VTiRcph0YJoXIz0M7P2OT4quCts3HCYZnAe1IW9QPA+ X-Received: by 2002:a17:90a:4483:: with SMTP id t3mr560248pjg.59.1567207183236; Fri, 30 Aug 2019 16:19:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567207183; cv=none; d=google.com; s=arc-20160816; b=lo9rNxjuZnruYmFx0geW2ZtfFinI7fr7+H+Zk6YYq7QhF0acmrtLywW4ZuevDJoVrd aPUKbMZ5P9FRO2Cv38o/XhMcnc9w7BdCNje1fIt8UVf0tHkWfCUablODB+9r6QCRy67S EsmbHBNSrtovHaiwFgHdMwuN3mPBRlWv54qJyulBhzG9JVXj1W1oePfeLgJ85kqB9UXK Sv5Ctlq5zyZBnryiBIPOVYq9GF/9usos8vDPviH9zh5hcRdICaH3QEouCHIqaCvq0+QY QKkDB+zgTk1rejJqorijcWRt+OQyAKMXjEQhFsa2hkUPWeqKl/MXHks+qai5WoxhBUiZ b+5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Z7Fsc+37SdglEjx6/P+VaXoRvmLqI7xYMe39+8FKKog=; b=Rbyc2IxfyqYbsitjTDcmZKv22IjwmfIb7bH3hl8bjtTOnqu6Id81y4RC+ApZ0oO79m pkopmS0qjkhilSvhNLU5LbxaXJuVQ9+1BrW6fcVs5F2Oh5Lmm4GjH73Op4LDxOgM1A5i 0/GiWoYQTxaglz/MQMGV5QbFqwzG8jKUJ7kxKOMTHH2pXEsPEn9DFYkKl5lNipz8flhU M5s/Geezst0NxETKClVXi+5OnMmjy+cqj6Ygp9wj723dz0oNq7lPbviVMqq3Jmqd/FrN ZgG1AAMbEQHNad/UNy6O9H6ZlcNLDKQFWEef3MauRBE4SoIOf53jdkp8YIzO+jnI1IIC WfjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=SRkoLbFd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x7si6005758plv.180.2019.08.30.16.19.27; Fri, 30 Aug 2019 16:19:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=SRkoLbFd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728353AbfH3XSi (ORCPT + 99 others); Fri, 30 Aug 2019 19:18:38 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:40322 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728314AbfH3XSh (ORCPT ); Fri, 30 Aug 2019 19:18:37 -0400 Received: by mail-pf1-f195.google.com with SMTP id w16so5541268pfn.7 for ; Fri, 30 Aug 2019 16:18:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Z7Fsc+37SdglEjx6/P+VaXoRvmLqI7xYMe39+8FKKog=; b=SRkoLbFdjxOOLUsGorlvwCDB8Y7h+4UZCxPAUooe5JUYDpPZoOm+hC88wSCIUVQUJi FedLK4Mry/31IytlGZFBo09jNfGHCQpy+KeCRFEAjd/CHA9NXZ0xgmevw0j+ww4PVOri NVgKz5E4oVN1UEDexyn1rDN7wNhQVIao8Kavw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Z7Fsc+37SdglEjx6/P+VaXoRvmLqI7xYMe39+8FKKog=; b=gicbI4LBBAF3bmyv0bu042JXy1gQ/fQC7CcWcUpB3sbaAjJTHtTJTDVFd9gg4fOj7t bTWrLlIQjJdpaf5OXQC2phesPYGONeFCGHTwIWApJWUkjvIoOH/6B+OO5fLPBAAxeDMv hSE7znRCp3IDaf2yOvCP7chuugmAXrGA86lAyAdTRbMVg2PW5yd1Pp5IsEDvWudkavzA 6qbWAOuPy/KmU3BvfPtJr2YoWpVeRXwVLpkMLG9hMZ0kiDCxiUk/+HdBmA41uaEya1L3 9Sebai3lVvAHhPtjBEHYm27erRASd8TWSu2KxXDj4fgcSp1LBOHzm9vp6UkJC9bNoBmi iOCg== X-Gm-Message-State: APjAAAWa1MfywouvzmVgZpYaTq8/73UVBWf/NyfBldr3iqAX3lVHT2Mc uja4ClD8+NBSbmbra/g3cT/Y26wlzhg= X-Received: by 2002:a17:90a:3748:: with SMTP id u66mr1008427pjb.4.1567207116764; Fri, 30 Aug 2019 16:18:36 -0700 (PDT) Received: from joelaf.cam.corp.google.com ([2620:15c:6:12:9c46:e0da:efbf:69cc]) by smtp.gmail.com with ESMTPSA id t23sm8479395pfl.154.2019.08.30.16.18.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Aug 2019 16:18:36 -0700 (PDT) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org Cc: "Joel Fernandes (Google)" , Andrew Morton , Arnd Bergmann , Bjorn Helgaas , Catalin Marinas , "Gustavo A. R. Silva" , Jonathan Derrick , Keith Busch , linux-pci@vger.kernel.org, Lorenzo Pieralisi Subject: [PATCH 2/2] ipc/sem: Convert to use built-in RCU list checking Date: Fri, 30 Aug 2019 19:18:17 -0400 Message-Id: <20190830231817.76862-2-joel@joelfernandes.org> X-Mailer: git-send-email 2.23.0.187.g17f5b7556c-goog In-Reply-To: <20190830231817.76862-1-joel@joelfernandes.org> References: <20190830231817.76862-1-joel@joelfernandes.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org CONFIG_PROVE_RCU_LIST requires list_for_each_entry_rcu() to pass a lockdep expression if using srcu or locking for protection. It can only check regular RCU protection, all other protection needs to be passed as lockdep expression. Signed-off-by: Joel Fernandes (Google) --- ipc/sem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ipc/sem.c b/ipc/sem.c index 7da4504bcc7c..ec97a7072413 100644 --- a/ipc/sem.c +++ b/ipc/sem.c @@ -1852,7 +1852,8 @@ static struct sem_undo *__lookup_undo(struct sem_undo_list *ulp, int semid) { struct sem_undo *un; - list_for_each_entry_rcu(un, &ulp->list_proc, list_proc) { + list_for_each_entry_rcu(un, &ulp->list_proc, list_proc, + spin_is_locked(&ulp->lock)) { if (un->semid == semid) return un; } -- 2.23.0.187.g17f5b7556c-goog