Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1748244ybl; Sat, 31 Aug 2019 01:27:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqxkgHEOoTOabwmqTnGxwfMnF1cK4fqUxODYjq1cVrOTGtnU9XrVS7p+alGLL7rezDSAHdST X-Received: by 2002:a63:2026:: with SMTP id g38mr16081792pgg.172.1567240054263; Sat, 31 Aug 2019 01:27:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567240054; cv=none; d=google.com; s=arc-20160816; b=FC/NSIf3ceaXULXLuDWNjdhXAPcGxTPedpSvxWH5RdOBHK1UMGF5uRthlIgoZpOQSk YpGkm4fAURNYkV4Ppus3sq/p2dYmKevZnWOO04vyLoXH9m8oSJCr1oCxXa8kqvoNVL3D JVLOZ3ystWEGBrm6UeX8Hpp6TMGjPKIA8d7pH6+TzDXDdFVD8hOk8yDncnqcTu3ceDDb E90UmZiAU6U/Fd972A3+FBVdmDTDQNGJqeg35Ttq03lBdpgUHC/e89tcTnaYVXrz89r/ q3posQ49P15xT2wTy1whe5BSOxmLabs6v84WDFO3DZ8wGv6c9RISZjk9x82lE5yeGtlY RamA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=IppZVsNrdO92OvoS1LJqmwJMiupqzDfayevUPVJLm5Y=; b=g4N62XUx+nKap8EMeybpDpNQilIlumfKwAhK6BUgQM1Yoro36cFIX0GhepPZ3HNw06 JDO+XlOjZ2YYH60RL4ojw9XfgECOe6lkIYKADvDBIpUEmbATb3ziP61D/+mkqBfzxerJ fqVhb88stzPwcKO1PPD6iCqrxvDmAbw25HEqDHT8ssa7F0Wkc3w1LFh5KknYrMWwV6ex 01Ld+q76hiW5iD/FrF+PYSnZAgj5L+vBPOh4/X/oC4DkOKqiWQDVqYaVreiu7CRlGwDN hr26Gh/nbUMeLXZn695+Dnve10G5jBECQxMYSQaieh1m42Wa4taIpCexLzUCrzWISP2f GUTA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h31si6171937pgb.67.2019.08.31.01.26.25; Sat, 31 Aug 2019 01:27:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726650AbfHaITD convert rfc822-to-8bit (ORCPT + 99 others); Sat, 31 Aug 2019 04:19:03 -0400 Received: from mx2.suse.de ([195.135.220.15]:51642 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726116AbfHaITD (ORCPT ); Sat, 31 Aug 2019 04:19:03 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 81E3EAEF8; Sat, 31 Aug 2019 08:19:01 +0000 (UTC) Date: Sat, 31 Aug 2019 10:19:00 +0200 From: Thomas Bogendoerfer To: Christophe JAILLET Cc: davem@davemloft.net, yuehaibing@huawei.com, tglx@linutronix.de, gregkh@linuxfoundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] net: seeq: Fix the function used to release some memory in an error handling path Message-Id: <20190831101900.c3f8881c1bbebf870eed9c68@suse.de> In-Reply-To: <20190831071751.1479-1-christophe.jaillet@wanadoo.fr> References: <20190831071751.1479-1-christophe.jaillet@wanadoo.fr> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 31 Aug 2019 09:17:51 +0200 Christophe JAILLET wrote: > In commit 99cd149efe82 ("sgiseeq: replace use of dma_cache_wback_inv"), > a call to 'get_zeroed_page()' has been turned into a call to > 'dma_alloc_coherent()'. Only the remove function has been updated to turn > the corresponding 'free_page()' into 'dma_free_attrs()'. > The error hndling path of the probe function has not been updated. Looks good. Reviewed-by: Thomas Bogendoerfer Thomas. -- SUSE Software Solutions Germany GmbH HRB 247165 (AG M?nchen) Gesch?ftsf?hrer: Felix Imend?rffer