Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
To:     Denis Efremov <efremov@linux.com>, linux-wimax@intel.com
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>,
        Joe Perches <joe@perches.com>, linux-kernel@vger.kernel.org
References: <20190829165025.15750-6-efremov@linux.com>
Subject: Re: [PATCH v3 06/11] wimax/i2400m: remove unlikely() from WARN*()
 condition
From:   Markus Elfring <Markus.Elfring@web.de>
Message-ID: <c9d3f0e1-d2c9-aedb-385c-82a8cb077253@web.de>
Date:   Sat, 31 Aug 2019 13:25:29 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.0
MIME-Version: 1.0
In-Reply-To: <20190829165025.15750-6-efremov@linux.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

>  		pad_buf = i2400m_tx_fifo_push(i2400m, padding, 0, 0);
> -		if (unlikely(WARN_ON(pad_buf == NULL
> -				     || pad_buf == TAIL_FULL))) {
> +		if (WARN_ON(pad_buf == NULL || pad_buf == TAIL_FULL)) {

How do you think about to use the following code variant?

+		if (WARN_ON(!pad_buf || pad_buf == TAIL_FULL)) {


Regards,
Markus