Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp2080031ybl; Sat, 31 Aug 2019 07:42:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqy3o9oTaOCd2vQKdxhD6s+xB3x0wD0Y4yHIH8Hvd70l8849gkEMK7hbh21+gvg5SY4966TJ X-Received: by 2002:a17:902:8f90:: with SMTP id z16mr21272461plo.138.1567262527258; Sat, 31 Aug 2019 07:42:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567262527; cv=none; d=google.com; s=arc-20160816; b=VrcMQ/Vu755e5evtIjZU2XAQhY3el6SJgMi7lcP573+7a+Vg8gGaPYSnNtLFlt/7oj UlusMPqvNCDQo24mgvJ2+PyfGAAEypd6miiByfedgETzzs7zChc0GcOU3yR2LSxhb3DX UWcNRNgouO8Nc2CJauguTCV5n6lvM9sQYNtnkku2Ek4TLMSevyH19oUieqdg//Q2XIhL aPzrhKGmtve+HGkse0D5i0kcEC5R8GfxHSbmFWO3ZwKWQFySYHUKNWhs1WcsNosgDX+j h4N/i7JCUWfLgF6mHuPlIyC/vg3EABaKA2QqlSKNLN2F97BDaOpJqPVnI1ZPSj5CmSM3 M0Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=lwEmp1kDTQ3Jn1SW8xtl3haIlhSExOyTeIkvr/BLe40=; b=VN2vS80lgK6kR5i+NHltN90R61gbJMtxiObbxzpnR1o9M9o19NVAnpFR4IrOCoDI9v i6xQxdDKRtMeTvSBPEx7Gs9p6+jnPZ+7EKNsQbBfmyrxxaWnxlRtwJC5EovnXsgnwwWa IXCsQSgwaqakJk+Y96W8n0hIYz4N3Ej/a1OYDcaSgl8zZCM0YQEv7ehcDD9BctCHkS3v c4KtidUIq8VioKtZGZMjLogjbFBBuiEu5FO8YZVTsJ3pruOrmDLecT8Sxi1uwyx/gRsu kNCn/3eySAv2nDfJdCmIJ8cf6ZiVcKH96Svudm/DuCObBLe17slTrk5KB+dcjHZJ6M3d wD4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=dbaOe7gs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r24si9135340pfh.257.2019.08.31.07.41.37; Sat, 31 Aug 2019 07:42:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=dbaOe7gs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728090AbfHaOkP (ORCPT + 99 others); Sat, 31 Aug 2019 10:40:15 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:35144 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727861AbfHaOkP (ORCPT ); Sat, 31 Aug 2019 10:40:15 -0400 Received: by mail-wm1-f65.google.com with SMTP id l2so10332220wmg.0 for ; Sat, 31 Aug 2019 07:40:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lwEmp1kDTQ3Jn1SW8xtl3haIlhSExOyTeIkvr/BLe40=; b=dbaOe7gsw7vbI31moeXg5xlZY/Vw1BO2RNU6iZ0gQO8pGKzqcsvP97xwcNIAKDwUbk H+HUJDWDVwfK50rCnKvggoKRtANaHiNby2worNOZUwl7Zz8dLdxsAXCGDzPV3p23YCDK z/QgV9W/1ompNHZQ06OxWT33mmEvqOuScPpLrS4oUTzaBTDU/u5GBE+WvW8sucRviNwL qYJfQADZPN1WQLJn3yEQClJXCH8K/HU7Ow0zbxpBTOR6qiNC2JdXPR7aP8DHo76OkjAa Xu9Iz9xqakTzNmtw9PTlYZCEX70gc+RTCGJinLcVUd0zsFBdenqJnP9+v3/qYJklQ4ZU OGxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lwEmp1kDTQ3Jn1SW8xtl3haIlhSExOyTeIkvr/BLe40=; b=V2PsDKthoOq5He3YT/37bvU5MfpypGQsHhBTyIxsie0RrF9fpg/8+H+PGHWUByrxUn caYFYnLHNn0MBRs3S5TfDPUSL1X0KUY9RCvvjHd7NExbFuQU5yth+mqk7Vj4TlxVcT0X WNZiBaxguNHKNHsuow5M464Rz63DH6qDtSK1bU6wugoORmHgTkl8TRjZySY843ycmRQa 6WdHf2n55PYw6Lb8+kdH0y5v7u9nFnPnqMDZh7ySbxhMRYUmJQ5wIQ4M6x4nWBxwwL3p AAlm8ertO/ubUiVv0rT5CzvtvPSKdnBS75VH4fg/hfAja1VEXdvDlJWkzTG9uQlhtsaR iu5w== X-Gm-Message-State: APjAAAWo8Jp/ka2YoBAHT8MlCFNzndZP848bE8IREOou+cLPeBlirVL8 7CIU9AILVRdMBU+0EuHgruYaDsfLX6SU5Li145fe X-Received: by 2002:a7b:c4d5:: with SMTP id g21mr25303766wmk.149.1567262412501; Sat, 31 Aug 2019 07:40:12 -0700 (PDT) MIME-Version: 1.0 References: <20190830132311.7190ccc3@canb.auug.org.au> <9ae74244-f1e1-de7f-6d03-b2cca012f6fc@nvidia.com> <20190831084917.GA27466@e121166-lin.cambridge.arm.com> In-Reply-To: <20190831084917.GA27466@e121166-lin.cambridge.arm.com> From: Bjorn Helgaas Date: Sat, 31 Aug 2019 09:40:00 -0500 Message-ID: Subject: Re: linux-next: build failure after merge of the pci tree To: Lorenzo Pieralisi Cc: Vidya Sagar , Linux Next Mailing List , Linux Kernel Mailing List , Stephen Rothwell , Krzysztof Wilczynski Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 31, 2019 at 3:49 AM Lorenzo Pieralisi wrote: > > On Sat, Aug 31, 2019 at 09:51:05AM +0530, Vidya Sagar wrote: > > On 8/30/2019 6:00 PM, Bjorn Helgaas wrote: > > > [+cc Krzysztof] > > > > > > On Thu, Aug 29, 2019 at 10:23 PM Stephen Rothwell wrote: > > > > > > > > Hi all, > > > > > > > > After merging the pci tree, today's linux-next build (x86_64 allmodconfig) > > > > failed like this: > > > > > > > > drivers/pci/controller/dwc/pcie-tegra194.c:24:10: fatal error: linux/pci-aspm.h: No such file or directory > > > > 24 | #include > > > > | ^~~~~~~~~~~~~~~~~~ > > > > > > > > Caused by commit > > > > > > > > 81564976b1a9 ("PCI: tegra: Add Tegra194 PCIe support") > > > > > > > > I have reverted that commit for todat. > > > > > > Thanks, Stephen. > > > > > > I *could* fix this by removing that include in the merge, since the > > > contents of linux/pci-aspm.h were moved into linux/pci.h by > > > https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?id=7ce2e76a0420 > > > > > > But as far as I can tell, pcie-tegra194.c doesn't actually require > > > anything from linux/pci-aspm.h, so I'd rather amend the tegra194 > > > commit https://git.kernel.org/cgit/linux/kernel/git/lpieralisi/pci.git/commit/?id=81564976b1a9 > > > so it doesn't include pci-aspm.h in the first place. > > Thanks Bjorn for the reply. > > Yes. This header file is not required for now and can be removed. > > Is there any action required from my side for this? > > I updated my pci/tegra branch so that Bjorn can pull it. I pulled it and updated my "next" branch, thanks!