Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3 06/11] wimax/i2400m: remove unlikely() from WARN*()
 condition
To:     Markus Elfring <Markus.Elfring@web.de>, linux-wimax@intel.com
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>,
        Joe Perches <joe@perches.com>, linux-kernel@vger.kernel.org
References: <20190829165025.15750-6-efremov@linux.com>
 <c9d3f0e1-d2c9-aedb-385c-82a8cb077253@web.de>
From:   Denis Efremov <efremov@linux.com>
Message-ID: <4a064df8-9b44-8380-d7c5-8a94086c3a52@linux.com>
Date:   Sat, 31 Aug 2019 18:59:53 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <c9d3f0e1-d2c9-aedb-385c-82a8cb077253@web.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 31.08.2019 14:25, Markus Elfring wrote:
>>          pad_buf = i2400m_tx_fifo_push(i2400m, padding, 0, 0);
>> -        if (unlikely(WARN_ON(pad_buf == NULL
>> -                     || pad_buf == TAIL_FULL))) {
>> +        if (WARN_ON(pad_buf == NULL || pad_buf == TAIL_FULL)) {
> 
> How do you think about to use the following code variant?
> 
> +        if (WARN_ON(!pad_buf || pad_buf == TAIL_FULL)) {
> 

Well, I thought about it, because coccinelle warns about style here.
But this condition looks more symmetric with direct comparison.
I've decided that it will be better to save the original style.

Thanks,
Denis