Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] r8188eu: use skb_put_data instead of skb_put/memcpy pair
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Larry Finger <Larry.Finger@lwfinger.net>,
        devel@driverdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sanjana Sanikommu <sanjana99reddy99@gmail.com>,
        Vatsala Narang <vatsalanarang@gmail.com>,
        Colin Ian King <colin.king@canonical.com>
References: <4c9e1e66-5ffc-c04b-9ea8-39cec5fd9b2a@gmail.com>
 <20190827103134.GC23584@kadam>
From:   Ivan Safonov <insafonov@gmail.com>
Message-ID: <33548df8-6eb3-0ce6-d37e-1b4b79b0dcfc@gmail.com>
Date:   Sat, 31 Aug 2019 20:30:16 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20190827103134.GC23584@kadam>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 8/27/19 1:31 PM, Dan Carpenter wrote:
> On Sun, Aug 25, 2019 at 11:48:58PM +0300, Ivan Safonov wrote:
>> skb_put_data is shorter and clear.
>>
> 
> Please don't start the commit message in the middle of a sentence.  It
> often gets split from the start of the sentence.  See how it looks here.
> https://marc.info/?l=linux-driver-devel&m=156676594611401&w=2
> 
> 
>> Signed-off-by: Ivan Safonov <insafonov@gmail.com>
>> ---
>>   drivers/staging/rtl8188eu/core/rtw_recv.c        | 6 +-----
>>   drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 3 +--
>>   2 files changed, 2 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c
>> b/drivers/staging/rtl8188eu/core/rtw_recv.c
>> index 620da6c003d8..d4278361e002 100644
>> --- a/drivers/staging/rtl8188eu/core/rtw_recv.c
>> +++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
>> @@ -1373,11 +1373,7 @@ static struct recv_frame *recvframe_defrag(struct
>> adapter *adapter,
>>                  /* append  to first fragment frame's tail (if privacy frame,
>> pull the ICV) */
>>                  skb_trim(prframe->pkt, prframe->pkt->len -
>> prframe->attrib.icv_len);
> 
> 
> Your email client corrupted the patch so it can't be applied.

Thanks, Dan.
> 
> regards,
> dan carpenter
>