Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 1 Sep 2019 18:10:33 +0800
From:   Changbin Du <changbin.du@gmail.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     Changbin Du <changbin.du@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        yamada.masahiro@socionext.com, LKML <linux-kernel@vger.kernel.org>,
        Marc Zyngier <maz@kernel.org>
Subject: Re: [PATCH] genirq: move debugfs option to kernel hacking
Message-ID: <20190901101032.7pysfrpincyrci35@mail.google.com>
References: <20190901035539.2957-1-changbin.du@gmail.com>
 <alpine.DEB.2.21.1909010814360.3955@nanos.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.21.1909010814360.3955@nanos.tec.linutronix.de>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Sep 01, 2019 at 08:23:02AM +0200, Thomas Gleixner wrote:
> On Sun, 1 Sep 2019, Changbin Du wrote:
> 
> > Just like the other generic debug options, move the irq one to
> > 'Kernel hacking' menu.
> 
> Why?
> 
> Kernel hacking is a inscrutable mess where you can waste a lot of time to
> find what you are looking for.
>
yes, the 'kernel hacking' menu has many items now and are not well structured.
Let me see if it can be improved.

> If I want to debug interrupts then having the option right there where all
> other interrupt related configuration is makes tons of sense.
> 
> I would be less opposed to this when the kernel hacking menu would be
> halfways well structured, but you just chose another random place for that
> option which is worse than what we have now.
> 
We already have an irq debug option CONFIG_DEBUG_SHIRQ here. Maybe we can group
them into a submenu.

> Thanks,
> 
> 	tglx
> 
> 
> 

-- 
Cheers,
Changbin Du