Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH RESEND] arch/microblaze: add support for get_user() of
 size 8 bytes
To:     Leon Romanovsky <leonro@mellanox.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Al Viro <viro@zeniv.linux.org.uk>,
        "Steven J. Magnani" <steve@digidescorp.com>,
        Michal Simek <monstr@monstr.eu>,
        Jason Gunthorpe <jgg@mellanox.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Doug Ledford <dledford@redhat.com>
References: <99f83474-3e71-4325-ddff-cf23a172b984@infradead.org>
 <20190901064926.GL12611@unreal>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <a0711df8-50e1-c104-7603-929f8c4462cb@infradead.org>
Date:   Sun, 1 Sep 2019 07:55:08 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20190901064926.GL12611@unreal>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 8/31/19 11:49 PM, Leon Romanovsky wrote:
> On Sat, Aug 31, 2019 at 08:40:05PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> arch/microblaze/ is missing support for get_user() of size 8 bytes,
>> so add it by using __copy_from_user().
>>
>> Fixes these build errors:
>>    drivers/infiniband/core/uverbs_main.o: In function `ib_uverbs_write':
>>    drivers/infiniband/core/.tmp_gl_uverbs_main.o:(.text+0x13a4): undefined reference to `__user_bad'
>>    drivers/android/binder.o: In function `binder_thread_write':
>>    drivers/android/.tmp_gl_binder.o:(.text+0xda6c): undefined reference to `__user_bad'
>>    drivers/android/.tmp_gl_binder.o:(.text+0xda98): undefined reference to `__user_bad'
>>    drivers/android/.tmp_gl_binder.o:(.text+0xdf10): undefined reference to `__user_bad'
>>    drivers/android/.tmp_gl_binder.o:(.text+0xe498): undefined reference to `__user_bad'
>>    drivers/android/binder.o:drivers/android/.tmp_gl_binder.o:(.text+0xea78): more undefined references to `__user_bad' follow
>>
>> 'make allmodconfig' now builds successfully for arch/microblaze/.
>>
>> Fixes: 538722ca3b76 ("microblaze: fix get_user/put_user side-effects")
>> Reported-by: kbuild test robot <lkp@intel.com>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Al Viro <viro@zeniv.linux.org.uk>
>> Cc: Steven J. Magnani <steve@digidescorp.com>
>> Cc: Michal Simek <monstr@monstr.eu>
>> Cc: Jason Gunthorpe <jgg@mellanox.com>
>> Cc: Leon Romanovsky <leonro@mellanox.com>
>> Cc: Andrew Morton <akpm@linux-foundation.org>
>> Cc: Doug Ledford <dledford@redhat.com>
>> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
>> ---
>> What is a reasonable path for having this patch merged?
>> Leon Romanovsky <leonro@mellanox.com> has tested it.
> 
> I tested it for compilation only, we (RDMA) don't work on
> arch/microblaze/ at all and care about kbuild failures only.

Hi Leon,
Since I modified the patch (about to send v3), I dropped your
Reviewed-by.

Thanks.

-- 
~Randy